From patchwork Thu Apr 1 10:28:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Yingliang X-Patchwork-Id: 72796 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuZH-007IEO-Ts; Thu, 01 Apr 2021 10:28:53 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234345AbhDAK2I (ORCPT + 1 other); Thu, 1 Apr 2021 06:28:08 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:14666 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234118AbhDAK1v (ORCPT ); Thu, 1 Apr 2021 06:27:51 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F9zlv6ZfRzmcYy; Thu, 1 Apr 2021 18:23:07 +0800 (CST) Received: from huawei.com (10.175.103.91) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Thu, 1 Apr 2021 18:25:43 +0800 From: Yang Yingliang To: , CC: , Subject: [PATCH -next] media: ti-vpe: csc: remove redundant dev_err call in csc_create() Date: Thu, 1 Apr 2021 18:28:50 +0800 Message-ID: <20210401102850.1555368-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.103.91] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no There is an error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Reviewed-by: Benoit Parrot --- drivers/media/platform/ti-vpe/csc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/platform/ti-vpe/csc.c b/drivers/media/platform/ti-vpe/csc.c index f4e0cf72d1cf..ff15bc589f1b 100644 --- a/drivers/media/platform/ti-vpe/csc.c +++ b/drivers/media/platform/ti-vpe/csc.c @@ -267,10 +267,8 @@ struct csc_data *csc_create(struct platform_device *pdev, const char *res_name) } csc->base = devm_ioremap_resource(&pdev->dev, csc->res); - if (IS_ERR(csc->base)) { - dev_err(&pdev->dev, "failed to ioremap\n"); + if (IS_ERR(csc->base)) return ERR_CAST(csc->base); - } return csc; }