From patchwork Wed Feb 10 19:29:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 71411 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1l9vBu-003L4n-RH; Wed, 10 Feb 2021 19:30:23 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234437AbhBJTaF (ORCPT + 1 other); Wed, 10 Feb 2021 14:30:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:35484 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233591AbhBJTaB (ORCPT ); Wed, 10 Feb 2021 14:30:01 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D1FF464E74; Wed, 10 Feb 2021 19:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612985361; bh=f4eqWFuVO5ge+SyCC4GeWYJf01hOXe879q5QVVCru10=; h=Date:From:To:Cc:Subject:From; b=GaSmnmskgOV+nI0qH9DR293mu+sTX7buSqPxCvXaRdM1LL07DfgUWkpN8bu/uyrdl FtzZcipnivtvomxW3YmAeNn+k70pV1HBvEzuUZJnRcwT52pFIXT8WDfHRQRQksYPI6 fky0J8ueuSedZShThRpiF89VjFDZi3B8XhG4/n0CuQYpGtQ0g3beHISI601xsMUtst b1Qq/R2URV3gUf0kZ95DHQrf4Q99tSKlYeLh02oYYhG41EvHhA83ZZZemrb5hWrAoJ LL420x9lM+9bLwO6pnQY7sqCJy7CMn5RpNBCovCyCiPSMcOusr8W6KK9NJSiee5HoQ dXfHeJqUB9oPg== Date: Wed, 10 Feb 2021 13:29:18 -0600 From: "Gustavo A. R. Silva" To: Laurent Pinchart , Mauro Carvalho Chehab , Ricardo Ribalda , Tomasz Figa Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH][next] media: uvcvideo: Remove duplicate assignment to pointer dma_dev Message-ID: <20210210192918.GA838969@embeddedor> MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -3.1 (---) X-LSpam-Report: No, score=-3.1 required=5.0 tests=BAYES_00=-1.9,DKIMWL_WL_HIGH=0.001,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DKIM_VALID_EF=-0.1,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no Remove redundant assignment to pointer dma_dev. Fixes: fdcd02a641e2 ("media: uvcvideo: Use dma_alloc_noncontiguos API") Addressses-Coverity-ID: 1501703 ("Evaluation order violation") Signed-off-by: Gustavo A. R. Silva --- drivers/media/usb/uvc/uvc_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c index dc81f9a86eca..edf451a956d8 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -1105,7 +1105,7 @@ static inline struct device *stream_to_dmadev(struct uvc_streaming *stream) static void uvc_urb_dma_sync(struct uvc_urb *uvc_urb, bool for_device) { - struct device *dma_dev = dma_dev = stream_to_dmadev(uvc_urb->stream); + struct device *dma_dev = stream_to_dmadev(uvc_urb->stream); if (for_device) { dma_sync_sgtable_for_device(dma_dev, uvc_urb->sgt,