From patchwork Wed Feb 10 19:19:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 71410 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1l9v2w-003Kg2-GV; Wed, 10 Feb 2021 19:21:07 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234638AbhBJTU3 (ORCPT + 1 other); Wed, 10 Feb 2021 14:20:29 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:53887 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234626AbhBJTUZ (ORCPT ); Wed, 10 Feb 2021 14:20:25 -0500 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l9v1a-00015o-Qo; Wed, 10 Feb 2021 19:19:42 +0000 From: Colin King To: Laurent Pinchart , Mauro Carvalho Chehab , Tomasz Figa , Ricardo Ribalda , linux-media@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next][V2] media: uvcvideo: remove duplicated dma_dev assignments Date: Wed, 10 Feb 2021 19:19:42 +0000 Message-Id: <20210210191942.147083-1-colin.king@canonical.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: Colin Ian King The assignment to dma_dev has been performed twice in one statement. Fix this by removing the extraneous assignment. Addresses-Coverity: ("Evaluation order violation") Fixes: fdcd02a641e2 ("media: uvcvideo: Use dma_alloc_noncontiguos API") Signed-off-by: Colin Ian King Reviewed-by: Laurent Pinchart --- V2: Fix 2nd occurrence of this same issue. --- drivers/media/usb/uvc/uvc_video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c index dc81f9a86eca..6f2f308d86fe 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -1105,7 +1105,7 @@ static inline struct device *stream_to_dmadev(struct uvc_streaming *stream) static void uvc_urb_dma_sync(struct uvc_urb *uvc_urb, bool for_device) { - struct device *dma_dev = dma_dev = stream_to_dmadev(uvc_urb->stream); + struct device *dma_dev = stream_to_dmadev(uvc_urb->stream); if (for_device) { dma_sync_sgtable_for_device(dma_dev, uvc_urb->sgt, @@ -1586,7 +1586,7 @@ static void uvc_video_complete(struct urb *urb) */ static void uvc_free_urb_buffers(struct uvc_streaming *stream) { - struct device *dma_dev = dma_dev = stream_to_dmadev(stream); + struct device *dma_dev = stream_to_dmadev(stream); struct uvc_urb *uvc_urb; for_each_uvc_urb(uvc_urb, stream) {