From patchwork Fri Aug 7 08:35:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66110 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xmA-00BQSF-CS; Fri, 07 Aug 2020 08:30:57 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727024AbgHGIgK (ORCPT + 1 other); Fri, 7 Aug 2020 04:36:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726511AbgHGIgK (ORCPT ); Fri, 7 Aug 2020 04:36:10 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA952C061574; Fri, 7 Aug 2020 01:36:09 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id h7so1034733qkk.7; Fri, 07 Aug 2020 01:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=o5jxKv6AGUpMqPYX4rcg8Y6ClYjKX89Kxhh7saOpFoM=; b=dhFLyhzD15lHcsKFDPnlp0crGaMdObAVg/OSbLAsxs5pJnP6ERVO/zXRoef8cE7iZ/ +zmq6TaIBv2tJMEXWUKBW4MKQnlq9UvYR5DwH4Iez9jRqLVK3sADUX/IamPU0Tf24PFL aLDEeQPQTczCr9Vx4f1669wGYqBFFZqRYfhkLp9dvBOJZSVW5b6JLcuiYe+Gu4plmvu3 DNFuZ5U/in3smz4DVbJAPNlfxTrtiIutzI1feCdtmAbFG22C7s15zypPzQMbVcHYP+LO rpUSZLfJ8sVbxb1iQ/oVgIHEtqEQyEPuh2JrzJQbN7Z+TY+zwACeop9SLXcVBuR7h+Nh W9UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=o5jxKv6AGUpMqPYX4rcg8Y6ClYjKX89Kxhh7saOpFoM=; b=b40BDK1uXXev7SAyPAhZuDOu9AsUf8NE2+v0ltZLRrmqaYyNGvCT+cegFDZpBCu3Zz Qvcti9WEOHMb6nQTnlbHH/iDCNMvHpAY210vDlD2g0Z4UahqLMepwwZCA8zDkyza6Qxr ZEgdPp0tFKBQQgsAki5uzoULfGb7luufblUM7Zh/ok23IuT/bmlnrH1Vc0muzRfzS/Gd X7qurkQ5/M+Y0NZBnzvA8mxV666GLNROne9OQ+SOb4sGvbJ95IUzC5m+0CLBD+ryuwiY 8dgs/Vex6Og5TYNpxSvuSy0aHrCFvWHcz0ZLRSfl4HG86kEDLWAletuJRF/qaHbcuQIo rF0w== X-Gm-Message-State: AOAM532GM5469Hq+f8u7nDJJSLvFdSHsqrll4Wzwphk9rfaN3R1PLLJ/ Zw1uQoytdGL48StHNH7iHLo= X-Google-Smtp-Source: ABdhPJzLXuaNuBUAJkxY5f5H7E5+VUxW1JqrBrW9nuJ239/72kYuC86uQvEkINpqUygtjT5DHaaoQQ== X-Received: by 2002:ae9:ef43:: with SMTP id d64mr13215403qkg.326.1596789368992; Fri, 07 Aug 2020 01:36:08 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:08 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: Jernej Skrabec , Maxime Ripard , Chen-Yu Tsai Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/20] media: sunxi: sun8i-rotate.c: remove useless error message Date: Fri, 7 Aug 2020 05:35:28 -0300 Message-Id: <20200807083548.204360-1-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" This fixes the following coccinelle report: drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c:751:2-9: line 751 is redundant because platform_get_irq() already prints an error By removing the useless call to dev_err() Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c b/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c index 94f505d3cbad..3f81dd17755c 100644 --- a/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c +++ b/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c @@ -747,11 +747,8 @@ static int rotate_probe(struct platform_device *pdev) dev->dev = &pdev->dev; irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - dev_err(dev->dev, "Failed to get IRQ\n"); - + if (irq <= 0) return irq; - } ret = devm_request_irq(dev->dev, irq, rotate_irq, 0, dev_name(dev->dev), dev); From patchwork Fri Aug 7 08:35:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66111 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xmE-00BQSF-0G; Fri, 07 Aug 2020 08:30:58 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727078AbgHGIgP (ORCPT + 1 other); Fri, 7 Aug 2020 04:36:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726511AbgHGIgO (ORCPT ); Fri, 7 Aug 2020 04:36:14 -0400 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E188C061574; Fri, 7 Aug 2020 01:36:14 -0700 (PDT) Received: by mail-qt1-x841.google.com with SMTP id 6so750363qtt.0; Fri, 07 Aug 2020 01:36:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kdO3teMZpZhh4Zg2rIT12joG5MKLgBFbBUxDW1pI73k=; b=eIR16ZnQ1nthK/tYOCxXkv+uIJlqLI5IbwPoaSHYzG5gRu20ue9nD6QcbcUL6csLHq qJ2Bf3uuqmFtWK+oIJ5EzY3p1D25EFds9Q/z7v8P5eEDL2TVQ9mEVGerVe/8PbTl/Qsk D11fnpEB4jlA3GJjzTBBaivnKJQfkHoMpRl7Mes/NBarDLQ2EBA5tm3fKMVXCUX5p8NE VtI6+OpmTkmJ4j60tffXtyKIDmyO1/uEycScTE8E6FEgO3oFk0A8h/SRUTFFX4NyHy/D pAI5tBl+++1vqtgrdk6M+NIJOrts3ioniEWB22DpA+PlR4g7FKvH16B1edACnFjwhi+W txjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kdO3teMZpZhh4Zg2rIT12joG5MKLgBFbBUxDW1pI73k=; b=DwXflxIr0aYng0tZNcuTXEfNuxsGg8tnZ7B3e/CXmsbpD0IPeFpYOQhxxsUUvnbhgO fPCUOHgxKDRmjBlpq/vx+0W2fk0zIqG3AemOiaDUx3dZZnflq+7qh0ZsJmTNjDztYjZW BtS0kJZWr8xBkRem82LKmy/GxmM5dbSy6wqI3voRTPpaN6ecCW4zHIHN6eRTUHLNdcty cJjQwlaxu70QcMwQ0ovAM16IZFxGOCE2Y9q3ib9z/PZ0XcJAV8STUYzJLUEFpT0Brgo3 nS+9N/LjKsHGtGJ0dvKZaljM/XMnn162PHBdO5ULHIyRWft2tltWxgn4N8PSOlmUSWCC ec4w== X-Gm-Message-State: AOAM530/rzC3S1Z2DlMccmvAue2paDuNet+gamR7/9g9RtIMYzh6stmy 3k77orKkO78d42dV0cf+MFc= X-Google-Smtp-Source: ABdhPJwBojBnRxKGIEx2o9NF/V0VbhRIv+H1iWPd1xJmwPYqw7fbihn+NBWPgbuQol6WxM2CBA7iGg== X-Received: by 2002:aed:3947:: with SMTP id l65mr13322315qte.374.1596789373742; Fri, 07 Aug 2020 01:36:13 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:13 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: Kyungmin Park , Sylwester Nawrocki , Kukjin Kim , Krzysztof Kozlowski Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/20] media: exynos4-is: media-dev.c: use PTR_ERR_OR_ZERO Date: Fri, 7 Aug 2020 05:35:29 -0300 Message-Id: <20200807083548.204360-2-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fixes the following coccinelle report: drivers/media/platform/exynos4-is/media-dev.c:1273:1-3: WARNING: PTR_ERR_OR_ZERO can be used By using PTR_ERR_OR_ZERO in place of the existing logic. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/platform/exynos4-is/media-dev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c index 16dd660137a8..9346b08931e2 100644 --- a/drivers/media/platform/exynos4-is/media-dev.c +++ b/drivers/media/platform/exynos4-is/media-dev.c @@ -1270,10 +1270,8 @@ static int fimc_md_get_pinctrl(struct fimc_md *fmd) pctl->state_idle = pinctrl_lookup_state(pctl->pinctrl, PINCTRL_STATE_IDLE); - if (IS_ERR(pctl->state_idle)) - return PTR_ERR(pctl->state_idle); - return 0; + return PTR_ERR_OR_ZERO(pctl->state_idle); } static int cam_clk_prepare(struct clk_hw *hw) From patchwork Fri Aug 7 08:35:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66112 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xmH-00BQSh-57; Fri, 07 Aug 2020 08:31:01 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727108AbgHGIgT (ORCPT + 1 other); Fri, 7 Aug 2020 04:36:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726511AbgHGIgS (ORCPT ); Fri, 7 Aug 2020 04:36:18 -0400 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66389C061574; Fri, 7 Aug 2020 01:36:18 -0700 (PDT) Received: by mail-qt1-x841.google.com with SMTP id x12so744024qtp.1; Fri, 07 Aug 2020 01:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+JFdj4sPIeByfBYRmF6Vt6YCTyJ6MLJ/8TJDghwLhlI=; b=gCpC7fzeIm+LGpcHVTEPpJZ/qYf3NBmCWnEdXvNd8bPPSg3ETdXqAgp3s8CAu8vUCH FCZ0xIYvC/7P3l6/4C0rmj1aVAn122Ud91Yl6LYlwTFMNFb5mcSjXWHrg+5ISEcuWAsD 4c4YpKeY7IbyHfR5FUWXRvWiX/LdCBeumzsaUKQu03DoftsTiOWj3il9XwjWHd9z2HLs fhpoXN8yLApN3YrAsNg84d0H/oiFYnnETzI1r1nNeA2IiH4JsirBEvmwhOllOBYZtlWJ u2peodGRjn+EWGQr98qp3/VjxL3hh8foOj9HdOlODegN1by7d+ouJP6zIu3okWe4oSAA IkKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+JFdj4sPIeByfBYRmF6Vt6YCTyJ6MLJ/8TJDghwLhlI=; b=gD+duSO5tK0yTdyOWI0MT33c46Dqeyj1n+8T/U1V5zVw82rtd/akjVu31otlmhXQhQ G2XmFvObeu/XRqgIQrnc8xDPWbFaIh2B5AYRGNYtBCmFWl1BJfKJyrB5OkBxbCJTZ9VD Xnfza8G1j/RTh/QsMdrSgP6Pt2bGF0X1rDDH6V+4LKsNNkHaq11c0oZlKylH96g+7Uiu 3UWtEKhr1o8epdIUHXFohycR+XJRA2KnzYHpJQgUU9iq+kXDA4wGRc7hSxZCjFVarm6f AB40iu76cnhVUzgKqc8A4moRx52NW25zX0z8unTsAzVimmvonxHwrk9AtTXf+SmG473T S0KA== X-Gm-Message-State: AOAM531SE2y3tzQbtCT2eoqz/wd8YJ6DiDC94vfRLdtovaU4RnNlULLm 4m0+c4+aHz5z2OH1wSpM0KU= X-Google-Smtp-Source: ABdhPJx75PuruEt8qHJ8OOp1bhFr8Ltch/1Qp0AM1JHak/WmoG+fWRy+/rscLLvooLeS3Czxp7l7IQ== X-Received: by 2002:aed:32e7:: with SMTP id z94mr13069624qtd.17.1596789377617; Fri, 07 Aug 2020 01:36:17 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:17 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: Laurent Pinchart Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/20] media: usb: uvc_ctrl.c: add temp variable for list iteration Date: Fri, 7 Aug 2020 05:35:30 -0300 Message-Id: <20200807083548.204360-3-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fixes the following coccinelle report: drivers/media/usb/uvc/uvc_ctrl.c:1860:5-11: ERROR: invalid reference to the index variable of the iterator on line 1854 By introducing a temporary variable to iterate the list. Do not dereference the 'entity' pointer if it is not found in the list. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/usb/uvc/uvc_ctrl.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index e399b9fad757..567bdedc2ff2 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -1842,7 +1842,8 @@ static int uvc_ctrl_init_xu_ctrl(struct uvc_device *dev, int uvc_xu_ctrl_query(struct uvc_video_chain *chain, struct uvc_xu_control_query *xqry) { - struct uvc_entity *entity; + struct uvc_entity *entity = NULL; + struct uvc_entity *cursor = NULL; struct uvc_control *ctrl; unsigned int i, found = 0; u32 reqflags; @@ -1851,13 +1852,15 @@ int uvc_xu_ctrl_query(struct uvc_video_chain *chain, int ret; /* Find the extension unit. */ - list_for_each_entry(entity, &chain->entities, chain) { - if (UVC_ENTITY_TYPE(entity) == UVC_VC_EXTENSION_UNIT && - entity->id == xqry->unit) + list_for_each_entry(cursor, &chain->entities, chain) { + if (UVC_ENTITY_TYPE(cursor) == UVC_VC_EXTENSION_UNIT && + cursor->id == xqry->unit) { + entity = cursor; break; + } } - if (entity->id != xqry->unit) { + if (!entity || entity->id != xqry->unit) { uvc_trace(UVC_TRACE_CONTROL, "Extension unit %u not found.\n", xqry->unit); return -ENOENT; From patchwork Fri Aug 7 08:35:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66113 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xmM-00BQdQ-4f; Fri, 07 Aug 2020 08:31:08 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727785AbgHGIgY (ORCPT + 1 other); Fri, 7 Aug 2020 04:36:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726511AbgHGIgW (ORCPT ); Fri, 7 Aug 2020 04:36:22 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3198C061574; Fri, 7 Aug 2020 01:36:21 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id g26so1047579qka.3; Fri, 07 Aug 2020 01:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=u028S+fFJt0WDonYhSla2H06FxGLv3HsaKZA8/NTV3U=; b=fct+j866dTT8yhxVu4p9BEWAQWfFg7B1WCsLXzxCzK09fIdLuMwjGk68JmeTb3tE4C xcvtrZeDQqSqy6jQsezFEUSkc02Dnw6hBbdyBWgDV+Y7sPKSIc7MwAqpgAU3xwWUcAME X73HVkl3wmRsDWIf4KDsKmIPyXt20gUJbJ0uGxQQCUscnWy7rd5/UWPYfz6b3m5R4sEe JF2EVkvKTv871stwctscNYzvA6asYKpk5q3qZZgzoAVLIjrZY8e2+GeyJYnN+DOhcRjv TMEVhtQ5qfazVfO0ULSzP5+YHuoImkUmuuRi5MXkDxjfeFN3Ef6Isl8ob8HXQQiBuHtI F5dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=u028S+fFJt0WDonYhSla2H06FxGLv3HsaKZA8/NTV3U=; b=CdlxnbmHZGS5jNgvcv0ChG9nL5IXXzPiFSA9PQlRJlpvexC5pgoJ7UffgZ4iPaTtht nTdSkY03Z8FzKgGzWySZTkOcgerWXH65IvKy++WTr+J4S+WMVs4uHYEyLyxy9kcGRbK1 slKsyOuGSPJjG0GgRvQQnBP9VuTp7DKcMSRsfef9aY9WFiXByDpMeFjbdTg/CJjjzHZu uRgoBEaOtaG1MBwsjYrBy+K17flVB0kHFi7s30SG+gI3v/LXWjh2VhAQzi90pE3SROwh p62IKsuRmlOYjuqrhFGEYKwANLpMLVncPT8yYCjzw6w5VkkGyI3Tv4DBZBvBvX5VR2vO hbtw== X-Gm-Message-State: AOAM5305heLgYlBaUTs4iKmQUuYxUvPblLAedRl0KhsGYUnkpP1+9wx/ DvxTYAXAv/1mWMONPzC7WFc= X-Google-Smtp-Source: ABdhPJz50fMdpFDgtUWwmwGngCI6hJXZBt/UYJZ0cpWN3OJDgTRM+sNwM4b69Xolannxoz+E7GKSfw== X-Received: by 2002:a37:4391:: with SMTP id q139mr11994311qka.118.1596789381200; Fri, 07 Aug 2020 01:36:21 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:20 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: Laurent Pinchart Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/20] media: uvc: uvc_v4l2.c: add temp variable for list iteration Date: Fri, 7 Aug 2020 05:35:31 -0300 Message-Id: <20200807083548.204360-4-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fixes the following coccinelle reports: drivers/media/usb/uvc/uvc_v4l2.c:840:8-13: ERROR: invalid reference to the index variable of the iterator on line 836 drivers/media/usb/uvc/uvc_v4l2.c:851:5-10: ERROR: invalid reference to the index variable of the iterator on line 843 drivers/media/usb/uvc/uvc_v4l2.c:851:22-27: ERROR: invalid reference to the index variable of the iterator on line 843 Byy introducing a temporary variable for list iteration. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/usb/uvc/uvc_v4l2.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c index 0335e69b70ab..7205ef13c2e1 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -826,6 +826,7 @@ static int uvc_ioctl_enum_input(struct file *file, void *fh, struct uvc_video_chain *chain = handle->chain; const struct uvc_entity *selector = chain->selector; struct uvc_entity *iterm = NULL; + struct uvc_entity *cursor = NULL; u32 index = input->index; int pin = 0; @@ -833,18 +834,22 @@ static int uvc_ioctl_enum_input(struct file *file, void *fh, (chain->dev->quirks & UVC_QUIRK_IGNORE_SELECTOR_UNIT)) { if (index != 0) return -EINVAL; - list_for_each_entry(iterm, &chain->entities, chain) { - if (UVC_ENTITY_IS_ITERM(iterm)) + list_for_each_entry(cursor, &chain->entities, chain) { + if (UVC_ENTITY_IS_ITERM(cursor)){ + iterm = cursor; break; + } } pin = iterm->id; } else if (index < selector->bNrInPins) { pin = selector->baSourceID[index]; - list_for_each_entry(iterm, &chain->entities, chain) { - if (!UVC_ENTITY_IS_ITERM(iterm)) + list_for_each_entry(cursor, &chain->entities, chain) { + if (!UVC_ENTITY_IS_ITERM(cursor)) continue; - if (iterm->id == pin) + if (cursor->id == pin) { + iterm = cursor; break; + } } } @@ -1519,4 +1524,3 @@ const struct v4l2_file_operations uvc_fops = { .get_unmapped_area = uvc_v4l2_get_unmapped_area, #endif }; - From patchwork Fri Aug 7 08:35:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66114 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xmO-00BQdQ-MN; Fri, 07 Aug 2020 08:31:11 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727807AbgHGIg1 (ORCPT + 1 other); Fri, 7 Aug 2020 04:36:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726511AbgHGIgZ (ORCPT ); Fri, 7 Aug 2020 04:36:25 -0400 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FBF9C061574; Fri, 7 Aug 2020 01:36:25 -0700 (PDT) Received: by mail-qt1-x842.google.com with SMTP id c12so720642qtn.9; Fri, 07 Aug 2020 01:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pCOUWfwQGCxx4xFgjgJzdmxB0Ku9U+xacNCA0bE4G4U=; b=udMu3s8Ircb0KhEzwcbUl+bWG0t6TlZ4yD7XGtGLAx06W9xJG+ChSHoS8QExNhTzw+ xJ4cU2B2s1vrXlEqBa0CUM2m6ovQcMMDFkplruuc7N+quTmuvdopwoQLq2a1Akrs693J /sfMpTSp4+TNK/b9IH59SHlRUE7tIdTKZB0FEGlIduU0pBOfierHlhK79k43s630fF5W vizvvLIO0mndB1OwRDG0YMrj2BsWurDE8l+Dp3P/KFx7jZnIJ25RFDnUhyRWid5y759k 986bjo7xZZp/uOHCoAlM/hlhqeqMaRSN2fzjlQf664Dnk3bTyj4kJmuMftVQW3Xzl8EC OcIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pCOUWfwQGCxx4xFgjgJzdmxB0Ku9U+xacNCA0bE4G4U=; b=bmwHRkmA7GVEW4A85ffhzPr+FNKWXqXqe0DE+HZIiTtjQic6nUPnzuVBpv/ch18vem ftdkFvq7bkUtao2kf8k3Ohhyxiu3gzmWulszcHGCBilc5YBFfiWdpuq2+rKPvFvYRFUK +yQM3mqW++hhSvNKE9vlb9mYoIJc7PosSqonX3yvavBxfE3Pkg/I0GjCQsYvAhuKoemx FGO72YCN54jX5n7xVNGR+Oz/4bKsP3PSxsb0TNps/oxDYuiNTacxwn7sYx3jNw46Qm05 pCbgYUdBSjj7lPupQ71bObhhd3BN+AI0eQy5Pl20ADcZRu+YnpyM39NKRFMNFdCcyLOV uDaA== X-Gm-Message-State: AOAM5322xVGUSG5PcIqZ/QqyyJ2YUd1BWFL3a4yXkQruG76hWaNuPjHP umkkY0ou5dGjKyJObrqt9C8= X-Google-Smtp-Source: ABdhPJwdaoeBIf850FLeS5VojFgiOIwoQ2jg8MtkRmkfskN8YOCIayKqkj0kohLNVbJbVEly7fORdA== X-Received: by 2002:aed:2091:: with SMTP id 17mr12775857qtb.322.1596789384704; Fri, 07 Aug 2020 01:36:24 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:24 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: Hans Verkuil Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/20] media: cobalt: cobalt-omnitek.c: fix comparison to bool Date: Fri, 7 Aug 2020 05:35:32 -0300 Message-Id: <20200807083548.204360-5-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/pci/cobalt/cobalt-omnitek.c:119:5-19: WARNING: Comparison to bool By using "!cond" instead of "cond == false" Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/pci/cobalt/cobalt-omnitek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cobalt/cobalt-omnitek.c b/drivers/media/pci/cobalt/cobalt-omnitek.c index 4c137453e679..01b82a2e8d33 100644 --- a/drivers/media/pci/cobalt/cobalt-omnitek.c +++ b/drivers/media/pci/cobalt/cobalt-omnitek.c @@ -116,7 +116,7 @@ void omni_sg_dma_abort_channel(struct cobalt_stream *s) { struct cobalt *cobalt = s->cobalt; - if (is_dma_done(s) == false) + if (!is_dma_done(s)) iowrite32(ABORT, CS_REG(s->dma_channel)); } From patchwork Fri Aug 7 08:35:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66129 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xnS-00BQi8-Ur; Fri, 07 Aug 2020 08:32:15 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727829AbgHGIgd (ORCPT + 1 other); Fri, 7 Aug 2020 04:36:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726511AbgHGIga (ORCPT ); Fri, 7 Aug 2020 04:36:30 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDDE1C061574; Fri, 7 Aug 2020 01:36:29 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id l6so1036452qkc.6; Fri, 07 Aug 2020 01:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IYN7AynLXZAkrS6tmtd16cHkXNySIHUYTJRiIaQJpDY=; b=J+PAB7BFnuJcEvJOUOFwvZKOrQv2tDwpvVuibbxXgYkLeqAYcC7mRNuFKNYW336tTY 1JVNsLYgnqHxCq16+3i3HedQ8OwR/G4xbgQ2YPUzuVEeK5UGEL0MM32fQDtl1b2mYhlz 3HCev5eSMUcM7yqxzA4L16IZPvM+txe4RNEDyDaXKucm9SGBz82QsczJp4dXBBny81d+ xe/SeXGYEYUMF7h9Y3Y7IiK0FbY26W0B0OB3v2560UodIfx/BmozYGfBtf/QwiNTUnvS SAbKxNrkq8RLFHQJBy3a7fqae4BdfSL3+2pXXORyp5+d0GgetUKT6/vbMksnmJePba8E RaiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IYN7AynLXZAkrS6tmtd16cHkXNySIHUYTJRiIaQJpDY=; b=UpLUxT8f2n+IAqZvYZuWTD/HgCcZu0OX2TSKK5uN6fmKRwLMzsWXI1oDibcoau2wy/ AXDKrgRHOGowSYQAYCa0bWvlSmhlQ2XC8sqv4qHNKYAnaPJhWEsD4vbY/TSmVV0iQqml Wgj6SBgWjsJgbeLNegcVYJkpGlT12r7nc7XL/odU6OBMyf5nTTel2bEvm3wwp3Y/5HF0 KIw2PeVWa69JwrMYoYh2Aq3T/5eKEZQA0XpPXKduBXVI8MonpBbaWqQJwpz1Xi2Gt/zI BMNCwhm0v/tIUHOKEkyV6XU5T49GmrbPaaRy8Z3rm9gOmnmQVKXdJmTHru9/WmPamI4W SrUQ== X-Gm-Message-State: AOAM530AIg+ixNg3+A7xPIHJ0Dqli2Unt/ZTmupnEx6pqY5eA5ltO9Ow SHSa/xZLvEacNjkYZiMgV+YAtilcqa2bNA== X-Google-Smtp-Source: ABdhPJy82zmYuwBL7KQLpSLzdgP/wyy1vhF4Xnz4DYiXdnAZ3uXeGMNuMMlcIAO0/h9sv0gwnxqWaQ== X-Received: by 2002:a37:5dc6:: with SMTP id r189mr12169409qkb.364.1596789389099; Fri, 07 Aug 2020 01:36:29 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:28 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: Tiffany Lin , Andrew-CT Chen , Matthias Brugger Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/20] media: mtk-vcodec: mtk_vcodec_dec.c: fix comparison to bool Date: Fri, 7 Aug 2020 05:35:33 -0300 Message-Id: <20200807083548.204360-6-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c:197:14-35: WARNING: Comparison to bool drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c:198:7-29: WARNING: Comparison to bool drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c:451:12-19: WARNING: Comparison to bool drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c:1159:6-15: WARNING: Comparison to bool By replacing (cond == true) with (cond) and (cond == false) with (!cond) Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c index 0f3e710aed4e..dd4f6747a381 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c @@ -194,8 +194,7 @@ static struct vb2_buffer *get_free_buffer(struct mtk_vcodec_ctx *ctx) vb->vb2_buf.index, dstbuf->queued_in_vb2); v4l2_m2m_buf_queue(ctx->m2m_ctx, vb); - } else if ((dstbuf->queued_in_vb2 == false) && - (dstbuf->queued_in_v4l2 == true)) { + } else if (!dstbuf->queued_in_vb2 && dstbuf->queued_in_v4l2) { /* * If buffer in v4l2 driver but not in vb2 queue yet, * and we get this buffer from free_list, it means @@ -448,7 +447,7 @@ static void mtk_vdec_worker(struct work_struct *work) mutex_unlock(&ctx->lock); } v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_ERROR); - } else if (res_chg == false) { + } else if (!res_chg) { /* * we only return src buffer with VB2_BUF_STATE_DONE * when decode success without resolution change @@ -1156,7 +1155,7 @@ static void vb2ops_vdec_buf_queue(struct vb2_buffer *vb) buf = container_of(vb2_v4l2, struct mtk_video_dec_buf, m2m_buf.vb); mutex_lock(&ctx->lock); - if (buf->used == false) { + if (!buf->used) { v4l2_m2m_buf_queue(ctx->m2m_ctx, vb2_v4l2); buf->queued_in_vb2 = true; buf->queued_in_v4l2 = true; From patchwork Fri Aug 7 08:35:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66115 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xmU-00BQf8-2L; Fri, 07 Aug 2020 08:31:14 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727850AbgHGIge (ORCPT + 1 other); Fri, 7 Aug 2020 04:36:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727837AbgHGIgd (ORCPT ); Fri, 7 Aug 2020 04:36:33 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 549FCC061574; Fri, 7 Aug 2020 01:36:33 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id d14so1005376qke.13; Fri, 07 Aug 2020 01:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yEXAHDd933UU5IrgghuWIRbSYw8TfxYHRTaFu8VsYYU=; b=vafemYzrm3ka5M5odLoFLxlavT2sAYCa4jhehaWjzZvqmD2Vr18QBi5T0SaYILH6Si Y6dEGIt/wS+FXZl0FUcwWd1vAaOvB9MliY8UV8dHKCNbEswED8xsesBIUgW6g0XYHGp8 uHqjeazH9BWNhPfKjVc/fQN6eKcTkMNrUcONoUT2vSyJ2j9SWK/1berbRqGXhpXU7o0R vnYaScBVg0BntBkB6p9uFvyWQ2/zLbKE+T7UVi7se49RPe8RP/b8s510TMyPvVi5x3IH ITfiucStGBgC2sy/towWzQovnO1xkdo9IZjVmiahDtf61AjYDa5ToNCn8jY0PEJ4emc0 k75Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yEXAHDd933UU5IrgghuWIRbSYw8TfxYHRTaFu8VsYYU=; b=phkmSIR/2taVltzJlJvhq0NuLt3V/HbCoQ+OqWzTbRFfoGeu4HCrfYj1hYDktCV27g XD9UA6y46RhBJDeMKKqYIj4J/FSefPhYHmKfgqWIrIV87v592YgMTDq6/Dx0L3wrZGaL zvtdWi2tnxRN+1ZLQkOVoLsbfzzTZe5vEKruI4PBvqsA9c7jFqAiBHq0aFyWFe3N6wZL pJOFwPVLa2b3k5AaHIQBUKBznAh9As2kGVZgPW8FL51hnzYZCOfQSv+3/S9+3dBHuh01 P+5RraHlVIQkjWaKjpPZfDnSJsybs9SwMUkeSjL5ObDgttt0fX2yRsod+wYWXmY4BGa5 VD4g== X-Gm-Message-State: AOAM532JssRehcJmAcpTK71dPHo2kZ/JLavCRSOQeYESwMDfyHh4n3CY fv623X02ESO1JknnY9Wo9m0= X-Google-Smtp-Source: ABdhPJzW5tGPPuFjuolkx44QWWpMXnhNKbECB50jaOYdAAVGeJ6NPsf+EAcQvksK+gkICvHB36VYSg== X-Received: by 2002:a37:9945:: with SMTP id b66mr12742782qke.51.1596789392586; Fri, 07 Aug 2020 01:36:32 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:32 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: Hans Verkuil Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/20] media: vicodec: vicodec-core.c: fix assignment of 0/1 to bool variable Date: Fri, 7 Aug 2020 05:35:34 -0300 Message-Id: <20200807083548.204360-7-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/test-drivers/vicodec/vicodec-core.c:1674:2-21: WARNING: Assignment of 0/1 to bool variable drivers/media/test-drivers/vicodec/vicodec-core.c:1675:2-26: WARNING: Assignment of 0/1 to bool variable By replacing the assignment to 0 with 'false' instead. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vicodec/vicodec-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/test-drivers/vicodec/vicodec-core.c b/drivers/media/test-drivers/vicodec/vicodec-core.c index 8941d73f6611..e4a8d3a5eecd 100644 --- a/drivers/media/test-drivers/vicodec/vicodec-core.c +++ b/drivers/media/test-drivers/vicodec/vicodec-core.c @@ -1671,8 +1671,8 @@ static void vicodec_stop_streaming(struct vb2_queue *q) ctx->comp_size = 0; ctx->header_size = 0; ctx->comp_magic_cnt = 0; - ctx->comp_has_frame = 0; - ctx->comp_has_next_frame = 0; + ctx->comp_has_frame = false; + ctx->comp_has_next_frame = false; } } From patchwork Fri Aug 7 08:35:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66116 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xmZ-00BQfK-B8; Fri, 07 Aug 2020 08:31:22 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727837AbgHGIgk (ORCPT + 1 other); Fri, 7 Aug 2020 04:36:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727870AbgHGIgg (ORCPT ); Fri, 7 Aug 2020 04:36:36 -0400 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A447AC061574; Fri, 7 Aug 2020 01:36:36 -0700 (PDT) Received: by mail-qt1-x842.google.com with SMTP id e5so733758qth.5; Fri, 07 Aug 2020 01:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HM+pB+gegJETUTC8BtYwm1pgwV6KHTLqQbgt5bu8Qq8=; b=bZdXLbTYVurwEC6xi+YPZ4+960RF0X6/+S2xTN/Tf0zaHBVW17eWe5ecjpaP16lWsN xvded1AZrbUdEJ3hHs0s3kubWc/ImbJpNTNz4bUoWoXmepblKlM/STHcNn77pmKKBZh0 vpWQALpZIxUjSOmm988R599fx0pEK/xQDupMf4razT4VZHc3pO3sbGCsKQ87HZmn9JjO IJ4pmFS8NXU/EoV1YJhL/8BhJ7tJvvfEOvpy1WxfyG5xC2so4YfJVc0eUKGSl/VrsnSp q7IYaIVNy6krnJd73mbXGlSJ5Rw0obOILdqr3EaauWUO3CnT5CivHVxNUEbBkHiy0nij /ung== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HM+pB+gegJETUTC8BtYwm1pgwV6KHTLqQbgt5bu8Qq8=; b=BmDL1sxFAVrMAX3mPeZrAlwsS8lEbXqp1teFxx6SWoiwHlYP2Hg91g6ozeuCKZuQu4 pzTK6uArjw2XDr/eqRQectaxN0EZZyh+Eis72D1oxlcH2ZhqGELd/06zR+EHsApitJOq F8S08wYvO+pmHI3h8oVxsTT9TBW8XP4t4M/y6dQb7IPEiAkWzwDs1VsYaJ2qCZEwWIq/ wSib13edYwhjhSZEdoKiMJbA6TbPcP5T5XR+KVYzoMoCVOtgDurDmUPSmZdF5KpaNS4e AevNo71BrqpVWOD9+wyJ9DYRG++etKUberrEr6tdMkvKXxZLPRyFaBVC9yppBE8UaKPH EYuQ== X-Gm-Message-State: AOAM532uLS2Cwwj0X2vZvtuaWBO4O0cs55751wAdlOi+foggjmWBPUGE CyS37hF//j1lCtz21FVMM3RuynIkPzy7+w== X-Google-Smtp-Source: ABdhPJx84MtNtBOV38eDB3Rn3JvX/G2SrLdHXnRjL0jGLfNMWNPZWEsG8T6oQf6oSctneVPkUKilIg== X-Received: by 2002:ac8:7188:: with SMTP id w8mr12952874qto.223.1596789395676; Fri, 07 Aug 2020 01:36:35 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:35 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: linux-kernel@vger.kernel.org Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 08/20] media: pci: saa7164.c: Replace if(cond) BUG with BUG_ON Date: Fri, 7 Aug 2020 05:35:35 -0300 Message-Id: <20200807083548.204360-8-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/pci/saa7164/saa7164-buffer.c:254:3-6: WARNING: Use BUG_ON instead of if condition followed by BUG. drivers/media/pci/saa7164/saa7164-buffer.c:261:3-6: WARNING: Use BUG_ON instead of if condition followed by BUG. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/pci/saa7164/saa7164-buffer.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/media/pci/saa7164/saa7164-buffer.c b/drivers/media/pci/saa7164/saa7164-buffer.c index 289cb901985b..245d9db280aa 100644 --- a/drivers/media/pci/saa7164/saa7164-buffer.c +++ b/drivers/media/pci/saa7164/saa7164-buffer.c @@ -250,15 +250,14 @@ int saa7164_buffer_cfg_port(struct saa7164_port *port) list_for_each_safe(c, n, &port->dmaqueue.list) { buf = list_entry(c, struct saa7164_buffer, list); - if (buf->flags != SAA7164_BUFFER_FREE) - BUG(); + BUG_ON(buf->flags != SAA7164_BUFFER_FREE); /* Place the buffer in the h/w queue */ saa7164_buffer_activate(buf, i); /* Don't exceed the device maximum # bufs */ - if (i++ > port->hwcfg.buffercount) - BUG(); + BUG_ON(i > port->hwcfg.buffercount); + i++; } mutex_unlock(&port->dmaqueue_lock); @@ -302,4 +301,3 @@ void saa7164_buffer_dealloc_user(struct saa7164_user_buffer *buf) kfree(buf); } - From patchwork Fri Aug 7 08:35:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66117 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xmd-00BQfU-8D; Fri, 07 Aug 2020 08:31:23 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727893AbgHGIgo (ORCPT + 1 other); Fri, 7 Aug 2020 04:36:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727801AbgHGIgk (ORCPT ); Fri, 7 Aug 2020 04:36:40 -0400 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D132DC061574; Fri, 7 Aug 2020 01:36:39 -0700 (PDT) Received: by mail-qt1-x841.google.com with SMTP id 6so750893qtt.0; Fri, 07 Aug 2020 01:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kW4DH93+Y6MekGQ0yTdMeF4m8RvwlbzRUgeVylN+bnc=; b=bhZUXgB1uwCqf6lOrT1oH1JNXf4m3Faa69ENu+2ONNo5DlaPSxwdOTTpWBRfGJxwWb i6Aj7T0xTyi1s5JyXAJBwPtGmSJPxg39QJ183qjPK1UnRLZEojkZTvKnfI0ioyKRCAcL JQXXiezaC8BWmI/WuIz6BWQyoZskQW98mkq4m0SGib4MDSYOrUHTg0Jh2vQnAEuDkGGV a35wT7jU/ssmXhaLFjB4e5NDyz4k94qDU1U6BhkkIEbx50HMbtKhY07n+YXUqpXhbx6L KmrnjWMtI+R2Pif2Pqj+6bggxl2O1D5u3vAWyaLMjyI3fjI6bJFvcsB7fP5/BHu85x/d 2pkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kW4DH93+Y6MekGQ0yTdMeF4m8RvwlbzRUgeVylN+bnc=; b=H+mX8FzgETesFxooEylryoR6IgAYcCUCP4zEezGr1iEW39zTTEcppMCYDl4O69H+kz JkAitmiWQ0ssto5bQioaQoesbBowWjR++MUl9UQThPjrYAzaIfiSALT2y4HLLmVV1Arv pwfeTIvG7c+CwCxHO15Ti8uVD/Vf2c/CDEVLtn4uTDnYIiFuukhg3XmPa1pN7WNTXP2K HywhGglAKC4QIIfiHfsEij2TyLWCbInMZ1CKRWxjlfb+t2PkuMR5dyipn48xOuq7XLNR g/aFImfDIS7WGezsE8AlcgZ3WAfSoWJkTh3HpvCqnbuE8AbxpVXBqS7a/MkIDoVi7yZ7 X3hA== X-Gm-Message-State: AOAM532h0WEP5ewtkQur3pE1yGg362tnoPsbM/es1vR0Z5jrSk+VoRmm 6jCV2RkBUbPjjImH4eO0fax/WWKxg2o8Xg== X-Google-Smtp-Source: ABdhPJydo5k0Ftgy4SEjTrde/dvAoiW+2dkoiBC+Tki5j6w7QIQGaHkl5LCxShXUkhWMuaH4XUOPrw== X-Received: by 2002:ac8:1c3:: with SMTP id b3mr13102663qtg.240.1596789398872; Fri, 07 Aug 2020 01:36:38 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:38 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: linux-kernel@vger.kernel.org Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 09/20] media: pci: saa7164-dvb.c: replace if(cond) BUG() with BUG_ON() Date: Fri, 7 Aug 2020 05:35:36 -0300 Message-Id: <20200807083548.204360-9-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/pci/saa7164/saa7164-dvb.c:341:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG drivers/media/pci/saa7164/saa7164-dvb.c:483:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/pci/saa7164/saa7164-dvb.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/pci/saa7164/saa7164-dvb.c b/drivers/media/pci/saa7164/saa7164-dvb.c index bf8c2bb8852e..24421c116b0b 100644 --- a/drivers/media/pci/saa7164/saa7164-dvb.c +++ b/drivers/media/pci/saa7164/saa7164-dvb.c @@ -337,8 +337,7 @@ static int dvb_register(struct saa7164_port *port) dprintk(DBGLVL_DVB, "%s(port=%d)\n", __func__, port->nr); - if (port->type != SAA7164_MPEG_DVB) - BUG(); + BUG_ON(port->type != SAA7164_MPEG_DVB); /* Sanity check that the PCI configuration space is active */ if (port->hwcfg.BARLocation == 0) { @@ -479,8 +478,7 @@ int saa7164_dvb_unregister(struct saa7164_port *port) dprintk(DBGLVL_DVB, "%s()\n", __func__); - if (port->type != SAA7164_MPEG_DVB) - BUG(); + BUG_ON(port->type != SAA7164_MPEG_DVB); /* Remove any allocated buffers */ mutex_lock(&port->dmaqueue_lock); @@ -740,4 +738,3 @@ int saa7164_dvb_register(struct saa7164_port *port) printk(KERN_ERR "%s() Frontend/I2C initialization failed\n", __func__); return -1; } - From patchwork Fri Aug 7 08:35:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66118 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xmk-00BQfl-3V; Fri, 07 Aug 2020 08:31:32 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727902AbgHGIgo (ORCPT + 1 other); Fri, 7 Aug 2020 04:36:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727826AbgHGIgn (ORCPT ); Fri, 7 Aug 2020 04:36:43 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AAA4C061574; Fri, 7 Aug 2020 01:36:43 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id p4so1064063qkf.0; Fri, 07 Aug 2020 01:36:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5y9qAO4DMBYJ0COKqkndO8ZCLSN9cFjuTgCIXUypzms=; b=VhA0ICm2JCRZJ+/FkEFW5d2Ae5dyj789jCrDuggOdm30Ku6O5Z0xUk75nleJhOX7Iq sVIs2mDClW8hyZ7E5MyZIdAiIdnv8AOQEKcbLwtVxc2ybnT6fcijViBeyAXUblUS8Msx d7HkApO907x9KFP2V9y7ZD18iXkjz1TD00m+J4+bjR+ZCH2StX9EpdjoOoLP+Vj7S3hp 5LJaHCsRYTtue5i9szy5fHc4CbAzadRvhaZ6tFltDrBy+M46D7aYGcaGRwrmi6Tw33AJ CBsVfdfe/Gc7RA2JPnNeY8AeZO/JMrJAAGJmW/pExbMBjGpyA1PCPKWjYijDg/5hVJeM OnRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5y9qAO4DMBYJ0COKqkndO8ZCLSN9cFjuTgCIXUypzms=; b=Ig4uKpH6daiYSCQBLkWRXQ5C9DwyU8IXw3rSEW1Z6u2WtKtgXW8EhuNqg9CJXsmWwS oJ0JA7F6/nh1EVBYUqSBk/8aqX451jgyQ05YWorJ+69xvfchHI1c0YMZQ4KCA4Ng3BAI G2CYAO4f2FOMjmwq6waSYdZiRXXMHDYgbJjdMwqwFnANYqFHPhmo41ZrjbBASMj3V7Md B3383WSBQAU02R9uhlzYL0oz6IVBtvYNhdWo72Vlb2yuFuf7J39uBF5DgG3+FwSJj0yk 7HsahaXph+gTIjUskG8oRL2N+D8CMhaY/BjQAJ20Vr1XgUyepnizmtrp/S7zURsqTBx/ HsHg== X-Gm-Message-State: AOAM531AomiH8b+eGE78GfXK1Jd8jTk2L3hH9/+voqsWIKMFIzGIvn95 /pYfF3Ay3XXJ4brtxs/fx8MoH0Dng8M= X-Google-Smtp-Source: ABdhPJzl0Xq1KjrcgJoutOuGe0MUlGL0km97T5jykm5DRvq72W/Kw1PElFpLPNNIo4J16c3xoSvlHg== X-Received: by 2002:a37:48ce:: with SMTP id v197mr12858262qka.458.1596789402041; Fri, 07 Aug 2020 01:36:42 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:41 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: linux-kernel@vger.kernel.org Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 10/20] media: pci: saa7164-vbi.c: replace if (cond) BUG() with BUG_ON() Date: Fri, 7 Aug 2020 05:35:37 -0300 Message-Id: <20200807083548.204360-10-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/pci/saa7164/saa7164-vbi.c:707:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. drivers/media/pci/saa7164/saa7164-vbi.c:760:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/pci/saa7164/saa7164-vbi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/pci/saa7164/saa7164-vbi.c b/drivers/media/pci/saa7164/saa7164-vbi.c index 49d61a64c8cb..cb2e09f0841d 100644 --- a/drivers/media/pci/saa7164/saa7164-vbi.c +++ b/drivers/media/pci/saa7164/saa7164-vbi.c @@ -703,8 +703,7 @@ int saa7164_vbi_register(struct saa7164_port *port) dprintk(DBGLVL_VBI, "%s()\n", __func__); - if (port->type != SAA7164_MPEG_VBI) - BUG(); + BUG_ON(port->type != SAA7164_MPEG_VBI); /* Sanity check that the PCI configuration space is active */ if (port->hwcfg.BARLocation == 0) { @@ -756,8 +755,7 @@ void saa7164_vbi_unregister(struct saa7164_port *port) dprintk(DBGLVL_VBI, "%s(port=%d)\n", __func__, port->nr); - if (port->type != SAA7164_MPEG_VBI) - BUG(); + BUG_ON(port->type != SAA7164_MPEG_VBI); if (port->v4l_device) { if (port->v4l_device->minor != -1) From patchwork Fri Aug 7 08:35:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66128 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xnL-00BQhV-Bj; Fri, 07 Aug 2020 08:32:07 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727932AbgHGIgv (ORCPT + 1 other); Fri, 7 Aug 2020 04:36:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727911AbgHGIgq (ORCPT ); Fri, 7 Aug 2020 04:36:46 -0400 Received: from mail-qv1-xf41.google.com (mail-qv1-xf41.google.com [IPv6:2607:f8b0:4864:20::f41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5149EC061574; Fri, 7 Aug 2020 01:36:46 -0700 (PDT) Received: by mail-qv1-xf41.google.com with SMTP id l13so388731qvt.10; Fri, 07 Aug 2020 01:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=p7yN8/UE3bmxOW+3sD/+cxzuqhvnsobCII+RkxMM1Yg=; b=bZw7nImC6/ipXeOhcJmSKB+4cpDo0r3NGPtVqM6dihgN1UrZe08HuYbwuRsnME/d8o sDPTUTjJkKERPTgCarXGozrCtd0if81vn94ZMSaFSB8UjvAX4cOuD/er1P0bijA14ynw jg8qHynJwbiERmU9NyJ9hmvN/BLRy+mYEDP0FgY61ihN1uhA6+orGMrTpoyPF0XzCwel 9W6y8Hp7nLp11+Cx9Hme9PoHydhAq4mfb2jX09IOr3gAYlEdufWV9nCgCrRkfVeIcam3 GUT2pRaEG9UMPefZVWU0LiCdd+syTHovyMjuLIxSCLRS9SeakHnaazncPGYhE4RkMaOn CJ+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=p7yN8/UE3bmxOW+3sD/+cxzuqhvnsobCII+RkxMM1Yg=; b=iMqFSd/303uit+hAQaC9EaCW/rueBERuDBWNXZrs3ST7QYScHc/aX/OHRVQarTD1Fa ByIRrXDk6u4MkDeLAx5aRiPkJKYpNYQm/AnQXGKM1V6+z8Ia0nxbIrlW2eXfw28m+dkQ C9uWYb5rS18ocec8aPbCbRF1RcY3+aqM27z8qrKSOvEztM7aqEG997Y3d/2Agq/3+7Jo r2qtjt/Yr2fYZYZWBd0HUxNwlYI58sQkhpMwPUCGfuonM9RjPkNWPRragj8z69WwCY0p C7O4L8193PkQlgvGkY3LMOgpr+0Z/yWrPLsEc+Gv9FZeBPUnS7QqfFsdw9AWpSf39RXm f8ew== X-Gm-Message-State: AOAM532A1IF+RD/94GUXc2Lolxd2U2pX0zyJFwEc+YPwDat7duXt4yQj e69zLFYDXzA16LtxwlymWzAOpTOn2Bg= X-Google-Smtp-Source: ABdhPJxONuOawZin2ouaz4dvQaXyVGtBCE461GSTu3Z9ZipJKIbgKfblnk7vxOYvYc5cb7KDyx7Lxg== X-Received: by 2002:ad4:4c0a:: with SMTP id bz10mr12947607qvb.78.1596789405238; Fri, 07 Aug 2020 01:36:45 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:44 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: linux-kernel@vger.kernel.org Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 11/20] media: pci: saa7164-core.c: replace if (cond) BUG() with BUG_ON() Date: Fri, 7 Aug 2020 05:35:38 -0300 Message-Id: <20200807083548.204360-11-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/pci/saa7164/saa7164-core.c:579:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. drivers/media/pci/saa7164/saa7164-core.c:592:3-6: WARNING: Use BUG_ON instead of if condition followed by BUG. drivers/media/pci/saa7164/saa7164-core.c:898:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/pci/saa7164/saa7164-core.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/media/pci/saa7164/saa7164-core.c b/drivers/media/pci/saa7164/saa7164-core.c index 50293396658c..1d6f6667951c 100644 --- a/drivers/media/pci/saa7164/saa7164-core.c +++ b/drivers/media/pci/saa7164/saa7164-core.c @@ -575,8 +575,8 @@ static irqreturn_t saa7164_irq_ts(struct saa7164_port *port) /* Find the current write point from the hardware */ wp = saa7164_readl(port->bufcounter); - if (wp > (port->hwcfg.buffercount - 1)) - BUG(); + + BUG_ON(wp > (port->hwcfg.buffercount - 1)); /* Find the previous buffer to the current write point */ if (wp == 0) @@ -588,8 +588,8 @@ static irqreturn_t saa7164_irq_ts(struct saa7164_port *port) /* TODO: turn this into a worker thread */ list_for_each_safe(c, n, &port->dmaqueue.list) { buf = list_entry(c, struct saa7164_buffer, list); - if (i++ > port->hwcfg.buffercount) - BUG(); + BUG_ON(i > port->hwcfg.buffercount); + i++; if (buf->idx == rp) { /* Found the buffer, deal with it */ @@ -894,8 +894,7 @@ static int saa7164_port_init(struct saa7164_dev *dev, int portnr) { struct saa7164_port *port = NULL; - if ((portnr < 0) || (portnr >= SAA7164_MAX_PORTS)) - BUG(); + BUG_ON((portnr < 0) || (portnr >= SAA7164_MAX_PORTS)); port = &dev->ports[portnr]; @@ -1566,4 +1565,3 @@ static void __exit saa7164_fini(void) module_init(saa7164_init); module_exit(saa7164_fini); - From patchwork Fri Aug 7 08:35:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66119 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xmm-00BQfl-Ke; Fri, 07 Aug 2020 08:31:33 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727937AbgHGIgv (ORCPT + 1 other); Fri, 7 Aug 2020 04:36:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727826AbgHGIgt (ORCPT ); Fri, 7 Aug 2020 04:36:49 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 913BDC061574; Fri, 7 Aug 2020 01:36:49 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id j187so1013409qke.11; Fri, 07 Aug 2020 01:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kPkFIcSFokKvqTTqVmcPnp2f4e3lwJk4o7y95n1MRkU=; b=D2DaAEUzOKCb7TGI6DOVsPJRLnFUBxyYmyKABoBJ5taUVHtcWEA6oG0LRz2j/8hRmL EnnsibjHoaQgwbOnWXA+qvy3DvRRyrJfl85MbmWEA6YwWDr9/3hflJB69GMYDLtLUEQR Vsz3VMUeC8yqzASnBfwgdfNRbKb9HKWSvw/1/Iq2ZVMVTYcVYX8reKqGerD8Q4Bk6RpK pP/GpgQG86JWwC2yQ8Cn7UvGEMDVM9HMjh1i+EzVVZh2PB98HuZpvh2Lzz2hGRPV/um8 HJWK55HE4bWroOkdVFnrgvWNQ7BylHDomHHU9aIm5QTfCgNuqgwWlJj/56JwO6PbtTIl UeVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kPkFIcSFokKvqTTqVmcPnp2f4e3lwJk4o7y95n1MRkU=; b=hqOW4Ptq+Y7JbmPNLZDrmlzr1Cs2+4vRrr9Cwk0S9iajGO1w+YkUsf588aIk6Gq3Fu BAYKZy2e2aeZNdEyT2lqYR2uxTgna01dOYtSN4pYX2M/9g1CPjCFICH+LIenw380R1D0 ksQ34oH+qsqHdLKYY6tR02KGbYncsYUNo5ZKyerfLX8Bjc8TNVLDjrTEbKfOa44SvOMo sjidsh66PgSo1O0d7i7UjT/i6XJnwi0VwIcObjwVGPGXP+xiuf4MBGcIXrdQJX2WDKNr /Zd/rhGwoUqEgtRjXa/NuyC563MingGnm6jXXy9D+VaFH5HRDX08f6eSk6a+s/e0FsI1 liVw== X-Gm-Message-State: AOAM532o9BLM3vPx0RHwheZIsMLjKAhaWAnp1E2yvMqnrl3lptlxQm+X 7XxbzNwdhOGh6H8WLPNY1z/WpHSRZO4= X-Google-Smtp-Source: ABdhPJwUpDiyth/4I15fdaDZ8QJARvT0XSF+0JeDhsu+7pvdxLbDnhvEMt5AL1ULfayG+rOIOQz7QQ== X-Received: by 2002:a05:620a:5f7:: with SMTP id z23mr13039865qkg.206.1596789408463; Fri, 07 Aug 2020 01:36:48 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:47 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: linux-kernel@vger.kernel.org Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 12/20] media: usb: dib0700_devices.c: remove useless if/else Date: Fri, 7 Aug 2020 05:35:39 -0300 Message-Id: <20200807083548.204360-12-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/usb/dvb-usb/dib0700_devices.c:1741:1-3: WARNING: possible condition with no effect (if == else) Both branches are the same, so remove the if/else altogether. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/usb/dvb-usb/dib0700_devices.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c b/drivers/media/usb/dvb-usb/dib0700_devices.c index 4ef3fa98d20f..f027db979c90 100644 --- a/drivers/media/usb/dvb-usb/dib0700_devices.c +++ b/drivers/media/usb/dvb-usb/dib0700_devices.c @@ -1738,14 +1738,9 @@ static int dib809x_tuner_attach(struct dvb_usb_adapter *adap) struct dib0700_adapter_state *st = adap->priv; struct i2c_adapter *tun_i2c = st->dib8000_ops.get_i2c_master(adap->fe_adap[0].fe, DIBX000_I2C_INTERFACE_TUNER, 1); - if (adap->id == 0) { - if (dvb_attach(dib0090_register, adap->fe_adap[0].fe, tun_i2c, &dib809x_dib0090_config) == NULL) - return -ENODEV; - } else { - /* FIXME: check if it is fe_adap[1] */ - if (dvb_attach(dib0090_register, adap->fe_adap[0].fe, tun_i2c, &dib809x_dib0090_config) == NULL) - return -ENODEV; - } + /* FIXME: if adap->id != 0, check if it is fe_adap[1] */ + if (dvb_attach(dib0090_register, adap->fe_adap[0].fe, tun_i2c, &dib809x_dib0090_config) == NULL) + return -ENODEV; st->set_param_save = adap->fe_adap[0].fe->ops.tuner_ops.set_params; adap->fe_adap[0].fe->ops.tuner_ops.set_params = dib8096_set_param_override; From patchwork Fri Aug 7 08:35:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66126 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xnJ-00BQhV-3k; Fri, 07 Aug 2020 08:32:05 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727977AbgHGIg5 (ORCPT + 1 other); Fri, 7 Aug 2020 04:36:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727911AbgHGIgw (ORCPT ); Fri, 7 Aug 2020 04:36:52 -0400 Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F295C061574; Fri, 7 Aug 2020 01:36:52 -0700 (PDT) Received: by mail-qt1-x844.google.com with SMTP id x12so744672qtp.1; Fri, 07 Aug 2020 01:36:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=DUE252qTwG6pYCLxjiyv/ngOQ0xR7QYJFaL87GF2sMY=; b=uzMEy6rNW2UaFlJZyVl+dFCikep4y4iCyWPwSLeedw5+0Zudh7C8AIV5VdwlPZ0844 O7OEZjk1utvDHFmE4g+cNycNmzcjeRhZbzw1vO5QxVzYyX26IeVWU6zeD5R7XTl1EIb1 Pbt4nDYd5zhUfj1QNKHVu9Xg/izSwD6D94lIcMkYIdMAxT0GpRpS2W/+6YfPcBCyWCi7 lQYsOWTiq9T91YfUy6kKE/alB+Ipwf/n5OWkOcQWhTLGA7jetmICv4r/aeTSlbxr0k0X +1nwO90NkKlBJbyYAV9EePOXmZPzijcRmgr8n8zNadRfJXE55gN+Icm94LiaoX88kumQ mrQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=DUE252qTwG6pYCLxjiyv/ngOQ0xR7QYJFaL87GF2sMY=; b=Yij9PKhhXaC1hoPqMM+zOBDw/Y8+hCAAjkMdWZjBxU8En2jW2OGbGDXEAZmPjM5Y4g ThzJoMY/nwPuK+Kne+le3YHocQG/unaCqQ1G92uZacM+JUEWiTL+w6bTbH10ZhU+BYIp V/UDXqxBL+mNWnfFlnjpfettMRlj73xbAol6DKlbbbWaFRdjmDohKtU8kV42xIuNSezq n4Izw6r2+ilDynVKI2MN6bwiDiBYrP5SOe3co2mZr48BL774MFP5RijNY8mGD8spSnY2 xE14uKKE3KG2aCKUmFQbJEUJ7xL5dzpWAgnNp+uywF5UzjIQbFK1oYZlG/Opg5wIErvJ o+1Q== X-Gm-Message-State: AOAM532SAhGqqgAmbyTB0gQqJHVwwilPfBuuBtfDrEYrvNtolzVlaxob ocTRp0XrevUDqliY8c+/pD1xEkHdI8s= X-Google-Smtp-Source: ABdhPJwVt3BU8XXqA5PKNiPH9oOQgti5GL6+F3B0ymJfTvmoLaDFuU4c06USRyBWcKq7kD29+q895A== X-Received: by 2002:ac8:42ca:: with SMTP id g10mr13471874qtm.219.1596789411530; Fri, 07 Aug 2020 01:36:51 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:51 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: linux-kernel@vger.kernel.org Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 13/20] media: dvb-frontends: mb86a16.c: remove useless if/else Date: Fri, 7 Aug 2020 05:35:40 -0300 Message-Id: <20200807083548.204360-13-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/dvb-frontends/mb86a16.c:1455:6-8: WARNING: possible condition with no effect (if == else) Both branches are the same, so remove the if/else altogether. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/dvb-frontends/mb86a16.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/dvb-frontends/mb86a16.c b/drivers/media/dvb-frontends/mb86a16.c index 3843181bba16..2505f1e5794e 100644 --- a/drivers/media/dvb-frontends/mb86a16.c +++ b/drivers/media/dvb-frontends/mb86a16.c @@ -1452,11 +1452,8 @@ static int mb86a16_set_fe(struct mb86a16_state *state) wait_t = (786432 + state->srate / 2) / state->srate; else wait_t = (1572864 + state->srate / 2) / state->srate; - if (state->srate < 5000) - /* FIXME ! , should be a long wait ! */ - msleep_interruptible(wait_t); - else - msleep_interruptible(wait_t); + + msleep_interruptible(wait_t); if (sync_chk(state, &junk) == 0) { iq_vt_set(state, 1); From patchwork Fri Aug 7 08:35:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66127 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xnK-00BQhV-7c; Fri, 07 Aug 2020 08:32:06 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727971AbgHGIg5 (ORCPT + 1 other); Fri, 7 Aug 2020 04:36:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727826AbgHGIgz (ORCPT ); Fri, 7 Aug 2020 04:36:55 -0400 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95AE5C061574; Fri, 7 Aug 2020 01:36:55 -0700 (PDT) Received: by mail-qt1-x841.google.com with SMTP id o22so708420qtt.13; Fri, 07 Aug 2020 01:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EXGupTpGbvdG/fn/UKREirAgsAV1HujkQjqH/LC9r7g=; b=suCZmmO70LGOca+M4uJziOz/IpkT24FjNgmNJfQ/EHhK1febz7DPchJGzCMl6FRJaY 9uTjEVUyViy4YBJY7f/ekSjeRV+0tVooPDh1HH5s2vowJ2F8+DZvYazqzSopUd/cx32s bhvyBY4lYpghHPOtchdUCjT95jFQgBXAWXI++X81wn55y+rpYKRCeePq9v10J52enBnM UaLj0QA7Wpyask0wRLLdbhO2poVRCjRKXkJi13dALs6iHk5f9jr2F2i3Lsxza7WqV0jl ZOf816H8b2U3q8oac9lX9g371kIkNY4V7iUSFcy/1ft36I02V+jNIib9K9j7uwzP2f8T 81rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EXGupTpGbvdG/fn/UKREirAgsAV1HujkQjqH/LC9r7g=; b=BJRmvF3Ii2nAqwEHcA6bDeTEwlemuQAJlc69mGx4Cmd8wiX5ZEnr3p4WJmsbwqIbE2 nnpzeTNRo9bgv8V45Ek9MT9mwVqxXLN3cWKpY110/Lh0tzS9JEIBYLL+Rck/noX1WApN 3IiZhba5LdhrtRY//Qw/CALbkIWXoK/TsrVH731PO7LOrdYJzdeR6Ndu51AxaohN9sP7 q0XI0ZBj5X01i02wNJgD7LKK7a958fWhKM8HL60NUzhSC52kEaMKafOIEYZkhKag+ABw UwkIVkdwLe/E3INkvGs8LMvb6cA9ZsJi6XM6yM9p0wjHu/Bzv9SEmqxiktQC8WYvASUR yk+g== X-Gm-Message-State: AOAM533J6egOV9I8DKvA2CWY3HI+h/SY1b+BN0g2MFwsMumcb2Mx50EV nuGENWNOKb95fd9IJpLwiAp0ED4Pa90= X-Google-Smtp-Source: ABdhPJynUVAOIp/xQi+6G9Hx4cDsYO+uw4KlJRzHBupTbmTgktD5fogTSoRfrLixJwXwItQ3/yW9LQ== X-Received: by 2002:ac8:4117:: with SMTP id q23mr13252062qtl.186.1596789414575; Fri, 07 Aug 2020 01:36:54 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:54 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: linux-kernel@vger.kernel.org Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 14/20] media: dvb-frontends: lgdt3306a.c: remove dead code Date: Fri, 7 Aug 2020 05:35:41 -0300 Message-Id: <20200807083548.204360-14-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/dvb-frontends/lgdt3306a.c:718:5-8: Unneeded variable: "ret". Return "0" on line 744 Code was enclosed with #if 0 and thus this variable was not needed. Remove that code altogether. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/dvb-frontends/lgdt3306a.c | 27 +------------------------ 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c index d3c330e035c4..0247ef799546 100644 --- a/drivers/media/dvb-frontends/lgdt3306a.c +++ b/drivers/media/dvb-frontends/lgdt3306a.c @@ -715,33 +715,8 @@ static int lgdt3306a_spectral_inversion(struct lgdt3306a_state *state, struct dtv_frontend_properties *p, int inversion) { - int ret = 0; - dbg_info("(%d)\n", inversion); -#if 0 - /* - * FGR - spectral_inversion defaults already set for VSB and QAM; - * can enable later if desired - */ - - ret = lgdt3306a_set_inversion(state, inversion); - - switch (p->modulation) { - case VSB_8: - /* Manual only for VSB */ - ret = lgdt3306a_set_inversion_auto(state, 0); - break; - case QAM_64: - case QAM_256: - case QAM_AUTO: - /* Auto ok for QAM */ - ret = lgdt3306a_set_inversion_auto(state, 1); - break; - default: - ret = -EINVAL; - } -#endif - return ret; + return 0; } static int lgdt3306a_set_if(struct lgdt3306a_state *state, From patchwork Fri Aug 7 08:35:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66120 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xmt-00BQgD-Bc; Fri, 07 Aug 2020 08:31:40 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728000AbgHGIhA (ORCPT + 1 other); Fri, 7 Aug 2020 04:37:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727987AbgHGIg7 (ORCPT ); Fri, 7 Aug 2020 04:36:59 -0400 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FF5FC061574; Fri, 7 Aug 2020 01:36:59 -0700 (PDT) Received: by mail-qt1-x842.google.com with SMTP id s23so710882qtq.12; Fri, 07 Aug 2020 01:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hQh9vJ8qL7le/6UsFdBNNlZw71ZngpGJl8n3+9IJZGM=; b=HDgkuECLCWdP831R9shd1Dd4qBzLAP3roMHtzLmA+Tz3Q8BlRrmQ7YzLbQZeNFiwUo dWMB/QScPgYAkiqiW0Tt01rFcqymYC8fFc+5a2f5dS/OkyPZKKJMHCzH1xCljnPFWVgq i5RORXVr2fNU2EdqBMuf4+qgzbgxU7dAtwhnhbpV2tL5iSS42i2FA9nSKBZqr0r5hFq9 p5z+yFpvitqwwGkTCOWPGVnuNlGqyGPxlXNiZI4j79YeUKoNmWNnlQSmGuNl3FmhF5uY MA5PC+i9PFIBtkCRn9hmLrW1fNykiANjWRJiCBYxrkqN0YO6siC/gcJNipJMfFUf6tAL wnOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hQh9vJ8qL7le/6UsFdBNNlZw71ZngpGJl8n3+9IJZGM=; b=J0LfnsWv38c0Sa1QwE6iwlgOWp9vTAuXlA88Nbkq+gpBMXmx2F2KTIwXGTqLfrP62f 8djJRzDFZdd7RwBIguXQUdgdfDRkitAUYsKDzn1ciD7srIQX8CoPjVzGbNZtx0gVYypt hDQCPzRYHfmhtxHv9JpZarze3Jjp8OG1RHaHKGCKJPWSSk5Hh/KGrpKbeaKdwU/OtVmw fCKUn1OXsLQXLZfjJt7K8YjbYqbhDHi1mKz6NJZOtM9DUA3sIRsNsSMkYQ52XkPZSyjN JIJbnnmIXGDpp/vBZXf2kBRbT2VSEIJ8NBv4+epbc2M2cmll2823S399OoMC1by/yIvr zXXQ== X-Gm-Message-State: AOAM532rH+yAKba+MtJks/3DdUohjJIjqDr7vTFlRwgdaZrJXlh+Rb2x ODj7XDM66lWIdp5qdp/K04UjnVmRqXk= X-Google-Smtp-Source: ABdhPJxKV6/gqTIu2lJakDUq+jGgkp210KlhpKKuuiTVI9CdEfS7fgxQu1rQSdi7wXYCbG076Ilq0A== X-Received: by 2002:aed:3aa5:: with SMTP id o34mr13559045qte.359.1596789417960; Fri, 07 Aug 2020 01:36:57 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:36:57 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: linux-kernel@vger.kernel.org Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 15/20] media: pci: cx23855-video.c: remove duplicate argument in 'or' Date: Fri, 7 Aug 2020 05:35:42 -0300 Message-Id: <20200807083548.204360-15-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/pci/cx23885/cx23885-video.c:639:24-44: duplicated argument to & or | V4L2_CAP_VBI_CAPTURE appears twice, remove it. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/pci/cx23885/cx23885-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx23885/cx23885-video.c b/drivers/media/pci/cx23885/cx23885-video.c index 440d108b7ddd..a380e0920a21 100644 --- a/drivers/media/pci/cx23885/cx23885-video.c +++ b/drivers/media/pci/cx23885/cx23885-video.c @@ -637,7 +637,7 @@ static int vidioc_querycap(struct file *file, void *priv, sprintf(cap->bus_info, "PCIe:%s", pci_name(dev->pci)); cap->capabilities = V4L2_CAP_READWRITE | V4L2_CAP_STREAMING | V4L2_CAP_AUDIO | V4L2_CAP_VBI_CAPTURE | - V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_VBI_CAPTURE | + V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_DEVICE_CAPS; switch (dev->board) { /* i2c device tuners */ case CX23885_BOARD_HAUPPAUGE_HVR1265_K4: From patchwork Fri Aug 7 08:35:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66121 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xmy-00BQgP-F3; Fri, 07 Aug 2020 08:31:44 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728023AbgHGIhD (ORCPT + 1 other); Fri, 7 Aug 2020 04:37:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726609AbgHGIhC (ORCPT ); Fri, 7 Aug 2020 04:37:02 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 450E6C061574; Fri, 7 Aug 2020 01:37:02 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id l64so1026508qkb.8; Fri, 07 Aug 2020 01:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=I/Ou9tXrhWRK+MpvOUeSIUalY4pwA4fcAtCn4PXLR0k=; b=jzOwU/TJPHfOvxuasL2kEjf3CrLKB/5AZA010Knq5M8TaIvaXL8NE7wMuodqtNw0tI tqprMJvr/4rnJSxEwWeimCHHUZEMgxV6DDtlmzxGvBjs+/hKxcXeep0qPHK0Af6QzUJ9 1y1jYjAZ3lE1y8VYChwj8Edm8iiurzP0LqUBGM8DwzhDRNNWoXvTIbtxV9y+hBi/2AW6 M9ucAhZZ+5hyW6G6dbLpYsHx3DUOi48xVvYcohQuHM6zbzTs/OGbBg1G+jdNHwoT+Dyg /as4wl1iK2tGre5P3HvgVMjcYe7aPu4WD7ykfr9dE5fohpW9ZqA7wzr89u0czt+Ql8QX FYDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=I/Ou9tXrhWRK+MpvOUeSIUalY4pwA4fcAtCn4PXLR0k=; b=eh1g4yUbGbS7GDU1U2RWh+M/jJ3SsU4FJoS54iZ8nTr3ozyi3F2vcea+V+fNmQLb7X lWOmnH77A7stAoIMKM7dzyTm+U7Jfl3xrGJlI6BWwdjiyDg1ItpmDg1teiAtN9K1e6z5 S1ywl4mKC8Rqh2ZL4ZTXmA9zi+jw0KSdFZIjFTkiZY4q8tHVElSCqyczEG3YaK/SZMgX iEJmmP+rPxVmdz1l4cMakIr2CBZTDC4Wi+mvuSf33VPOgM/6eqwLIDuP5/Xg810fvAKA 38923Em2vWkURSDPa+8YnO+Lhu3Yg2nrpextwHmzDpLX9GHDeBwt1hAkLEXV0tnpI7j9 Kvuw== X-Gm-Message-State: AOAM532ghSoW3rSFYyCJOKtFSleHzIQp9g/wg+wryrc5MLir6YSDUb9X hnjvvyy54v+1ZzmqudrQ1es33cV63mYGQQ== X-Google-Smtp-Source: ABdhPJwKJVmcT8SH3+GgtwU6uGrCJSphBSQJK9HCbWbXbcFV2UxSK5KWobdaGQ3hxkW3TKab5yQXbA== X-Received: by 2002:a05:620a:24e:: with SMTP id q14mr12606378qkn.482.1596789421501; Fri, 07 Aug 2020 01:37:01 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.36.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:37:01 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: Dave Stevenson Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/20] media: i2c: imx219.c: fix assignment of 0/1 to bool variable Date: Fri, 7 Aug 2020 05:35:43 -0300 Message-Id: <20200807083548.204360-16-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/i2c/imx219.c:1191:1-18: WARNING: Assignment of 0/1 to bool variable Replace the assignment to 0 with false instead. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/i2c/imx219.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index f64c0ef7a897..1cee45e35355 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -1188,7 +1188,7 @@ static int __maybe_unused imx219_resume(struct device *dev) error: imx219_stop_streaming(imx219); - imx219->streaming = 0; + imx219->streaming = false; return ret; } From patchwork Fri Aug 7 08:35:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66122 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xn3-00BQgc-Hj; Fri, 07 Aug 2020 08:31:50 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728038AbgHGIhH (ORCPT + 1 other); Fri, 7 Aug 2020 04:37:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726609AbgHGIhF (ORCPT ); Fri, 7 Aug 2020 04:37:05 -0400 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD9D3C061574; Fri, 7 Aug 2020 01:37:05 -0700 (PDT) Received: by mail-qt1-x843.google.com with SMTP id e5so734311qth.5; Fri, 07 Aug 2020 01:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Cjcm36AvnfDFsuVsTiC9gQnjUW8TNDAUzbXM337fp6M=; b=R8d1jdSU8OSvGvoHM0NM7xy4wg9PyGd5N9F6Pg/OFsy876f2sT/70Jtb65Ii5wex3c oZLorEInZEnAa4Ik3krkehyQEoxDt3z8MRVH4KwBlF4iUvPF6OxQDu25pe20Ly+2FSJn j9RNaWnCsGSko2Ei3iZ/W4S1pUWZrTAaNxDUIzklh96ELeuMmtiR4AGa/3Rm8d+5LHYh Zp5gpOnkfrJpgLoQ/n700o9hxWeIA5nxelGv+wzSGd4O+wmxgVKAR3XqdILzfQEYF5cZ t7GDmo13z00NsE3l2EqNauqWAbC7kIJMv9PpEBR9vsZYGMKA89Qatl8EVt7b05HeiMj7 mVIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Cjcm36AvnfDFsuVsTiC9gQnjUW8TNDAUzbXM337fp6M=; b=TDnMFATmxtc4jyRPWDFp58ISCISdfePaabWAywY6+pa/EgH+X2+EIQCMuE7M0SqSBi D227E8jO2efGAt9SkvRWTSQLtwQf+Wpf6xtQN6GbLyk0CGUtAA+Pa/uffxlKcMVsZKxD otGAKmzzhRhRK+wL3pzZMCckPQ70LmmPdLXaK2bqchptsEI6EY2h51JtwN/I4rb4lLGB Cp9CvJtrUjXysbgEIGDOpH51qrAGlHpqPTeEZmyl0zoErCHxQtZFzTiLyy8Rbq+kBZ1U +gMF//ermgr9Dp9s0pwOEDc3kqDRUZ3muwhIeY5nQGoMVdTi/0LtAHMoIyHhvjLNjjkP aVoQ== X-Gm-Message-State: AOAM531qGDhplkneFJ0B6n5s5QLQcNqX9WGAszgJaAr5JunQ2JzKNEL7 hoC6T5kZF1Y+Jl4jCh8MOVE= X-Google-Smtp-Source: ABdhPJzAKF+nzvu6Pxx7efzL+AuCIggi+ivNPuqOYHhwzXwydOr6ve4uOGr33g6tNEvtBZUkVaGV8Q== X-Received: by 2002:aed:364a:: with SMTP id e68mr12710245qtb.260.1596789424782; Fri, 07 Aug 2020 01:37:04 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.37.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:37:04 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: Tim Harvey Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 17/20] media: i2c: tda1997x.c: Fix assignment of 0/1 to bool variable Date: Fri, 7 Aug 2020 05:35:44 -0300 Message-Id: <20200807083548.204360-17-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/i2c/tda1997x.c:911:6-21: WARNING: Assignment of 0/1 to bool variable drivers/media/i2c/tda1997x.c:939:2-17: WARNING: Assignment of 0/1 to bool variable drivers/media/i2c/tda1997x.c:947:4-19: WARNING: Assignment of 0/1 to bool variable Replace assignment to 1 with true and assignment to 0 with false. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/i2c/tda1997x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c index 5e68182001ec..483cc19ed75d 100644 --- a/drivers/media/i2c/tda1997x.c +++ b/drivers/media/i2c/tda1997x.c @@ -908,7 +908,7 @@ tda1997x_configure_audout(struct v4l2_subdev *sd, u8 channel_assignment) { struct tda1997x_state *state = to_state(sd); struct tda1997x_platform_data *pdata = &state->pdata; - bool sp_used_by_fifo = 1; + bool sp_used_by_fifo = true; u8 reg; if (!pdata->audout_format) @@ -936,7 +936,7 @@ tda1997x_configure_audout(struct v4l2_subdev *sd, u8 channel_assignment) break; case AUDCFG_TYPE_DST: reg |= AUDCFG_TYPE_DST << AUDCFG_TYPE_SHIFT; - sp_used_by_fifo = 0; + sp_used_by_fifo = false; break; case AUDCFG_TYPE_HBR: reg |= AUDCFG_TYPE_HBR << AUDCFG_TYPE_SHIFT; @@ -944,7 +944,7 @@ tda1997x_configure_audout(struct v4l2_subdev *sd, u8 channel_assignment) /* demuxed via AP0:AP3 */ reg |= AUDCFG_HBR_DEMUX << AUDCFG_HBR_SHIFT; if (pdata->audout_format == AUDFMT_TYPE_SPDIF) - sp_used_by_fifo = 0; + sp_used_by_fifo = false; } else { /* straight via AP0 */ reg |= AUDCFG_HBR_STRAIGHT << AUDCFG_HBR_SHIFT; From patchwork Fri Aug 7 08:35:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66123 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xn4-00BQgc-Mk; Fri, 07 Aug 2020 08:31:51 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728052AbgHGIhL (ORCPT + 1 other); Fri, 7 Aug 2020 04:37:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728050AbgHGIhJ (ORCPT ); Fri, 7 Aug 2020 04:37:09 -0400 Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7F02C061574; Fri, 7 Aug 2020 01:37:08 -0700 (PDT) Received: by mail-qt1-x844.google.com with SMTP id b25so742334qto.2; Fri, 07 Aug 2020 01:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=k9aUK2mQpB8IUygH+TuB5qk+mim3+DkPUwL5ZlVMSOM=; b=PHeeuNJ3apNOk15b2QOv8shZLy0RH/ehXfLnQRSBO/pRPQUro2N/otiSAX+vzct/TQ i5hTW6ZLbOykcrNAmMPZt8RAa3dEaXH+DPZS4i5hAYK4soNTjk4e4N92Xnk8ZsZaAcF5 mlth3TsASjt+nhTeG8H/ZMrLhsDkLXHFietLqViDCeclj+AsYaCah0ezU95UGFkxLsWP /ZEq9Jf9DX0H4VUHqm9XAXdIjBBa0fd0bhL3/gn7o3+ep9ULE/kCq5JGbSI0kVsXB+l+ 05wInMQrVHpOAT6ItExQbXhac2HFCTcSP3yuZk1RZCXoWIFtyVJj0REi7wZ0fgBafPla TjJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=k9aUK2mQpB8IUygH+TuB5qk+mim3+DkPUwL5ZlVMSOM=; b=GjkkcUYlIH//zhcu9rQUn7Mt69NTqCnZ2962/DR+L6uU5LDLAhN+L3Ah/uh1y4eJLw L392AozgB1zXAI48zWgMzxPgH9oTl5vQOs5RDiCVzQOuPfwjUIS63Qk/xdjhs+dwySW8 xTIGMdrqALBp+8u77ClgJ9OWZfyxaRw+0vRnfjEos3VqSfhcNihpd+z5kD3DXGCc3fKn R+YTfYZevH51Ha8QifukuL2iuYFTL0EedBvr3qkGmM1ovQYiWxKRDEBYsaNld5XGrE2X hOfrX2E++rtx3GBOs9Mhy5cNekNiqYe8KvgwU1sJCJVHlWbTo0p7rKkKw+nhasm/cKWf x2QA== X-Gm-Message-State: AOAM530BPBDKG04/DZcSPKSlwhJNU6yJKy869TkBZOsm9otRyQ8CO7iu e4fFeD9S2khW+sPUyinLekWGOF3baH2wrg== X-Google-Smtp-Source: ABdhPJxfPB9mOhGr52D8DmaLxitiBQWCE+ifnjrd7sQoC2MSZQCoqKKh2UHdXWmdFOHmQIjeEIX9yg== X-Received: by 2002:aed:2f02:: with SMTP id l2mr13204988qtd.48.1596789428090; Fri, 07 Aug 2020 01:37:08 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:37:07 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: Hans Verkuil Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 18/20] media: pci: cobalt-i2c.c: fix comparison of 0/1 to bool variable Date: Fri, 7 Aug 2020 05:35:45 -0300 Message-Id: <20200807083548.204360-18-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/pci/cobalt/cobalt-i2c.c:176:16-21: WARNING: Comparison of 0/1 to bool variable drivers/media/pci/cobalt/cobalt-i2c.c:180:29-33: WARNING: Comparison of 0/1 to bool variable drivers/media/pci/cobalt/cobalt-i2c.c:121:16-21: WARNING: Comparison of 0/1 to bool variable drivers/media/pci/cobalt/cobalt-i2c.c:125:29-33: WARNING: Comparison of 0/1 to bool variable Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/pci/cobalt/cobalt-i2c.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/pci/cobalt/cobalt-i2c.c b/drivers/media/pci/cobalt/cobalt-i2c.c index c374dae78bf7..10c9ee33f73e 100644 --- a/drivers/media/pci/cobalt/cobalt-i2c.c +++ b/drivers/media/pci/cobalt/cobalt-i2c.c @@ -118,11 +118,11 @@ static int cobalt_tx_bytes(struct cobalt_i2c_regs __iomem *regs, iowrite8(data[i], ®s->txr_rxr); /* Setup command */ - if (i == 0 && start != 0) { + if (i == 0 && start) { /* Write + Start */ cmd = M00018_CR_BITMAP_WR_MSK | M00018_CR_BITMAP_STA_MSK; - } else if (i == len - 1 && stop != 0) { + } else if (i == len - 1 && stop) { /* Write + Stop */ cmd = M00018_CR_BITMAP_WR_MSK | M00018_CR_BITMAP_STO_MSK; @@ -173,11 +173,11 @@ static int cobalt_rx_bytes(struct cobalt_i2c_regs __iomem *regs, for (i = 0; i < len; i++) { /* Setup command */ - if (i == 0 && start != 0) { + if (i == 0 && start) { /* Read + Start */ cmd = M00018_CR_BITMAP_RD_MSK | M00018_CR_BITMAP_STA_MSK; - } else if (i == len - 1 && stop != 0) { + } else if (i == len - 1 && stop) { /* Read + Stop */ cmd = M00018_CR_BITMAP_RD_MSK | M00018_CR_BITMAP_STO_MSK; From patchwork Fri Aug 7 08:35:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66124 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xn8-00BQh1-Nk; Fri, 07 Aug 2020 08:31:55 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728068AbgHGIhO (ORCPT + 1 other); Fri, 7 Aug 2020 04:37:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728061AbgHGIhN (ORCPT ); Fri, 7 Aug 2020 04:37:13 -0400 Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2D83C061574; Fri, 7 Aug 2020 01:37:12 -0700 (PDT) Received: by mail-qv1-xf44.google.com with SMTP id t6so406503qvw.1; Fri, 07 Aug 2020 01:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BzKR9fHjZx1AaQExoBve0sSYuiasNViTLdv1o+mD+6Q=; b=H3y29rNHBwvSlWePlB/j3lgL0GjywETBOcirj8u4yKtxpdyL3bfjuzj1jNQ5EEbIun yhuCUnuG1aS3fZd5k7Ll4pnVuJ/Lut2dxUG3V4WAYa9n3k+AFbapYGVfbvzJTPyGwf3x hVZgn2zlMhyv2vEvd/QwgvwRLDpfeGQGJyFilALVa8YkBuhRaHznJew8B+qNMNfuDHyc aGyswHBFi65Nzq8yIpvnrdufwDnYODviRJBL8w3qT/JqAtQ35Dq8KZ+hTvowLeHDG9s1 MgfZDBqal0gzosrEpu724SkueW2C+0n47rBuuwq8FBmACGHdaD8m2raBsXY1fMgoyFYW Qjdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BzKR9fHjZx1AaQExoBve0sSYuiasNViTLdv1o+mD+6Q=; b=WIdCUUsMwNK0iaeZ3IhPXaI7m9ooZ7Yooft5koBC/3r8bOwKsujJplbAZeifE+J/m9 bo11fxGkRHnr0ETPJ5qvVbPfN159lR+yfa+hyqjHTMXIs9pO3oSyrMK6Wz+KffMIn+J5 tYeu8HSkwLZbEDa/I9fEKAwFzXCNMSpgqdYFryMdhK8n2XK1oLKdMFwjHdUIXbOvhyv1 XzfMLfqGSAQ/R+ycfdfYsz0HeS0bSC6AUrrK/1T1u3uuHugPFNT4BTqY2QU3kRn/ssvE FvxWqbvQ/+XSyJpSiLqk+6lNBFIIEZ4vAMpP3WeTb/u7DTu9y5PUEj1eiab10FdHHmZd 5+pQ== X-Gm-Message-State: AOAM533ZHYk8jQZtKx/KANveEpWmf9tw0lXVT3CYH/SoYysR6mQgXX54 i3wmthtlatg/kXLcr4oV7+s= X-Google-Smtp-Source: ABdhPJyPXSw1O5XN5M+Y93vNG6SmqTGTE+fS2tcUjgOTE1aFXJcHY99JP5iwSURFXJyCOfKPclrqbw== X-Received: by 2002:ad4:54d4:: with SMTP id j20mr13485713qvx.6.1596789432215; Fri, 07 Aug 2020 01:37:12 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.37.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:37:11 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: Benoit Parrot Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 19/20] media: platform: vpdma.c: fix comparison to bool Date: Fri, 7 Aug 2020 05:35:46 -0300 Message-Id: <20200807083548.204360-19-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING: Comparison to bool Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida Reviewed-by: Benoit Parrot --- drivers/media/platform/ti-vpe/vpdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c index 2e5148ae7a0f..de600ffffbbc 100644 --- a/drivers/media/platform/ti-vpe/vpdma.c +++ b/drivers/media/platform/ti-vpe/vpdma.c @@ -943,7 +943,7 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv) spin_lock_irqsave(&vpdma->lock, flags); for (i = 0; i < VPDMA_MAX_NUM_LIST && - vpdma->hwlist_used[i] == true; i++) + vpdma->hwlist_used[i]; i++) ; if (i < VPDMA_MAX_NUM_LIST) { From patchwork Fri Aug 7 08:35:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 66125 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xnF-00BQhE-KL; Fri, 07 Aug 2020 08:32:02 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728087AbgHGIhT (ORCPT + 1 other); Fri, 7 Aug 2020 04:37:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727922AbgHGIhR (ORCPT ); Fri, 7 Aug 2020 04:37:17 -0400 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2658AC061574; Fri, 7 Aug 2020 01:37:17 -0700 (PDT) Received: by mail-qt1-x842.google.com with SMTP id s16so724034qtn.7; Fri, 07 Aug 2020 01:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2yb5QPDam+5IEgCEDv8doERVGtgdGpfjdx2bUCpxyBo=; b=h1ooMgGiGLgaAh8SRDKWMxzu8381us1FoiBNDtCqOFHA8B7K/+KymRUACbrb3z4bTA CRTHdn8LgeSiaQ9vUmmGWFo9lbLS256Ud/r5Bmz5TXt6kqbv1sPC1CFglNLVJ7mE9Gc9 Ga6eo+vbV3vZNZVFhiU+r0lTSQsC928zA2QOKPuXjBz7uafsHCt1XY3l9x58+dKskatW Z2+8uU7fffT4r6Mct87ItP/ijG7QTgqgvPQqlmg+EeuZ5h5S8IEdZbWv5p2AIhNOwwQf +sO6FjS9ZEHn/oNWSRNITXi+aoXFOQ/GRxIGkdImh3D6UDSES6lL6lymZiGykPCz1IpT djUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2yb5QPDam+5IEgCEDv8doERVGtgdGpfjdx2bUCpxyBo=; b=gq13A2pQUN2/RAY5yD1Ao4OzCIInf/jXYlJnY+okh2e3WF57ABh/+KkSgir9UbnKOn pPGwwIu6hr7SUyjzjwmqZiil9ubdN86m7cdoLydp7MvDV2h6l6q53HtplY77whOgW51E rXNzfyP7zhZipq5yDXkaaG2OGW+9gZb5AJMEEKsaAcIs/2ztS2Paa5mhArnR1Gzk1X5D YF4dC6uFQN5eMZxUoiSwQgioas78QQG8yxq2/M2AGKrG5rGbEecfF4wx5gzDqgekFYfb C7BZT52vwXyrU7DGj81Er7Nria1uyfPB+HvR0T4Uu2dtLI68ziZMPAXKLAJ9H2PeMu4s wUUQ== X-Gm-Message-State: AOAM5326MLVIVz2sYGtV0CFyasn2vOPMivZXvyx6OpCh3T9A+FD3zdWg UdctnZkN2xZfzcTHnwq62Sb0xiz0ho93bw== X-Google-Smtp-Source: ABdhPJzN0DqAoHav6RSn7l+R8YeBljVvTs4nbpT97KunEwaN4r8GPW/u/jWmcPwaqp6xjolviYrYcg== X-Received: by 2002:aed:3947:: with SMTP id l65mr13325137qte.374.1596789436386; Fri, 07 Aug 2020 01:37:16 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:37:15 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: Matthias Brugger Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 20/20] media: mtk-vcodec: vdec_vp9_if.c: fix comparison to bool Date: Fri, 7 Aug 2020 05:35:47 -0300 Message-Id: <20200807083548.204360-20-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c:963:6-31: WARNING: Comparison to bool Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c b/drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c index 257a5b5ad212..c612d041aafe 100644 --- a/drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c +++ b/drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c @@ -960,7 +960,7 @@ static int vdec_vp9_decode(void *h_vdec, struct mtk_vcodec_mem *bs, goto DECODE_ERROR; } - if (vp9_decode_end_proc(inst) != true) { + if (!vp9_decode_end_proc(inst)) { mtk_vcodec_err(inst, "vp9_decode_end_proc"); ret = -EINVAL; goto DECODE_ERROR;