From patchwork Fri Apr 24 23:19:24 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaolei Wang X-Patchwork-Id: 141841 Received: from sea.lore.kernel.org ([172.234.253.10]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wGPpd-00011A-0k for patchwork@linuxtv.org; Fri, 24 Apr 2026 23:21:11 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 34C7930151E0 for ; Fri, 24 Apr 2026 23:21:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 14A9E379966; Fri, 24 Apr 2026 23:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="DC3dqXYw" X-Original-To: linux-media@vger.kernel.org Received: from mx0b-0064b401.pphosted.com (mx0b-0064b401.pphosted.com [205.220.178.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E946359A91; Fri, 24 Apr 2026 23:20:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.178.238 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777072860; cv=fail; b=AUkr//QvzmvQ4hZYMy/PQSliikgKhgLbSKIbl97Cc4717EWRXPSEC8zSJyKxGtOioz2bU3hz4YDOuLD6os7sEgLpDHRmspPTtJkrhfn1O7nbReqOAVKVX4300vZlskODqUPApk8VJ0hXFZ+DSg0IQZZfNLcoVP09o8rn3Ar96rY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777072860; c=relaxed/simple; bh=Hcgs70l3YfAM8wyA0zd6t2Ii101QV9/Gc01wKOezIac=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=lVn5Tpz+gITcQvlyjRK0Bb3rPsBgDSerRLZK57MvGEfUurcsumNYC9hxWUD6Vm0C10af85crrcZ7gBOG5BgqW6XC5XIAR+yYEXKTAi5f9be4R4wf03EpxfFUDTCe/xQsXhQn7bbHU0wL2ob4hjmpS8mvjE/zfRa0qjmsq9Fek2o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=DC3dqXYw; arc=fail smtp.client-ip=205.220.178.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Received: from pps.filterd (m0250811.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63OEYPH8697676; Fri, 24 Apr 2026 23:20:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=/A8IoIsIuVtdfrnmo2fIFXoPIMQjScSjh3nykQ1cSP4=; b= DC3dqXYw7rw4wv7GQ4z5+nTSXh4JiHo4thtgAm1d8Tp/tF3wNVlImw6WrQA8AyBr aAvfNnOy79FeVZyGfcMdkl9S9nQh8QMiUlpyDERligyD+yIwd58BbV38XLuYZ/A+ 4i9ZRwDmL5ITnnqQOhVnhjYbK77WEy3ja3idDsS3Ys7cXuWfyB1cRYSC62nq51M4 jxubpjEFJ7ZHq9iqwiihiucWluA00mZjKCMKBbtfqJ/mvYK8AkvtdIutxjQa31Wf +tc3ArKP26rlSej2IqRwM9lXoV4raxpHUGlJSt5T4lQMxzZmz2FY8JER48Xt+2fK kA2EFH2jm6r1X2nAQxaybw== Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11012065.outbound.protection.outlook.com [52.101.48.65]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4dq8qc2nb3-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 24 Apr 2026 23:20:03 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=A3V3ofj1A4IPeGSLlIeAeikQydPrU41zM2fhIxfUpZZrIUY8PEQfyIq73WEjHgp9mgrNALUAbv+RYdDicgXqOHXdYK1cNMwmF5h7nDBcHzGxPt1ZjSz1tVr+iGgiPnPv49mpgOC183p0J5/fFijOAbtv4u9DfZscWCJFx0juS55eGrfzU/O3c5jW97py7/cpiEnrxvdQh5P0yP7ROUPFA9f6Lu65sYFWTXti4qTca9/WWa++JVwHbJlki7NTP/G8sshJqTktDr28Oofcn89e6c84xmXISXdk/e1Z/x20rwcHA/jeL/7HQSvTV7OahMw1K+xSZvPxxj65V6ZMKZuNmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/A8IoIsIuVtdfrnmo2fIFXoPIMQjScSjh3nykQ1cSP4=; b=I1OicE3NDC3+lLczYsACgm6K2F51y6Eynl5fWnWOyQICMpdLD3ynww494xUc9eRzbL//i+MBCw/izMfX/ch31AhbI+t7mjue7VqJG5G1snffvx8AnX0UwFkzg5k2SSCxNAQdiPpH50LEeJX9WP1YmDo1ty30q1fkFmDzb/zqkNbRSLwYBnzqaXOMQsgFgF02KmljBgMJm7aqxtMbhXsFCWNBUb7fkFPPSnVRGLRXTvbsd8dMSmjKJcvQpWgE4gB6l30mttAwrAZqP7K1Oc1cTZbrqXf9AsdKWNfxxv4H/MrS4/JLzfpM4SZmXla3PXRC9lHjaFGjXm/0EQh7Ua/lHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DS4PPFD667CEBB6.namprd11.prod.outlook.com (2603:10b6:f:fc02::53) by PH8PR11MB8061.namprd11.prod.outlook.com (2603:10b6:510:250::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.22; Fri, 24 Apr 2026 23:20:00 +0000 Received: from DS4PPFD667CEBB6.namprd11.prod.outlook.com ([fe80::b919:1e6b:48a6:f655]) by DS4PPFD667CEBB6.namprd11.prod.outlook.com ([fe80::b919:1e6b:48a6:f655%6]) with mapi id 15.20.9846.021; Fri, 24 Apr 2026 23:20:00 +0000 From: Xiaolei Wang To: laurent.pinchart@ideasonboard.com, mchehab@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, aisheng.dong@nxp.com, jacopo@jmondi.org, guoniu.zhou@nxp.com, s.riedmueller@phytec.de, Xiaolei.Wang@windriver.com Cc: linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 1/3] media: imx8-isi: fix use-after-free on remove Date: Sat, 25 Apr 2026 07:19:24 +0800 Message-ID: <20260424231926.406079-2-xiaolei.wang@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260424231926.406079-1-xiaolei.wang@windriver.com> References: <20260424231926.406079-1-xiaolei.wang@windriver.com> X-ClientProxiedBy: SI2PR02CA0032.apcprd02.prod.outlook.com (2603:1096:4:195::12) To DS4PPFD667CEBB6.namprd11.prod.outlook.com (2603:10b6:f:fc02::53) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS4PPFD667CEBB6:EE_|PH8PR11MB8061:EE_ X-MS-Office365-Filtering-Correlation-Id: cb852884-20ae-42ba-c947-08dea2580185 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|7416014|376014|1800799024|56012099003|38350700014|22082099003|921020|18002099003; X-Microsoft-Antispam-Message-Info: CMTAwe0d87Ti5TvETn24T5cttCEjFV6Qw2J/ewbU4OXrBDI6VxA9ByXRcsnWVnRCocbPBd6rKZTfRP2DqRHtL1aEDRKQ4VI/KCeJspr49TJWNlRa70m2l59dKCzYYGpeCG3/COpNFXTCmwHQ5qG5C6GUuYlTBF7tRaJssuENKyB018c4w6TKpBR3go+1gLN0+OZNVwxMkruzwd5+KAI9ieEazPTiJBzbarKPUIIcb58OiTkeYJ/JbJ0rKm6TgkBkwgqia5cSYbGyh8rQE0gtO6qFLuuuEyAbkGRgRsj/bXahWx7YdgNrfGDJAB8/aczl3ALmUD66zf9npvIJUjHvReQFAreC1V6j6O2N1phR6K82TdCQhvfVz9aS3p4SEJuj5L4u43FLFZCdsGR00vMRmhvR8hOSwIuFhnqgRk0jKXOf2sDek1ZerFmx3FcGHyObfrMfeNFCzSOV5nPm0JRZ2xImmaZEMUX7z6q0IugSwyk5CUCUL7AD/cG1XuWpboc5T1Fe/dhMQ5nkvBEMdkX9JViJStB+K8AU0FllUolZshwS/Q9ps6Rk0L5XzFJGlZKkR+6AzNVFes2DkTs4VO+PlSWGDuyW0osEs+Aas3s8tr8hWwULw5AeXz88vzI43+0NBT4DzFEQrn6+nhjzSRaIcNnpEp0nTN5GKE8kcyHIccCveAgCzg3yTfx7K5iv2tOP9aGMNOlwJd1l/itO1P1iGgb/rTIRy8OLP96/JPSi+u+CEUznoUpuklKMSrxVVL9zEm+tXTIaDvdIQiE5OVFdveO2XHZWfKRGnX2e2jtcubih2OPVLloWZh+6LAGGpM2N X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS4PPFD667CEBB6.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(7416014)(376014)(1800799024)(56012099003)(38350700014)(22082099003)(921020)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qOIg6Oo5NNPVK2ClQis82UpZCdCsAuDQIfGSAUFZ4ouLDiW+KHrMJel+JuJ5YsIF5qrJVZ3DFdPogBhsMnbest37Qcm8et3e3R97/B2oC2oAem5XNJRO0r8wjR6jHtyxqG45jvigT7UpwArvZoRE3XeUhVuJXMBFztSqgCIHbbsQ92hQ80YC/8B974mdpHsiI7VHHRD3ZtezCjEMb5t7wtioEKD/ttPmj47hS+VQwHB8R97ZcuzzYjpRKAQ5u11B2LLJFDQluLmgBVkC34PVE7mV/1QMHa51SmMGVf7HTB4hs/BMlmAsK/eS5XgbmT4zhPGs3GqjU++vDQyrvAXcOwVk5A/7SE64yTeiVbaRoaKB4louMKZS7+YtLM6fM1KqlkWMRtWv9sz5ip7e1RazHIrPjKT2GgsikRsfSx0JK7cI09BLTMHDTZXArjMZcPQJZmYOydRZpjXeuerdaws2S152wEOtT+oJondJAarPD/Cdf4RUDPv6XMXOA8lV3xJbfc7QWyj0T3HGdiAzFJaEo9ChTtkO9xEf9ZZ3sUckT4cRCX6zKW3GGsfWtMMZv4fHNzESZhnve/AQQhuAPpVLM4wIiDm80gR5SDtrdPP2Kex5SeNctpIPAsnsflzD5aNNudOuJ5YPrbNYPQxSoGWiEP+WrDjzell0bChsQjbaJ4XuhrMu2QffavlenSaw57qvLvANPUMtkpv7No7RuX7uhYTYdYRe0+QtMe6WqroXEAepv1amSjDiww852TTXEvAxL9OZW4RkQgisoz7bjGO8i+4j09KGeBj50Ve48BSp3eE87G789/mjbz/LCrJdfbBUNzdlh3L45R8Od/DhnnZyamRPzrhUfTETDdQaHNa51sK45V83yBjhMeLx//zBJuG+Y4vdSiFWORValmIrrYdsdQWHvxUujtaU9s3y2PznMwViqRI2S43bQWVTPIGhZZ7Y3Gh7JDLiC8lEel1PmtoDKuAnn93bE1b6/OXxxyH71XcWF2U5PlT/Jq1PgbC9MF+tfVMUidEfa93/WhHSCDiXT4jyRngPQS/9XhpDcYRFH+CqWjWUtoizuF0B6XRXiC33p4tWZoFX2zYjcAb2GLzdESk70+Ugx/cZhDFEZCCcnXMUaCRoEeoSBsjTXF+xPIqZ8WVwNtv7yRB28klKhdlm6HWfLzcDWDG/1/wdRTjtmERoMuQafa497X5NaFElaQx9G3Sm/3vKxsE57Jswj2CfmI8YUSK7lt6Kh9GRTN8vqUTjWZVgNh1yOy9Ebwr7mugWm7YwLTmwVwGvUKcc7ten//IBlQkOiHS+Y88Pz03dp3X3/7iAyhveaQQw+yZFZi1Sn+HMGf0dD46F5CvmjA2yz7hynFkBbgFfQCxuO1E/NijIhHkhWAZIsWrhJA8BWcfn9L8rhC+GmsHMJwCsEVHZSi/1qisvCKM2Kq70QuWuNhMAzUgLJn+XSIqlpgSu8mfkGY+DhzAclUIbXt986uxq80DImWBuTJcKJgmMOjqCCNuto3aG4KD/COgoCR4mRju1tWLW0h9edY3SC3ffh9rqHU8reBbXMXbN1sEnrAC3APRLMvMDaE7qudh3s5/abjrQAwA397ObmvKlirg8WmfnQ09LyUs/VCcPzeIe1p3iVJ/i+ANfP1Tbpzk0PU1xphHHcNBC05QLyzy9v+wa+Bgyx2LgYKCX0X2e2QXvrofF88zG6+cfD8T3Of46mG4uEk6Cox22tvRrzmXbvEhYOwGZ9VKFbS2DNzm38rP7Edhhe1s= X-Exchange-RoutingPolicyChecked: dka9aIyF0FGE+pHcAyp108U/c26TU9rYvHkRfMaAkK3dLt9khGkQaryQri0VHWwtQ5pxC65q5fDfrGUz1xOPKOzGQFID0lw7/6NSUIomm+BnjQpcoHDAIyPDaTNpAaZfGhjaHSKde1i9Cw2tuQSvntgpaBvHYtU2gN8Cgtw0EQVBK+H+Dib8/fi5lSug5P2TJK2vMeHPV9YDMzKecj06PsPj8ruKMayETSQ1K6YWQZNdDsEV+PBn1up4UN9CZmVflCB7VkQh30bpIdu8FrvGr8xen1fdokvNIh7uM5yJyBlXMDHb44HlK6BqxYntHlWNbiZH5Fj/jvxfAqNRfOyqtA== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb852884-20ae-42ba-c947-08dea2580185 X-MS-Exchange-CrossTenant-AuthSource: DS4PPFD667CEBB6.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2026 23:20:00.4704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N4u76ip6gkQpSeXp7zhILadbdYyOl6wrwgXoYlT25sYf2dXhUWyCIPEZ0J4z52A1UmCyqSldxptU6GKINHNZormN0WMTtkbvRSgnbDfJCg0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8061 X-Proofpoint-GUID: vB92T57ye1VgvPJPedgXsL8ZnunUe7GU X-Proofpoint-ORIG-GUID: vB92T57ye1VgvPJPedgXsL8ZnunUe7GU X-Authority-Analysis: v=2.4 cv=EY74hvmC c=1 sm=1 tr=0 ts=69ebfaa3 cx=c_pps a=W8nThqPTbj8xD7CpgneC0w==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=klDOsUkWDRETUCZYPvoE:22 a=VwQbUJbxAAAA:8 a=t7CeM3EgAAAA:8 a=UgOjM9SW4ZuDxLeMq3wA:9 a=FdTzh2GWekK77mhwV6Dw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI0MDIyNyBTYWx0ZWRfX4X2cE6z5A3Mi KotxS5jbDBFBsHvzY6a1tzAzfUM861fDDnxwvZ7eTVApdiz9HDRgIovt3V+UvrkcQVTaGFiAtKy m+4oy2TnhltTOKz2Yv6HPDkSjh3P67iy7gQljA8fCnpELEeoFM03qMpCHgBZ4CbIOnPksO4a9H1 tkLlfrtOb9zFn7E1FFlD/tZfo8bVR1Tp7W4qiYrag9sW4p268biM2yKovbgzIKFtivVV5EmH6Xk bVf5LE2l6Bz3FQ77Fa/3P14wlpJRxmZ4qeKquN+tbvzMg2PjLg+4f3XNoMllc2QwcxNONylX7c/ XQUHxahx2VwicNNnclHdmg+9nN8Papeq4un3hF6rnlKqZ7URx9xHZQrZXvM8gCT8ZwokX+rpPH7 /xYmuo3cAiqw6EpJcT1WL1vIqZY8EsW2LQJqKB08YdnJMaikGxhD44AOvfj5xIe89DBNVXxvN0T hZ+yaemt0rihLHUOIhw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-24_04,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 adultscore=0 clxscore=1015 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604240227 X-LSpam-Score: -6.3 (------) X-LSpam-Report: No, score=-6.3 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DMARC_PASS=-0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_VALIDITY_CERTIFIED=-3,RCVD_IN_VALIDITY_RPBL=1.31,RCVD_IN_VALIDITY_SAFE=-2,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no KASAN reports a slab-use-after-free in __media_entity_remove_link() during rmmod of imx8_isi: BUG: KASAN: slab-use-after-free in __media_entity_remove_link+0x608/0x650 Read of size 2 at addr ffff0000d47cb02a by task rmmod/724 Call trace: __media_entity_remove_link+0x608/0x650 __media_entity_remove_links+0x78/0x144 __media_device_unregister_entity+0x150/0x280 media_device_unregister_entity+0x48/0x68 v4l2_device_unregister_subdev+0x158/0x300 v4l2_async_unbind_subdev_one+0x22c/0x358 v4l2_async_nf_unbind_all_subdevs+0xfc/0x1c0 v4l2_async_nf_unregister+0x5c/0x14c mxc_isi_remove+0x124/0x2a0 [imx8_isi] Allocated by task 249: __kmalloc_noprof+0x27c/0x690 mxc_isi_crossbar_init+0x22c/0x560 [imx8_isi] Freed by task 724: kfree+0x1e4/0x5b0 mxc_isi_crossbar_cleanup+0x34/0x80 [imx8_isi] mxc_isi_remove+0x11c/0x2a0 [imx8_isi] The problem is that mxc_isi_remove() calls mxc_isi_crossbar_cleanup() before mxc_isi_v4l2_cleanup(). The crossbar cleanup frees the media entity pads, but the subsequent v4l2 cleanup still tries to remove media links that reference those pads. Fix this by calling mxc_isi_v4l2_cleanup() before mxc_isi_crossbar_cleanup() to ensure all media entities are properly unregistered while the pads are still valid. Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver") Cc: stable@vger.kernel.org Signed-off-by: Xiaolei Wang Reviewed-by: Frank Li --- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c index 4bf8570e1b9e..2d639b789910 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -556,8 +556,8 @@ static void mxc_isi_remove(struct platform_device *pdev) mxc_isi_pipe_cleanup(pipe); } - mxc_isi_crossbar_cleanup(&isi->crossbar); mxc_isi_v4l2_cleanup(isi); + mxc_isi_crossbar_cleanup(&isi->crossbar); } static const struct of_device_id mxc_isi_of_match[] = { From patchwork Fri Apr 24 23:19:25 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaolei Wang X-Patchwork-Id: 141844 Received: from sea.lore.kernel.org ([172.234.253.10]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wGPpg-00011B-01 for patchwork@linuxtv.org; Fri, 24 Apr 2026 23:21:12 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 468233015C90 for ; Fri, 24 Apr 2026 23:21:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 17349379EE4; Fri, 24 Apr 2026 23:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="GU6otv0T" X-Original-To: linux-media@vger.kernel.org Received: from mx0b-0064b401.pphosted.com (mx0b-0064b401.pphosted.com [205.220.178.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5617E363C4A; Fri, 24 Apr 2026 23:20:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.178.238 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777072860; cv=fail; b=Bwps8PVHwR/jykppUApFn+EQFTgwzrVOvF9fdfS2zW+n2q0sPl3tfYpeZ5TRHfEOO9HOC/AmGpitbf0yDpFMJaDcmGXVkzfOFcno63NVOIEEoNfUrEE6UClkKUa67U6ojRrvuwsXNW9BNpTxJz9q+2+ExZtjXTLA8ao+YJ6aX+4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777072860; c=relaxed/simple; bh=teEe8pO+Jesi5W2aOoZ/7/pWz1XVhE1wkeUHNple6WE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=emB0Z37Vg5VgR6ftB0/sjrm6MULf1WGbWwFhTYfu3OScQhpK/lu+60wnjAHtjkdEp1Jq/AxllAwPJHe2Mt31rda7ebZurU4I8vDpX2kKeJAN6KBLP5bKAuR65NKhnEUJWA/Jw5CuDljtrLcQiZjBks83P8U6ChDOEHrEbWKaGjg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=GU6otv0T; arc=fail smtp.client-ip=205.220.178.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Received: from pps.filterd (m0250812.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63OCSR6f2707038; Fri, 24 Apr 2026 23:20:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=tSVZCreDHdfHSj5YXvYg/9zgTn5tioIwxJqmjz5Ir8o=; b= GU6otv0TMPcNmNhr3R0k+Wsfjx5z5lRTcDLj8YEIv5UARcXWbHQAdiQfH7zMXLLG 6ekt/NCWuZH/pI5VZu4F3uRfjAqDKkWp5dJPCgzGAC9eFF0Snd2x1q4yvmPEiF0a JN2c92mZFpiSJvmxlHbc9BYXCqtLfHoX5GgoljpHXSLfQ/7n/gckxw4Q8EhjLP/O Rfaf4IINusLWe1+2Ov5Rta5EXbgAnb4Ma5M8WmsTUXhZ2d6hhb/F0hBGfsgDCb/Q uUPn1y/43R1fg7iCnP/08UDXsTEmVU+0OONXp61qvT3W4PnUBzmTQA8duvJcMSR2 tuxVjzyhoA+/eqz7NoxG1Q== Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11012013.outbound.protection.outlook.com [52.101.48.13]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4dq8u8an4y-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 24 Apr 2026 23:20:13 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GjzxA5Cq/FAYceXkDKui4xOvldzlAHcfYwyWstFfWDxz3s5+Wd2ZKIIV4SGBMTZY3GqnhRcKTk3GwE+XYkhb20ZoOkFooj7+W05H3ZBHxdtkjNY24yq6JdJNk5mxuCwLH3b2BpGZSw64lNXWh4SjD7tH8OEFn8donLXEBNt8vzTJCtJDqSqAGCcOQaCvNiFYO/RArdR7tdlpsAZyMLw4BqrsPeGny6WZquJ3p9F29F3QDxqdD5INZOHYm2c+1b/ediZDAzOyLPn9cMJXLwZ6NEtRu5Zz/a72RYOzlL44fJUgOC3mQsE8V5DQjwxhKFNmOhKftZGVYrtyDLSDcw72cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tSVZCreDHdfHSj5YXvYg/9zgTn5tioIwxJqmjz5Ir8o=; b=mK1YyWxlaeWS5pel3phZJ/jpcBtc4qIy985brEhX4PePkRHeMeD7yc5LB1n6fbAoPON6uBClSY23YCoAsLC6N8Q0oB19UNpnZTmQsTLQNtZAZjwfzIxoBADmtMgQzZ6btwFppD3jLLS2QlJHW3FR3NGrXr+Ln60lOw+CdCla3thtdaL1zKazxRROxZqon1trBtpLpy4lqWiFhJJaR43HDe+WrIvjyQbBmrpxdsKl/NuKOFp1w11jnCxD/eW6JJ5jbKegY5nhH65678HHMUgQVYIrVXQI03XqiXRyrTe5nfePGFVnzI5X9q+a0Cno/Ee2qN/GUDnG7ACbYXglnnTUig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DS4PPFD667CEBB6.namprd11.prod.outlook.com (2603:10b6:f:fc02::53) by PH8PR11MB8061.namprd11.prod.outlook.com (2603:10b6:510:250::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.22; Fri, 24 Apr 2026 23:20:08 +0000 Received: from DS4PPFD667CEBB6.namprd11.prod.outlook.com ([fe80::b919:1e6b:48a6:f655]) by DS4PPFD667CEBB6.namprd11.prod.outlook.com ([fe80::b919:1e6b:48a6:f655%6]) with mapi id 15.20.9846.021; Fri, 24 Apr 2026 23:20:06 +0000 From: Xiaolei Wang To: laurent.pinchart@ideasonboard.com, mchehab@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, aisheng.dong@nxp.com, jacopo@jmondi.org, guoniu.zhou@nxp.com, s.riedmueller@phytec.de, Xiaolei.Wang@windriver.com Cc: linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 2/3] media: imx8-isi: add missing v4l2_subdev_cleanup() in crossbar and pipe Date: Sat, 25 Apr 2026 07:19:25 +0800 Message-ID: <20260424231926.406079-3-xiaolei.wang@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260424231926.406079-1-xiaolei.wang@windriver.com> References: <20260424231926.406079-1-xiaolei.wang@windriver.com> X-ClientProxiedBy: SI2PR02CA0032.apcprd02.prod.outlook.com (2603:1096:4:195::12) To DS4PPFD667CEBB6.namprd11.prod.outlook.com (2603:10b6:f:fc02::53) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS4PPFD667CEBB6:EE_|PH8PR11MB8061:EE_ X-MS-Office365-Filtering-Correlation-Id: d8dd905f-e6de-4078-e892-08dea25804fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|7416014|376014|1800799024|56012099003|38350700014|22082099003|921020|18002099003; X-Microsoft-Antispam-Message-Info: VGHpf+NHGm4xiJa7CnakZXu7lS1jPL5QxOHeIK5fxeGoR2SS+hOQkg1CNyRQrXVrvMDUlr8a+2c30+4URAx1Wob6geLLS/DkfAm94NS1gMfueQx8h40Ch4/KKZHIWc65ZyUPtuZGkmz2PKbsLqEbE2uaiQLtZ6qkM+DN8BibK0Zd5NqhS1x5qHbaTMounDvenrZ1uz8g+7DIqGHWPOmPuHgoDGIJX0B8gwizTe/3gfy8zrfxSoDwJ+OIWBE3OmdT2hq/0/MdPBeJ//HI9IEqvXrwNs2MJl8ZDcV7PtLZLwZaQUGfLXhD56vHH4Ewg16aa+bixZNGW5RG/wKf/++tymqQyH4T80u++Ki8UhAQ6mucnpVwSztgv7Tm6eYbpV87llixWhi6zp52QM0glNzUKz1odhwQh95AHBvVCdhC7rIx83T6ZjfmarpIX2bskuZEZMpjmcxVtdRJje0FS3T1f5BqsISOlieomqpQHTbYSahDr0xwhXVyXWYYbEv+R2TJpSj0APTH9dHZLL8pB8PiGeqwF9NS5Wlr7futiBm12lmThxWbkT9AV4mrKR66DaP+gTTBE9Xgx39Ma7tqPPfMTmf4xyl1IG12H7H34/9itgVY7ZpJp6I+Jz179eR+drczDk+Qge9YeFUlfaNbhB+NXF1gPnb8YHOnfr8c6CIrFu6ytrU4MuCiPJ6z7kKCtQv3D+0jVaTckoEWTU+t+QJ/IEN6pdqhHVLh+EQojkHZB1Rz3FyLljHBqcUQ9uvzQxX8aHJGeznbGOE6I68AMvsEOKSXBH9Zb4fhNu7lm6upShgsVoOW3ocJPCqYB6SUk5g8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS4PPFD667CEBB6.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(7416014)(376014)(1800799024)(56012099003)(38350700014)(22082099003)(921020)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 7bH7auqLlAhigBLsetu35AM8XVKEs/PzwGrEj/jeXEqGYHEaoDNSNaTVPNG2gFDvgMmtQCHNJE4ZQkUjQPFVLgbgMmjpsJsjNpqCNwLyT+n8N5Uc92DCiK/3ZnPpovn/EfXGsOXKgOIx6qDMnktAQqGNXahulzqziaBnh0OzfTZ/HMCe3nqwVGIxWlItjTCynrK1kQq5rMvD10IPwTw02Yd38sKndFk9W9pJqiZIIViW+24U6k+G0AvzM55dj71LazvETpLsQOJv7T1oNomCqXmRKNYbswQTjZylO+8DWTFtl2zNU7yhJXhe9ekIsOHJWAsVCH8/hOl2dp4kbrtBhdABJnufhUGKoa1nsaQMXjlX2grRyE5UrFocWEoRpnkhn1PpwPywX0Du8SGX6OszN+SggIVUklkdm9b6s3ZvyiLLcjsC/zoft2xV1v9ohHZq0ogVpm+C6nPd7MEYwgsSoY/AuVEmFz+q9pxw0ePgu3610KQGPOozptDqQOKaL0vjAnnpwqg/sKULJdLKDvEWQYGtywoN709USRrcHpPne8IiatzA+MramBaJZUPzFbDlpstS6RwOJOymOZsYf/HPvv0JjdKOP+plN6zl5UvAciaUEbLOZ/T6lFNiNORmAtay2q+yrlDbvufVVVBtSrZVfbVZnsYby6JMRfaBb1G7OTgVqpThgEJtkiG5/fC5N1+sV4NBXyKQfMQIpkp4+b1qbkwkeDE5/mbYYueH7xvYTT6mC0K2w0Sveyilb4pFiJw7ZIdya47HsbKvfKkxoAcQThDrmwjE6p5YLPkSP7ZqEBFilJUNryDsx+I08J27NOTK2mAd+cr2B6LJNqyLT9SV/j8+A5kOika89Q8q7cRRubEWjQY3gCejt/sXU9YXFzSmYU0sP0FtpEEcpBH5mTX9D+s2ka/f6gNedyqJBwQDi/htSTsTVC2l0+cf4iLvooCUkxjHJjbc91GiD3SX/MoE1OTW+yYNY0dNFHU1IOHfpEz73EvflXqbHnlMKsS+beJ8sk2Ym5le1ZcA04dJj175e8jK0AbIx1sH7Wnxi2QumeRU+33fJB/X/LTlvtuMSVuFnADm4wm4Jui+SCz9PZu7qAg1XbY3o15pGrmKrA7FDEfELGYSC/kYKNts+uqWE6LUq678M/FwVo++Zlwf/2wZMgXmHC9bFHkXFNsf3dhTCChZ8gxwSptlJe2dyvI1409TXWLWSi78RbncxMES7P5nRCB8mZTjlWxrr9Bpp+DdEaHj0U6gJ04E/t1crrfkgRNMhSV8Hj935XUbQPp6YEha/Jx2YYPanHV+cBYXSJLCG7T8IxbN95nn/cIEmGTymq6sDh4sXhS2Ut0m6UJjC/3uUe++WZ1r0dkyRMT8B3Tm7N5dGis3cUt/KovNwHdWgBYZx2HOoqU30YcD7EZv/3mF4IDGWdQnP6ME5g7Kn8YuOfmtjWJ+ol+pnKrhU/hboiuYnIQz8Bqrlc0a20Hjct+UFgGAHEhIFuQIzXSub2kva0SpAMzUl1Oq72QK4zMEL5YiITiPMCVteLA+b+tfX4EKHeY6zo2uVfEBjnku6Ct8wyFEwFSkDmqv8lojJ05wEoUxGDmYNfvEFGze8Pw0XtkwPWOMKPr/JSeA0zr0w0oD+aH/pvPIAechnh31JjBJ6uNBBrao5ZEnQvxiAEB344J8TtiSfh2PyrvgPDY9aZFtFLZ0XhcsEiYLabtbvks3fX79C1UjeSjtcIzoha1l5WdM3a5uCOX/xOoxUa4NeJ3vx9k= X-Exchange-RoutingPolicyChecked: bIqqA8G/iV0jwA5vaTovmsKtLUwgpjh1wEC208P+CLNJhjkIlWbt7MXlA3oUglf91QTJB/yhL2ec/560qL0FPnn4nDS0wPw2ifTbsRKT7i0DPC7+siy7uUvc6Tlqrhr5zF1OXRJevNC30K0bCq2evR5PEiYqK/K5OepbceuA4RQ9jGgPsHkxjCo2N03F8TD2cGVnO9G52VPImWdt7fvL8gaKNQKijkzHAFHJ8ZyNiT2UKN/Lggr2OwSdQkL8IejK4ZLTCArdAkVS0995aCn2QknSrT+iSCFkbrbOYg6vGq15PYfLoK/rY/CfI6q7Df7ynQmE9fwfJbd2ePHr7fqcvA== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8dd905f-e6de-4078-e892-08dea25804fe X-MS-Exchange-CrossTenant-AuthSource: DS4PPFD667CEBB6.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2026 23:20:05.9967 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0a/GyLLpBkeBkwa65LvqLc5DTe4T0ioiLS4C++g832yeVdGGrLxHYzQd8S1PZhYwC7NR/onkjMsy8qjHlvGvZXz7rdXTndLTdrW60IIZCdE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8061 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI0MDIyNyBTYWx0ZWRfX03zLmQ4/J0O5 DipEHVTqcVUoHiL1A9FAXzXNqSprQq/0/BEcnicoQTsonRdOQYuO4e0xuc5ih3EiwW9tA5RvY/p MouRmIdfok+au+tdp/xFv0+Ohe1NeNFAV6FA/1o2av0yPZHsJDceBiB0FNwM0CVQdulAXWXKdE0 xJbxqq49B0sOpoQyXN3EMydLegc7BgoKiuTX/FS+UKiL93RjrhFLuqsYQzLpAkPsKfF5wRGrcVp PXAk6RCWcywB+1s6rH4eij4TsOS91c7ntGsi80B7nTroHqV0cOSfgm3iVrmZXfcajGEHRL8Fa7F W64bS0O+oHWkAve0w3lU74hWn2hAtYHD8TpyJcCDPKBCcTjQzoeVB+fd0r2Myw95J6xAuc7jrqJ 65dMlPOouDDIdIzsznTHWazZMt4i14yDsDLVeQX6KB7kAeS4g0EvGYxOId0GSdh5hew8HrZMtJD 6UhWm15loxu0/8R9IDQ== X-Proofpoint-GUID: Ha8Ni8d_VI9B7kwSzQzO3Dz2GEo1TBXw X-Authority-Analysis: v=2.4 cv=WLNPmHsR c=1 sm=1 tr=0 ts=69ebfaad cx=c_pps a=xOYz1KraVtwoi73AohHYLg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=fTW__CHxibyLmBMfj2wP:22 a=VwQbUJbxAAAA:8 a=t7CeM3EgAAAA:8 a=lgr16xn9cv1HVsKBfnsA:9 a=FdTzh2GWekK77mhwV6Dw:22 X-Proofpoint-ORIG-GUID: Ha8Ni8d_VI9B7kwSzQzO3Dz2GEo1TBXw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-24_04,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 adultscore=0 clxscore=1011 bulkscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604240227 X-LSpam-Score: -6.3 (------) X-LSpam-Report: No, score=-6.3 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DMARC_PASS=-0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_VALIDITY_CERTIFIED=-3,RCVD_IN_VALIDITY_RPBL=1.31,RCVD_IN_VALIDITY_SAFE=-2,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no Both mxc_isi_crossbar_init() and mxc_isi_pipe_init() call v4l2_subdev_init_finalize() which allocates the subdev active state, but neither mxc_isi_crossbar_cleanup() nor mxc_isi_pipe_cleanup() calls v4l2_subdev_cleanup() to free it. This causes a memory leak on every rmmod, reported by kmemleak: unreferenced object 0xffff0000d06fc800 (size 192): comm "(udev-worker)", pid 254, jiffies 4294913455 backtrace (crc 36eeae58): kmemleak_alloc+0x34/0x40 __kvmalloc_node_noprof+0x5f8/0x7d8 __v4l2_subdev_state_alloc+0x1fc/0x30c __v4l2_subdev_init_finalize+0x178/0x368 Add the missing v4l2_subdev_cleanup() calls before media_entity_cleanup() in both crossbar and pipe cleanup paths. Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver") Cc: stable@vger.kernel.org Signed-off-by: Xiaolei Wang Reviewed-by: Frank Li --- drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 1 + drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c index 605a45124103..c580c831972e 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c @@ -491,6 +491,7 @@ int mxc_isi_crossbar_init(struct mxc_isi_dev *isi) void mxc_isi_crossbar_cleanup(struct mxc_isi_crossbar *xbar) { + v4l2_subdev_cleanup(&xbar->sd); media_entity_cleanup(&xbar->sd.entity); kfree(xbar->pads); kfree(xbar->inputs); diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c index a41c51dd9ce0..cb50af2270f6 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c @@ -819,6 +819,7 @@ void mxc_isi_pipe_cleanup(struct mxc_isi_pipe *pipe) { struct v4l2_subdev *sd = &pipe->sd; + v4l2_subdev_cleanup(sd); media_entity_cleanup(&sd->entity); mutex_destroy(&pipe->lock); } From patchwork Fri Apr 24 23:19:26 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Xiaolei Wang X-Patchwork-Id: 141847 Received: from sea.lore.kernel.org ([172.234.253.10]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wGPqk-000136-2W for patchwork@linuxtv.org; Fri, 24 Apr 2026 23:22:19 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 728F6302C92B for ; Fri, 24 Apr 2026 23:21:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 613A937FF7A; Fri, 24 Apr 2026 23:21:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="TuQr3ghv" X-Original-To: linux-media@vger.kernel.org Received: from mx0b-0064b401.pphosted.com (mx0b-0064b401.pphosted.com [205.220.178.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 723F6363090; Fri, 24 Apr 2026 23:21:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.178.238 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777072864; cv=fail; b=SM13bxIqzJskOV+l99g9I1uK3O8ZeR75ars1Sn/+yzj83d1MEqQWoXsNUSkjmPdAFGmrJM77Fdi/OBSRluTZLkdrw2N81rLAPHkvMR7YhBjHDIouhM8qiziIdG/qo11Gln2M0znigwVqzk8otSmf0vUXJ2E9juuXfW0eRjY0LJs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777072864; c=relaxed/simple; bh=2F9m0asjJEZab5XSIZ67/HJqzTsbItzVZJMsL5VXx4I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=MgfuMq6nQHDPca9hCMDFYltztSVj3gSWPzl9pDtMGfVLJEudjO/SMvmktJM8PXTeqBStebc6A0ej0cig3ImWHvnQHKEc1phpw/SJvbtbBER2Yghl+kzyYZERrgpQ25JcXaQu5zUAvrKBTWwF64L8LY8kfmS0nr2XpqBRr4KrnHc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=TuQr3ghv; arc=fail smtp.client-ip=205.220.178.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Received: from pps.filterd (m0250812.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63OCSR6g2707038; Fri, 24 Apr 2026 23:20:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=PMfBcC5siAGBBl001RcLFEL1F7xVG14QfIs7lsrUmJI=; b= TuQr3ghvQDocfeFfCjALHIpbs1t28XSKdjRJAQE3Atxxn+rzsC/6HcItc/NWvmmE BJmQq69IzwZjEGPfuSy86zn6nL+NEjw/C5gdHonBHaEcdOeMZ8qBR0Nt9J03Gjbs cRKoXrY2lnwM/OcZcAJQ8ZwLdni7KNX0VwUO2UrWCGSIiB0KgXwG6Ewlvdhv2QM2 9thuEmgsn18JkgC2MWa5uHABPdMycJKrdjPK+STgm+4BI/lcdwunMp48wXz4eTRM TrYn1lb7dT6zENrkxkalvO+2SC4sf9xfsesjvZe5g1McP+dDM1m8P8LSEvnaU6qj LLk377ZfBgtOHU5WO7hLOg== Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11012013.outbound.protection.outlook.com [52.101.48.13]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4dq8u8an4y-2 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 24 Apr 2026 23:20:14 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YXdtcCE1oaqmfjPFPl6cL2K36QIBG3I/5uk729w0iw94RoYuO0vAOjVz6B3O2y22ShFGrsR5yjv4DoIeWSJeS6JVwFqetS5MJF9Ah2OPyKYme+hzirgbi66AJ4I0Ep4Q8Nc1nRKoboCQGOie5C5TqOvGa0n21pRhvi6vmZVT+3rdT5xg8c9OnEcWE3/CkkQENjbFTKG1zFAD6OHR0P2ZKlDCQkR5XYo6nZXiemjh8jj3ZHybCS4R1h5K8PE/JISzlL0o2QI6FLMDmyFICVZosgZKUwDvDwUePbLDv9SXFMg5jXkyX3tamv6l9miz95l23DoW1KIoHz7EsR2KqyRKVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PMfBcC5siAGBBl001RcLFEL1F7xVG14QfIs7lsrUmJI=; b=Ui44M2ljC3DnByosqAabEdmr9fvggPTSQypL1o+L+VlpDfv0bK4G27hDZ1Q3qfx3mn53BBcJsqVfUEugf3VRu0QrhY0YV1FC2lfaIjmPvg3AnMD35suE4eRnVTmf5V8hWRnYgjROR5izHYeQ5oKKqerpXdbBy5yhyS5i4QXiTzTnUQ3AQ5IvY7F1YfvlbwIW5xL4gVo1CZ8i7dVYdmuxUMkQxnggCub0DNId/x68OjCmDI+1P+pkiLBFU8yE2pHjcsITmRq/SdQtaVpOPvtpfwTd/ZfUIAtoguxMhXDVhMEUqLJ/eb6GegMEe6FQqAGfI2w6k+9bxoZbm6vBEVX5Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DS4PPFD667CEBB6.namprd11.prod.outlook.com (2603:10b6:f:fc02::53) by PH8PR11MB8061.namprd11.prod.outlook.com (2603:10b6:510:250::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.22; Fri, 24 Apr 2026 23:20:12 +0000 Received: from DS4PPFD667CEBB6.namprd11.prod.outlook.com ([fe80::b919:1e6b:48a6:f655]) by DS4PPFD667CEBB6.namprd11.prod.outlook.com ([fe80::b919:1e6b:48a6:f655%6]) with mapi id 15.20.9846.021; Fri, 24 Apr 2026 23:20:12 +0000 From: Xiaolei Wang To: laurent.pinchart@ideasonboard.com, mchehab@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, aisheng.dong@nxp.com, jacopo@jmondi.org, guoniu.zhou@nxp.com, s.riedmueller@phytec.de, Xiaolei.Wang@windriver.com Cc: linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 3/3] media: imx8-isi: fix resource leaks in probe error paths and remove Date: Sat, 25 Apr 2026 07:19:26 +0800 Message-ID: <20260424231926.406079-4-xiaolei.wang@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260424231926.406079-1-xiaolei.wang@windriver.com> References: <20260424231926.406079-1-xiaolei.wang@windriver.com> X-ClientProxiedBy: SI2PR02CA0032.apcprd02.prod.outlook.com (2603:1096:4:195::12) To DS4PPFD667CEBB6.namprd11.prod.outlook.com (2603:10b6:f:fc02::53) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS4PPFD667CEBB6:EE_|PH8PR11MB8061:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c69fa34-a7ff-4675-346e-08dea258083d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|7416014|376014|1800799024|56012099003|38350700014|22082099003|921020|18002099003; X-Microsoft-Antispam-Message-Info: wap7ItTwBjiUyJT9CioQZiTBth+bwVaO+B7WpHLOU21qKov6T3blpAbZBUQFvFOX+6yJGI4Wrln3tw4Y1FTJ1OXj1PyffCuugqlPc9HloYpGGgjjRaTMTelqUi4xa6N4MQ6UZ+yZyMGPymwna2TSsKUjdwO4Rr61Wwz4wA7Qs+pz9ffi+THiIeGHk9Zu2YivHrMBjjhv3iz60waNT0ZPQCUQBK2Abb+GIYiGdukYgbhomgxRvNUAjkA2BGkjiY0DO3Gjmc+VJr7VrBnjzTvPM9CZuxF1M01wPWzT33/fOa8H3v5wywIvlyhg6mxtvlUti9Glu/8Bwo/f81D94ymqkRgPrCDhNtx5KorGxyCyVebz3VlBTUCoPL6apwth7u9Cb/9B0p3ex7z1mUidcri7tiE1kaSk3NpHukLYq4EZMo7dICyXxbtYVnTt1s6nvXmBgEMhNB/AGJUtOuiSDVLR6smZQeJzjj0SLe2H+z6aAJpjU6vRKAucBLl53L3wCosy2DLI4+r06PzpCEIrzk2CnBs93SFRgbGwfUQwG6UvnhrJvS9RjwepaY0AuF+J3+4HD5jJioOI5NszvyZLUfgoHcKvma23JLVG+0TGwZSR6lIqxTRRxBhkEcd/RKGunpskdMF4sNV/Z5bo/8igHRdm+ICLYUOzWAReO+M9kaDO3thOYuLxK0ACxPpVhQUFjiwNEcJENk/Xunab8y5a9RdJp4MorqVAc81OR+/RlcIbsNr5LutRyNJbwmUdn2Q+9Bxly3+xL+VQ0n4H/cQbFm5zScpcSm48zCRQ2UeQWbtm/3F4vosmaT9BhJYnlcjHJD/1 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS4PPFD667CEBB6.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(7416014)(376014)(1800799024)(56012099003)(38350700014)(22082099003)(921020)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?geHZm0gUFSHY1ZIooZ6AMOR+0VsS?= =?utf-8?q?ecl2cukHnPILN43p6aaoVVQQj4Kg9K4bo4o085BxriaQm5hX/m/RBnMqefS+Jeoug?= =?utf-8?q?nyTv8ZztBn3yzud+Wc75p38T5ebIXVTTHT2G4OnAdwPcv1+Z+v7LdMYPxPrLuvtzs?= =?utf-8?q?OQcG6UOVvy235OMEFv/9zl9ZUbhjjj03wOTfYdJ656QDt3q9dHpH6Shnc1tNa6mQH?= =?utf-8?q?9RyP0sQduNCg88+NaCFC5pmGtdXidzbMp1GroKi71GQy6ekFy6odnLwZ8IEcFifHS?= =?utf-8?q?g3m5xioNXubANLPjodvAw1HR7vB1isTkwhElItvDswJYCkJ3f3pEY2xtLjDcRMXKR?= =?utf-8?q?uPlmQ8Ygr3nJ5DSAv6RKDDWKS80hjwN5CGGeRS/SABKvK2pZKPM1s3Zhqtj89XN0N?= =?utf-8?q?q4klZirfAbzTM7YohyeO1lc/K722dklGM8zJxx3W0pGR2LQy6h+3pYGGPtkcpPM8c?= =?utf-8?q?k/L77dOBFH6UOiG9i6SCYJNgWHqOJXGusTHdY0EABgLTknoRzy32WsMl8XbZveNCk?= =?utf-8?q?kEQE/EWU9JDesed7hNX4cVjWZZy2LyHb2KPqepeDAiCX07mVybbofj+qCXBYEyGoo?= =?utf-8?q?6gmdGWwlIDVEpPyXpKDdFCbq0vhd4YNa1viDgU32OQLwZAfUj4Nc236ohMBjvvpGu?= =?utf-8?q?dOcon4wmibssXhts/4XSeNai2U2vud+qhjxXFQ0S0xe9EJX1fKHCNp3ZBeO7STEql?= =?utf-8?q?6k0D7U7iwROyzzZhgwPPKHDrSu+PS5lB7i7oqODyxwxEngllm4OtHvd6zdDuWtKFq?= =?utf-8?q?yqPEVIom0EKdqblnueBRnxrirqWHXKtrC13o9P+SplCa+kXfj3dkQJBRkQq10Mf6i?= =?utf-8?q?zH1czi/q3WZovpT+FdasU4ghEWrniyj4BXlTHsp51nmCpT538dpBvDK7qEDpMzgS2?= =?utf-8?q?/ID/I1MGBgqD2sZ+FufzJWFIEOZmDgOouUZsK7qqMS7ZDl98rzZ5b8hCR3THnG9AL?= =?utf-8?q?GXsMmc/gszDX9Ow8BTlK/siNS1BT25OU3pnFa0EBxL0hpak3XqKfn65jJ2/loTGIO?= =?utf-8?q?JKogvy+G3ONOD8sIs3/L4DMbIJm3dWgraHJpfYuP6irGvU5xgBrJv/Iwu1BK+/Lq4?= =?utf-8?q?IPQtTw9Yo2cW+WO/FLqseT2hivDHfZWqsGlxPt/690fbPdabAPeAfmLC8vxJlJOXw?= =?utf-8?q?Uoxe5dCYcKDgcEKTJTOfH8LCfCBep74ZxFqRtIRMbnEvQMhB1cFXhl2jlNmbSTJmm?= =?utf-8?q?nt1QvWmlIBnCg4slrHeBSw6cDBppJtvdoQj2DoilJMSnNwB0IAm4FSRcri07XbAt2?= =?utf-8?q?/Wh3m35rZ29Fj5UhchEg8l+KwUdr6BL9r8YW+1nbGrlsNZ0eL5I+NTM9mfJTpNMrt?= =?utf-8?q?N3hrv8Ix1jbzX/YRmBbpf25tIL0iwCcj6tMxdb3Rv3aMhpxEHBEAe4Uld578HWUSh?= =?utf-8?q?6wsj8jAyaV0+3WWVw0Fjmxm2btrohRlfIBm2QQ2zN6VHoLIoTS1dg8vjIPgA+nXlR?= =?utf-8?q?RE/N9TwfkBE88LzyWwDllcFHRF4xJQmgSSKvd9OjmkJ9LQYx6H4ZKLqp/c/sSZLoG?= =?utf-8?q?dfkxaaV+/+/kxM+NbA6TyN1rgYHNuhb8TNJ4GIRfSVrrjiJ0SY/seLZDhzWb+5N4B?= =?utf-8?q?7XBbtUvm5n0I1/meDWj3yoh8H2v7Ih7FVkIqJMCgZcdrsHZGe0/k2x2wlkxpYYj+o?= =?utf-8?q?PIqgh3jJ1qNpUAuwKosWDz/8598cYkBhrAQMMWDbGutOamM4fSfuc=3D?= X-Exchange-RoutingPolicyChecked: Dwf2vSIDJNMKlBqi9etbbilGTji+FbOMQV/vdPwv1AM8oaKgMHcK5FaY7p9iGT5mR97V7e1ayGcDLjaMVpLSt1bcQOd3CRgT2XgCXquYpb1xnQSdaWs9NeaBSnwhGw3cLhD4eYEbqmWuOg+QTo6C9yiAh7ZuL/2x9Czmm5jmXiFDrXRRfm2rJj9CFxWa8BX6BFpII9fPbCcTHVOUHvgd6I4fwOU55kHHD5f2foXdyLxXGc3m8Gk7XyA7XdVRKGFDEI8Lvc2Qg1wgOg2FbzDNMETf8Ld/+/7cLAQxlXm5BmENNPlatc4BBCTIHhl5ZH8Lr8yo/wkWHQ0H+vseOvPHgA== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c69fa34-a7ff-4675-346e-08dea258083d X-MS-Exchange-CrossTenant-AuthSource: DS4PPFD667CEBB6.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2026 23:20:11.4623 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FF6HYElXGXIlOwO8A/QLpBDz22hz7KRQAlrEaKg4r+psyFLczOc0vjx/4py5cmbzXEA6ks/KmxQ2dn+oR4prIOY9W5W/ApFAl0nvNwFD0Og= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8061 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI0MDIyNyBTYWx0ZWRfXwHCG59WykgNC 2Qr1GjmSGzXzFuZFWvlPpGxL6APipxQyVe1Zj2SSERTz57NcsGWf7Q+4QnG+N9hxbwObCwuYxao q2J1KlT7k9LB+OHC3cUvsdHB049BWkG8koFOKCNsHiz6Pu3cPUVk6Uf6G5AHSzynfNQi8m+anfq 0qHHj5ds4NDhZnmoPlN5tbBbagDRdxXuGQDePyjredc6w2cwA5heJmFT96Z9rffByg7iqJsUV3V c97M6AbY9gLvoSeF+aDk3J7qspz/gZM8cKpeGAsryD0VMcbrc97DnubHj4dG/tqUO3e/7vhCHQz qUvllwERweQd6f0D1VLD04oxeZCpdIl2tecHQL/P3+ighJTobNQi2nHQk9tin18rYQc1iDiXLc6 1rOejkxdMcPiPY5IO7+JjT9l3uUgVZSDJeDg7Rh9s21orwYDXOYcBCoknib4i99GrOeoEjkLva3 5VVxotuyxX7zxDctRIw== X-Proofpoint-GUID: 5x_wrJD43ZqwpPz5sIcb-kHBE5edInwW X-Authority-Analysis: v=2.4 cv=WLNPmHsR c=1 sm=1 tr=0 ts=69ebfaae cx=c_pps a=xOYz1KraVtwoi73AohHYLg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=fTW__CHxibyLmBMfj2wP:22 a=VwQbUJbxAAAA:8 a=t7CeM3EgAAAA:8 a=78pQybC1poxpKYY0_T8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=FdTzh2GWekK77mhwV6Dw:22 X-Proofpoint-ORIG-GUID: 5x_wrJD43ZqwpPz5sIcb-kHBE5edInwW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-24_04,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 adultscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604240227 X-LSpam-Score: -6.3 (------) X-LSpam-Report: No, score=-6.3 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DMARC_PASS=-0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_VALIDITY_CERTIFIED=-3,RCVD_IN_VALIDITY_RPBL=1.31,RCVD_IN_VALIDITY_SAFE=-2,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no mxc_isi_probe() allocates isi->pipes with kzalloc_objs() but never frees it on any probe failure path or in mxc_isi_remove(), leaking the allocation on every failed probe and every normal unbind. Additionally, when mxc_isi_pipe_init() fails partway through the channel loop or when mxc_isi_v4l2_init() fails, the already initialized pipes are not cleaned up — their media entities and mutexes are leaked. Fix the pipes memory leak by switching from kzalloc_objs() to devm_kcalloc(), which ties the allocation lifetime to the device and eliminates the need for explicit kfree() in all error paths and in mxc_isi_remove(). Fix the pipe init leak by cleaning up already-initialized pipes in the err_xbar error path. Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver") Cc: stable@vger.kernel.org Signed-off-by: Xiaolei Wang --- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c index 2d639b789910..8533a979d60a 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -485,7 +485,8 @@ static int mxc_isi_probe(struct platform_device *pdev) isi->pdata = of_device_get_match_data(dev); - isi->pipes = kzalloc_objs(isi->pipes[0], isi->pdata->num_channels); + isi->pipes = devm_kcalloc(dev, isi->pdata->num_channels, + sizeof(*isi->pipes), GFP_KERNEL); if (!isi->pipes) return -ENOMEM; @@ -538,6 +539,8 @@ static int mxc_isi_probe(struct platform_device *pdev) return 0; err_xbar: + while (i--) + mxc_isi_pipe_cleanup(&isi->pipes[i]); mxc_isi_crossbar_cleanup(&isi->crossbar); return ret;