From patchwork Mon May 11 08:43:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongfeng Wang X-Patchwork-Id: 63729 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1jY457-003V2g-T3; Mon, 11 May 2020 08:46:38 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729180AbgEKIt6 (ORCPT + 1 other); Mon, 11 May 2020 04:49:58 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:36900 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728562AbgEKIt5 (ORCPT ); Mon, 11 May 2020 04:49:57 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id BB63AB93F3FEEFD6C057; Mon, 11 May 2020 16:49:53 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Mon, 11 May 2020 16:49:45 +0800 From: Xiongfeng Wang To: , CC: , , Subject: [PATCH] [media] tw686x: add a missing newline when printing parameter 'dma_mode' Date: Mon, 11 May 2020 16:43:46 +0800 Message-ID: <1589186626-17243-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no When I cat module parameter 'dma_mode' by sysfs, it displays as follows. It is better to add a newline for easy reading. [root@hulk-202 ~]# cat /sys/module/tw686x/parameters/dma_mode memcpy[root@hulk-202 ~]# Signed-off-by: Xiongfeng Wang --- drivers/media/pci/tw686x/tw686x-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/tw686x/tw686x-core.c b/drivers/media/pci/tw686x/tw686x-core.c index 74ae4f0..bfc61da 100644 --- a/drivers/media/pci/tw686x/tw686x-core.c +++ b/drivers/media/pci/tw686x/tw686x-core.c @@ -71,7 +71,7 @@ static const char *dma_mode_name(unsigned int mode) static int tw686x_dma_mode_get(char *buffer, const struct kernel_param *kp) { - return sprintf(buffer, "%s", dma_mode_name(dma_mode)); + return sprintf(buffer, "%s\n", dma_mode_name(dma_mode)); } static int tw686x_dma_mode_set(const char *val, const struct kernel_param *kp)