From patchwork Tue Jan 14 02:17:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "zhangxiaoxu (A)" X-Patchwork-Id: 61175 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1irBln-008H2x-NT; Tue, 14 Jan 2020 02:17:27 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729030AbgANCSV (ORCPT + 1 other); Mon, 13 Jan 2020 21:18:21 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:44842 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728931AbgANCSV (ORCPT ); Mon, 13 Jan 2020 21:18:21 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 2F1F990C45F4730C62EB; Tue, 14 Jan 2020 10:18:20 +0800 (CST) Received: from localhost.localdomain (10.175.124.28) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.439.0; Tue, 14 Jan 2020 10:18:10 +0800 From: Zhang Xiaoxu To: , , CC: , Subject: [PATCH v2] media: staging: rkisp1: The rkisp1 should be depended on CONFIG_OF Date: Tue, 14 Jan 2020 10:17:20 +0800 Message-ID: <20200114021720.30826-1-zhangxiaoxu5@huawei.com> X-Mailer: git-send-email 2.17.2 MIME-Version: 1.0 X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org If 'CONFIG_VIDEO_ROCKCHIP_ISP1' configured but no 'CONFIG_OF', the default configuration maybe: # CONFIG_OF is not set CONFIG_PHY_ROCKCHIP_DPHY_RX0=y CONFIG_VIDEO_ROCKCHIP_ISP1=y This will cause the following compilation errors: drivers/staging/media/rkisp1/rkisp1-isp.o: In function `rkisp1_mipi_csi2_start.isra.5': rkisp1-isp.c:(.text+0x1238): undefined reference to `phy_mipi_dphy_get_default_config' make: *** [vmlinux] Error 1 Signed-off-by: Zhang Xiaoxu --- drivers/staging/media/rkisp1/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/rkisp1/Kconfig b/drivers/staging/media/rkisp1/Kconfig index b859a493caba..23080b7f07a6 100644 --- a/drivers/staging/media/rkisp1/Kconfig +++ b/drivers/staging/media/rkisp1/Kconfig @@ -3,7 +3,7 @@ config VIDEO_ROCKCHIP_ISP1 tristate "Rockchip Image Signal Processing v1 Unit driver" depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API - depends on ARCH_ROCKCHIP || COMPILE_TEST + depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF select VIDEOBUF2_DMA_CONTIG select VIDEOBUF2_VMALLOC select V4L2_FWNODE