From patchwork Tue Dec 31 19:11:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 60948 X-Patchwork-Delegate: sean@mess.org Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1imMv1-006lSj-NM; Tue, 31 Dec 2019 19:11:03 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727120AbfLaTLh (ORCPT + 1 other); Tue, 31 Dec 2019 14:11:37 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:38067 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727071AbfLaTLh (ORCPT ); Tue, 31 Dec 2019 14:11:37 -0500 Received: by mail-pl1-f196.google.com with SMTP id f20so16165454plj.5; Tue, 31 Dec 2019 11:11:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lQdJvCTpaeep71PkxgVm04JNX1seJqxMx0Ss3EM+vAI=; b=FNZOGVaojf4cMrj0OHRNBpwvRuuJT95koi0GS9h+9nqodymkEsKwVGwGQBItouFalB qThnULG4Oki7IYjXXqvbwqNicjhXKtIMOQxdagH0vyjfWdt9zgu0odnrRAjpBY08Dow+ bIh2JKtatPOnP97u9MbLbAmQx3PuR3jRsPWjjkMVowQ2vCVb5vvmVgZCqUB2t3O0y5qb c2imLoAeHwntI3v0B0uPx3Fz3coObVFC8InunSxTPnpfLteEeOhgLWZgrrTWXIOjAKRZ sTgct4cuX8J9PgQcX+SxnD5r6WBzA6J5Df2lWrellm7W3MFkyl8IwmC5YRhyCTBjA6IF V2eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lQdJvCTpaeep71PkxgVm04JNX1seJqxMx0Ss3EM+vAI=; b=pd7NPA/gsN03+RSzNZXd25rF34MQNhP6EfGRZ/AkYvzN7pi+beg4oOXhtSSHekDvOs kzx2KdcpBGU4a2AdNthnTNb/rsmynjjr00Mthn6hjdhy0jEmphMo65dnwW7tg4eXiVkt 3A6JV3/Mwi3tE3qHkQH4/35HEQNqo14j3OT1wk2TGrv0dRuZOFXwhKtCoQmmvyYuPzmb LVkNRqJb+4ezuJojLg21h+lQOmf55bJrZi5g7SADq4DvhoHJh7IyxYFoTrmPJD+QNlyl q5xP8l9Y9mwSdQlJmt3Khad4zlYOcnL8wtUNvmVuXW0mzkuds6S68WWLfGo0cZdS0R4J K/ow== X-Gm-Message-State: APjAAAVw5O83cMT8qtwg5+joB4MXvKfTFsDbbQzRJzoRgWMFN/NFPkHN e8UfrnqWLYpHaKEtvKFwdrc= X-Google-Smtp-Source: APXvYqzpsN0b1PKJ0QC6kB7iewh9kWewA5K03iHnkT+RRCyZeXpHow7Q1iPCNiQPSfmx9uGAk+6Kdg== X-Received: by 2002:a17:90a:3586:: with SMTP id r6mr8127193pjb.36.1577819496495; Tue, 31 Dec 2019 11:11:36 -0800 (PST) Received: from localhost.localdomain ([2804:14d:72b1:8920:a2ce:f815:f14d:bfac]) by smtp.gmail.com with ESMTPSA id s24sm4366134pjp.17.2019.12.31.11.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Dec 2019 11:11:36 -0800 (PST) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: mchehab@kernel.org, gregkh@linuxfoundation.org, rfontana@redhat.com, kstewart@linuxfoundation.org, tglx@linutronix.de Cc: "Daniel W. S. Almeida" , skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/4] media: dvb_dummy_fe: place EXPORT_SYMBOL below corresponding function Date: Tue, 31 Dec 2019 16:11:20 -0300 Message-Id: X-Mailer: git-send-email 2.24.1 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: "Daniel W. S. Almeida" dvb_dummy_fe.c had all its EXPORT_SYMBOL macros located at the end of the file. Now these are located directly below the symbol they are exporting for increased readability. Suggested-by: Shuah Khan Signed-off-by: Daniel W. S. Almeida --- drivers/media/dvb-frontends/dvb_dummy_fe.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.c b/drivers/media/dvb-frontends/dvb_dummy_fe.c index 4db679cb70ad..909dac2345c4 100644 --- a/drivers/media/dvb-frontends/dvb_dummy_fe.c +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.c @@ -121,6 +121,7 @@ struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void) state->frontend.demodulator_priv = state; return &state->frontend; } +EXPORT_SYMBOL(dvb_dummy_fe_ofdm_attach); static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops; @@ -138,6 +139,7 @@ struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void) state->frontend.demodulator_priv = state; return &state->frontend; } +EXPORT_SYMBOL(dvb_dummy_fe_qpsk_attach); static const struct dvb_frontend_ops dvb_dummy_fe_qam_ops; @@ -155,6 +157,7 @@ struct dvb_frontend *dvb_dummy_fe_qam_attach(void) state->frontend.demodulator_priv = state; return &state->frontend; } +EXPORT_SYMBOL(dvb_dummy_fe_qam_attach); static const struct dvb_frontend_ops dvb_dummy_fe_ofdm_ops = { .delsys = { SYS_DVBT }, @@ -253,7 +256,3 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops = { MODULE_DESCRIPTION("DVB DUMMY Frontend"); MODULE_AUTHOR("Emard"); MODULE_LICENSE("GPL"); - -EXPORT_SYMBOL(dvb_dummy_fe_ofdm_attach); -EXPORT_SYMBOL(dvb_dummy_fe_qam_attach); -EXPORT_SYMBOL(dvb_dummy_fe_qpsk_attach); From patchwork Tue Dec 31 19:11:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 60949 X-Patchwork-Delegate: sean@mess.org Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1imMv7-006lcT-7Y; Tue, 31 Dec 2019 19:11:09 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727142AbfLaTLm (ORCPT + 1 other); Tue, 31 Dec 2019 14:11:42 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:42082 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727071AbfLaTLl (ORCPT ); Tue, 31 Dec 2019 14:11:41 -0500 Received: by mail-pg1-f195.google.com with SMTP id s64so19840598pgb.9; Tue, 31 Dec 2019 11:11:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G9QI4PrbeWqroS6tAxBy0bK45gx6KDWGGHt4P5wamwM=; b=ttYTtR/iOEbRlwhR9N4JDNACG8n0csT8FfkuRfy+t66SHKNSbkiCppcgah9SnHctuJ khumpLXfONuAySvfnjYr36lRYZXaq4iqzzD+HBSjCLsOYtMJLEVEkO1V3c5qBVKDBT1z vPi5H031qhxh/gZo+pJzd15ftbxwCfZcB7DZWbAfuAHZodptgsAc0Pmh+Qo7ioVAvaND AlzSxrIU0WmiiXKLFBwcOtI8GAr1bpscWqNmmN0xIcRHMJbiCP5UaR2/l/VjlW4j+PyY jlLnHmcsqVxQlhGPO8NXlcjrvZGWNRQLt+hQ599gBKrt/zavxK7eob38bJbjmZKCKGpd hAQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G9QI4PrbeWqroS6tAxBy0bK45gx6KDWGGHt4P5wamwM=; b=kPGjMV+ecDOvXFJqBh5AGMgkGhHABULjaiKBqCtnlEQ4NOFEVJm3CqKnLT7NsANnk1 bADdsBVgkj7JaF1rb8HQhBkcu0bUB80cZ4TrFEG4nciIYcEh+CaMBe2ivfrMpnkM2aRd 6GFKxfuA/QZJX+CdqViTVrD2jRZ8uog5fwE8i5hS7aSiGtkF13gVRVCVnJUYPp8dqU3/ B3w7UjXA2q96XfnTLkP2mEpAdjNl9FEVl79D//ZKkGVHjoObRz4EDNLpmUz4DlAqABZZ yU4VWjTP0VxhnALQ7GvjtMpaEZdJUeaTgI1fzFBamynIsZBcIrXl1gH7o0qeP4af2CeP v/UQ== X-Gm-Message-State: APjAAAXmzFApBHjPJgGYkF++gsD/hZC1HOBW1OZCaCyTLEUMHbNJ65yu IS27KjvXpkRWH3+r0xVNE8E= X-Google-Smtp-Source: APXvYqwN/e3wUCIa2i8bgq3dmzMxgj4T2Z0Fae/ArNBL4psGpGe9ae3rgUKzfwv9zwkRkF+fEs7Y7A== X-Received: by 2002:a63:f551:: with SMTP id e17mr78374246pgk.162.1577819500891; Tue, 31 Dec 2019 11:11:40 -0800 (PST) Received: from localhost.localdomain ([2804:14d:72b1:8920:a2ce:f815:f14d:bfac]) by smtp.gmail.com with ESMTPSA id s24sm4366134pjp.17.2019.12.31.11.11.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Dec 2019 11:11:40 -0800 (PST) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: mchehab@kernel.org, gregkh@linuxfoundation.org, rfontana@redhat.com, kstewart@linuxfoundation.org, tglx@linutronix.de Cc: "Daniel W. S. Almeida" , skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/4] media: dvb_dummy_fe: Fix ERROR: POINTER_LOCATION, AVOID_EXTERN and long lines Date: Tue, 31 Dec 2019 16:11:21 -0300 Message-Id: X-Mailer: git-send-email 2.24.1 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: "Daniel W. S. Almeida" Change foo* bar to foo *bar to avoid ERROR: POINTER_LOCATION in checkpatch.pl ERROR: "foo* bar" should be "foo *bar" +static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend* fe, u16* strength) ERROR: "foo* bar" should be "foo *bar" +static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend* fe, u16* strength) ERROR: "foo* bar" should be "foo *bar" +static int dvb_dummy_fe_read_snr(struct dvb_frontend* fe, u16* snr) ERROR: "foo* bar" should be "foo *bar" +static int dvb_dummy_fe_read_snr(struct dvb_frontend* fe, u16* snr) ERROR: "foo* bar" should be "foo *bar" +static int dvb_dummy_fe_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks) ERROR: "foo* bar" should be "foo *bar" +static int dvb_dummy_fe_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks) ERROR: "foo* bar" should be "foo *bar" +static int dvb_dummy_fe_sleep(struct dvb_frontend* fe) ERROR: "foo* bar" should be "foo *bar" +static int dvb_dummy_fe_init(struct dvb_frontend* fe) ERROR: "foo* bar" should be "foo *bar" +static void dvb_dummy_fe_release(struct dvb_frontend* fe) ERROR: "foo* bar" should be "foo *bar" + struct dvb_dummy_fe_state* state = fe->demodulator_priv; ERROR: "foo* bar" should be "foo *bar" +struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void) ERROR: "foo* bar" should be "foo *bar" + struct dvb_dummy_fe_state* state = NULL; ERROR: "foo* bar" should be "foo *bar" + struct dvb_dummy_fe_state* state = NULL; ERROR: "foo* bar" should be "foo *bar" + struct dvb_dummy_fe_state* state = NULL; remove 'extern' keyword from declaration Fix CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files by removing it. Fix long lines Break long lines into smaller ones to improve readability. WARNING: line over 80 characters + memcpy(&state->frontend.ops, &dvb_dummy_fe_ofdm_ops, sizeof(struct dvb_frontend_ops)); WARNING: line over 80 characters + memcpy(&state->frontend.ops, &dvb_dummy_fe_qpsk_ops, sizeof(struct dvb_frontend_ops)); WARNING: line over 80 characters + memcpy(&state->frontend.ops, &dvb_dummy_fe_qam_ops, sizeof(struct dvb_frontend_ops)); WARNING: line over 80 characters + FE_CAN_FEC_4_5 | FE_CAN_FEC_5_6 | FE_CAN_FEC_6_7 | WARNING: line over 80 characters + FE_CAN_FEC_7_8 | FE_CAN_FEC_8_9 | FE_CAN_FEC_AUTO | WARNING: line over 80 characters + FE_CAN_QAM_16 | FE_CAN_QAM_64 | FE_CAN_QAM_AUTO | WARNING: line over 80 characters + .symbol_rate_min = (57840000 / 2) / 6 Suggested-by: Shuah Khan Signed-off-by: Daniel W. S. Almeida --- drivers/media/dvb-frontends/dvb_dummy_fe.c | 83 ++++++++++++++-------- drivers/media/dvb-frontends/dvb_dummy_fe.h | 6 +- 2 files changed, 58 insertions(+), 31 deletions(-) diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.c b/drivers/media/dvb-frontends/dvb_dummy_fe.c index 909dac2345c4..e7f51d581d63 100644 --- a/drivers/media/dvb-frontends/dvb_dummy_fe.c +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.c @@ -31,25 +31,26 @@ static int dvb_dummy_fe_read_status(struct dvb_frontend *fe, return 0; } -static int dvb_dummy_fe_read_ber(struct dvb_frontend* fe, u32* ber) +static int dvb_dummy_fe_read_ber(struct dvb_frontend *fe, u32 *ber) { *ber = 0; return 0; } -static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend* fe, u16* strength) +static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend *fe, + u16 *strength) { *strength = 0; return 0; } -static int dvb_dummy_fe_read_snr(struct dvb_frontend* fe, u16* snr) +static int dvb_dummy_fe_read_snr(struct dvb_frontend *fe, u16 *snr) { *snr = 0; return 0; } -static int dvb_dummy_fe_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks) +static int dvb_dummy_fe_read_ucblocks(struct dvb_frontend *fe, u32 *ucblocks) { *ucblocks = 0; return 0; @@ -77,12 +78,12 @@ static int dvb_dummy_fe_set_frontend(struct dvb_frontend *fe) return 0; } -static int dvb_dummy_fe_sleep(struct dvb_frontend* fe) +static int dvb_dummy_fe_sleep(struct dvb_frontend *fe) { return 0; } -static int dvb_dummy_fe_init(struct dvb_frontend* fe) +static int dvb_dummy_fe_init(struct dvb_frontend *fe) { return 0; } @@ -99,17 +100,17 @@ static int dvb_dummy_fe_set_voltage(struct dvb_frontend *fe, return 0; } -static void dvb_dummy_fe_release(struct dvb_frontend* fe) +static void dvb_dummy_fe_release(struct dvb_frontend *fe) { - struct dvb_dummy_fe_state* state = fe->demodulator_priv; + struct dvb_dummy_fe_state *state = fe->demodulator_priv; kfree(state); } static const struct dvb_frontend_ops dvb_dummy_fe_ofdm_ops; -struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void) +struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void) { - struct dvb_dummy_fe_state* state = NULL; + struct dvb_dummy_fe_state *state = NULL; /* allocate memory for the internal state */ state = kzalloc(sizeof(struct dvb_dummy_fe_state), GFP_KERNEL); @@ -117,7 +118,10 @@ struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void) return NULL; /* create dvb_frontend */ - memcpy(&state->frontend.ops, &dvb_dummy_fe_ofdm_ops, sizeof(struct dvb_frontend_ops)); + memcpy(&state->frontend.ops, + &dvb_dummy_fe_ofdm_ops, + sizeof(struct dvb_frontend_ops)); + state->frontend.demodulator_priv = state; return &state->frontend; } @@ -127,7 +131,7 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops; struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void) { - struct dvb_dummy_fe_state* state = NULL; + struct dvb_dummy_fe_state *state = NULL; /* allocate memory for the internal state */ state = kzalloc(sizeof(struct dvb_dummy_fe_state), GFP_KERNEL); @@ -135,7 +139,10 @@ struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void) return NULL; /* create dvb_frontend */ - memcpy(&state->frontend.ops, &dvb_dummy_fe_qpsk_ops, sizeof(struct dvb_frontend_ops)); + memcpy(&state->frontend.ops, + &dvb_dummy_fe_qpsk_ops, + sizeof(struct dvb_frontend_ops)); + state->frontend.demodulator_priv = state; return &state->frontend; } @@ -145,7 +152,7 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qam_ops; struct dvb_frontend *dvb_dummy_fe_qam_attach(void) { - struct dvb_dummy_fe_state* state = NULL; + struct dvb_dummy_fe_state *state = NULL; /* allocate memory for the internal state */ state = kzalloc(sizeof(struct dvb_dummy_fe_state), GFP_KERNEL); @@ -153,7 +160,10 @@ struct dvb_frontend *dvb_dummy_fe_qam_attach(void) return NULL; /* create dvb_frontend */ - memcpy(&state->frontend.ops, &dvb_dummy_fe_qam_ops, sizeof(struct dvb_frontend_ops)); + memcpy(&state->frontend.ops, + &dvb_dummy_fe_qam_ops, + sizeof(struct dvb_frontend_ops)); + state->frontend.demodulator_priv = state; return &state->frontend; } @@ -166,13 +176,21 @@ static const struct dvb_frontend_ops dvb_dummy_fe_ofdm_ops = { .frequency_min_hz = 0, .frequency_max_hz = 863250 * kHz, .frequency_stepsize_hz = 62500, - .caps = FE_CAN_FEC_1_2 | FE_CAN_FEC_2_3 | FE_CAN_FEC_3_4 | - FE_CAN_FEC_4_5 | FE_CAN_FEC_5_6 | FE_CAN_FEC_6_7 | - FE_CAN_FEC_7_8 | FE_CAN_FEC_8_9 | FE_CAN_FEC_AUTO | - FE_CAN_QAM_16 | FE_CAN_QAM_64 | FE_CAN_QAM_AUTO | - FE_CAN_TRANSMISSION_MODE_AUTO | - FE_CAN_GUARD_INTERVAL_AUTO | - FE_CAN_HIERARCHY_AUTO, + .caps = FE_CAN_FEC_1_2 | + FE_CAN_FEC_2_3 | + FE_CAN_FEC_3_4 | + FE_CAN_FEC_4_5 | + FE_CAN_FEC_5_6 | + FE_CAN_FEC_6_7 | + FE_CAN_FEC_7_8 | + FE_CAN_FEC_8_9 | + FE_CAN_FEC_AUTO | + FE_CAN_QAM_16 | + FE_CAN_QAM_64 | + FE_CAN_QAM_AUTO | + FE_CAN_TRANSMISSION_MODE_AUTO | + FE_CAN_GUARD_INTERVAL_AUTO | + FE_CAN_HIERARCHY_AUTO, }, .release = dvb_dummy_fe_release, @@ -197,11 +215,16 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qam_ops = { .frequency_min_hz = 51 * MHz, .frequency_max_hz = 858 * MHz, .frequency_stepsize_hz = 62500, - .symbol_rate_min = (57840000 / 2) / 64, /* SACLK/64 == (XIN/2)/64 */ + /* symbol_rate_min: SACLK/64 == (XIN/2)/64 */ + .symbol_rate_min = (57840000 / 2) / 64, .symbol_rate_max = (57840000 / 2) / 4, /* SACLK/4 */ - .caps = FE_CAN_QAM_16 | FE_CAN_QAM_32 | FE_CAN_QAM_64 | - FE_CAN_QAM_128 | FE_CAN_QAM_256 | - FE_CAN_FEC_AUTO | FE_CAN_INVERSION_AUTO + .caps = FE_CAN_QAM_16 | + FE_CAN_QAM_32 | + FE_CAN_QAM_64 | + FE_CAN_QAM_128 | + FE_CAN_QAM_256 | + FE_CAN_FEC_AUTO | + FE_CAN_INVERSION_AUTO }, .release = dvb_dummy_fe_release, @@ -230,8 +253,12 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops = { .symbol_rate_min = 1000000, .symbol_rate_max = 45000000, .caps = FE_CAN_INVERSION_AUTO | - FE_CAN_FEC_1_2 | FE_CAN_FEC_2_3 | FE_CAN_FEC_3_4 | - FE_CAN_FEC_5_6 | FE_CAN_FEC_7_8 | FE_CAN_FEC_AUTO | + FE_CAN_FEC_1_2 | + FE_CAN_FEC_2_3 | + FE_CAN_FEC_3_4 | + FE_CAN_FEC_5_6 | + FE_CAN_FEC_7_8 | + FE_CAN_FEC_AUTO | FE_CAN_QPSK }, diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.h b/drivers/media/dvb-frontends/dvb_dummy_fe.h index 526fabd7751f..1c82338e0c8a 100644 --- a/drivers/media/dvb-frontends/dvb_dummy_fe.h +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.h @@ -12,9 +12,9 @@ #include #if IS_REACHABLE(CONFIG_DVB_DUMMY_FE) -extern struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void); -extern struct dvb_frontend* dvb_dummy_fe_qpsk_attach(void); -extern struct dvb_frontend* dvb_dummy_fe_qam_attach(void); +struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void); +struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void); +struct dvb_frontend *dvb_dummy_fe_qam_attach(void); #else static inline struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void) { From patchwork Tue Dec 31 19:11:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 60951 X-Patchwork-Delegate: sean@mess.org Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1imMvD-006lcj-8J; Tue, 31 Dec 2019 19:11:15 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727161AbfLaTLq (ORCPT + 1 other); Tue, 31 Dec 2019 14:11:46 -0500 Received: from mail-pj1-f67.google.com ([209.85.216.67]:50990 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727071AbfLaTLq (ORCPT ); Tue, 31 Dec 2019 14:11:46 -0500 Received: by mail-pj1-f67.google.com with SMTP id r67so1471606pjb.0; Tue, 31 Dec 2019 11:11:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P9GfKOO98mLmW+DdmACwpqWQT43A7np+giNx/HT6uWc=; b=Til1MmZuV4E/d9iQUF/gCA4zz07qu0do0t5QqeE3JvrbTHGq+IrD6X4sGlBcMwFRjn QcBQSlZxPmALTMvuC7Z4M7NuLFAozJF9e5ojvkb7SHq84pBg2oDrEGGXqyMSK1glJAKs xpgK+NavZtU/MrRW8KFUR7wNZNKECNydQz4v+RCH8dlyKcOx/0isAM0CSKFzjYs/RCP+ 4rs/NxjVKJEvzytuRoiS+hWs2kn4ZIgTbIf2Ae0CjIhGBXe3yv+NxLc9TXTWPB+J99yf MUOr85iERJupJnCo1VC4a//75XfcoQ18uxwM/5w+UgyOCH5dvpd9bFdE6EXYGMyDDshN FIVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P9GfKOO98mLmW+DdmACwpqWQT43A7np+giNx/HT6uWc=; b=qLY54t+/TAXERDB+dV4048JC8g1f0dmojjcUXArdFILVE1yhrV7tYQO4HTJ/iS6uGd Bl0+TZSpBZuVPLmb3V/vumYW1zlZ2vptLL/iC6xIWwdcoxlg1Yd3Iv7fjgEgZK/ubUJS ZVvC376i4u1y+BAT862k1BogZuSJSblOddATSJc5GwZ2DXfju/CwhRfi41rLAwEQcbX9 MM5ywGAUTlqdOP7CsIPDlWZqqule7Oz5TD/6r6i6aBLs8ODb3zwgme2W2TDW1egdavus /vT1ZKZ8L6GIDjXyAZtbv6NgGTjkN4CWeenTI7wNHAi71XxJgstE4k0SCSfmzeEXfKdL YQbA== X-Gm-Message-State: APjAAAWpLy4R8fpdqiKVgaSHAWPxjtWquxRPm8Him+uPuJgET2qfIIJX BSNegWIxARapXs0ZOpF32zoZl8ApW4M= X-Google-Smtp-Source: APXvYqxAHyyWgIAmnBTE3YfTzv4hLEsBVEpht/EycOHxjO0ky6GRYg1fdc+j9W4Ozz+YAO8uOrzE/w== X-Received: by 2002:a17:90a:d787:: with SMTP id z7mr8267446pju.10.1577819505442; Tue, 31 Dec 2019 11:11:45 -0800 (PST) Received: from localhost.localdomain ([2804:14d:72b1:8920:a2ce:f815:f14d:bfac]) by smtp.gmail.com with ESMTPSA id s24sm4366134pjp.17.2019.12.31.11.11.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Dec 2019 11:11:45 -0800 (PST) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: mchehab@kernel.org, gregkh@linuxfoundation.org, rfontana@redhat.com, kstewart@linuxfoundation.org, tglx@linutronix.de Cc: "Daniel W. S. Almeida" , skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/4] media: dvb_dummy_fe: Add blank line after declaration Date: Tue, 31 Dec 2019 16:11:22 -0300 Message-Id: <9b56605120ee19438df872e209703ad300a781c9.1577819245.git.dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: "Daniel W. S. Almeida" Fix checkpatch.pl error by adding a blank line Signed-off-by: Daniel W. S. Almeida --- drivers/media/dvb-frontends/dvb_dummy_fe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.c b/drivers/media/dvb-frontends/dvb_dummy_fe.c index e7f51d581d63..9ff1ebaa5e04 100644 --- a/drivers/media/dvb-frontends/dvb_dummy_fe.c +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.c @@ -103,6 +103,7 @@ static int dvb_dummy_fe_set_voltage(struct dvb_frontend *fe, static void dvb_dummy_fe_release(struct dvb_frontend *fe) { struct dvb_dummy_fe_state *state = fe->demodulator_priv; + kfree(state); } From patchwork Tue Dec 31 19:11:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 60950 X-Patchwork-Delegate: sean@mess.org Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1imMvC-006lcj-Do; Tue, 31 Dec 2019 19:11:14 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727189AbfLaTLv (ORCPT + 1 other); Tue, 31 Dec 2019 14:11:51 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:45842 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727071AbfLaTLu (ORCPT ); Tue, 31 Dec 2019 14:11:50 -0500 Received: by mail-pg1-f195.google.com with SMTP id b9so19840762pgk.12; Tue, 31 Dec 2019 11:11:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s7NsGFyL6ByjBH13eAXZBut56mwO2xt3ZeGeMcb+Hlk=; b=f2E0eSG3VPeN1Itxwp9OiDcbMBPFeXFrp6ejxUcR0RkjQIFjoFziKemsGuZH/1cyMt X0bfUbxzDlxEMZzlN6pfA1ZF2b0eW9nIvfYIO8FbQ62UT7nzhgvt5+u6Lf9A7m/s7QNM EdsqCWy6kNb2FVJvJCds8Du7MwicmEhhSVpUOJ0CutvU9CbNKak65z5YJPSp+IPZMyHa ZBp6Wdiw1VMwCpdXE75Jb1fX0POMy0VSVSygCsxiPFsJyQMDI8lkMgZmVEIxudTlUfqw SlMqMybXsl5NtLUloXuI+XkuKANsI3rDO+krPa3GI6sNH9qQHvg4RF3sJ23+v6Fln5X3 knHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s7NsGFyL6ByjBH13eAXZBut56mwO2xt3ZeGeMcb+Hlk=; b=iX+uU4biUusZh2omV9ShMtE+k2gNttOHI+32414XrzNj4LTvzsa6sSdSaBDvPpyQsP HK6x3Yv5xRwEbkh3OG6fxxonumfSKbgs52idLmLCuKVN03JdfkQtXQKhvBeB2/QpKpRG b2yfCA5CEeD/RBgRj6GM0/WuraOVatbPuW3YsvmYevVOLasjnYjYItlfT2qUo4hNrcK+ UgXRmyffCbm7jeh7Jjf+kXoOMNlG/qCG0QKAeAREjDmolovI1lcuPwZ+kJYUPCHMkhpn 0vQktxH3alTJiZ9VR65Dl/B/+4RsOggTrC+ibsMHdZhhDElCLs27PXwnbq1so1d0Ym2A KEOQ== X-Gm-Message-State: APjAAAVn7/FvHnrjhmku/gjM4oR7+giwompycWTbLfL9vTb37KjARjFi MjByK2niJhzO+I5Q4S00mMA= X-Google-Smtp-Source: APXvYqx5y1vzawjtwVueYppF+V0vbzdFcCD9/8ei8Oup39lR4dzKiCzp/e1weIe0JQq76mIxic9NVA== X-Received: by 2002:a63:d249:: with SMTP id t9mr81411546pgi.263.1577819509949; Tue, 31 Dec 2019 11:11:49 -0800 (PST) Received: from localhost.localdomain ([2804:14d:72b1:8920:a2ce:f815:f14d:bfac]) by smtp.gmail.com with ESMTPSA id s24sm4366134pjp.17.2019.12.31.11.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Dec 2019 11:11:49 -0800 (PST) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: mchehab@kernel.org, gregkh@linuxfoundation.org, rfontana@redhat.com, kstewart@linuxfoundation.org, tglx@linutronix.de Cc: "Daniel W. S. Almeida" , skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 4/4] media: dvb_dummy_fe: change printk to pr_warn Date: Tue, 31 Dec 2019 16:11:23 -0300 Message-Id: X-Mailer: git-send-email 2.24.1 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: "Daniel W. S. Almeida" Replaces printk with pr_err to fix warnings from checkpatch.pl Signed-off-by: Daniel W. S. Almeida --- drivers/media/dvb-frontends/dvb_dummy_fe.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.h b/drivers/media/dvb-frontends/dvb_dummy_fe.h index 1c82338e0c8a..9e974397a246 100644 --- a/drivers/media/dvb-frontends/dvb_dummy_fe.h +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.h @@ -18,17 +18,17 @@ struct dvb_frontend *dvb_dummy_fe_qam_attach(void); #else static inline struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void) { - printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__); + pr_warn( "%s: driver disabled by Kconfig\n", __func__); return NULL; } static inline struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void) { - printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__); + pr_warn("%s: driver disabled by Kconfig\n", __func__); return NULL; } static inline struct dvb_frontend *dvb_dummy_fe_qam_attach(void) { - printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__); + pr_warn("%s: driver disabled by Kconfig\n", __func__); return NULL; } #endif /* CONFIG_DVB_DUMMY_FE */