From patchwork Wed Nov 11 20:40:17 2009
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: martinez@embl.de
X-Patchwork-Id: 12756
Received: from mail.embl-heidelberg.de ([194.94.44.200]
	helo=newmail.EMBL-Heidelberg.DE)
	by mail.linuxtv.org with esmtp (Exim 4.69)
	(envelope-from <martinez@embl.de>) id 1N8Jwx-0006A7-Jm
	for vdr@linuxtv.org; Wed, 11 Nov 2009 21:37:56 +0100
Received: (qmail 14212 invoked by uid 501); 11 Nov 2009 20:37:51 -0000
Received: from 10.1.1.228 by lxmail03.embl.de (envelope-from
	<martinez@embl.de>, uid 107) with qmail-scanner-2.06
	(clamdscan: 0.94.2/10012. spamassassin: 3.2.5.  
	Clear:RC:1(10.1.1.228):.
	Processed in 0.010154 secs); 11 Nov 2009 20:37:51 -0000
Received: from unknown (HELO webmail.embl.de) (10.1.1.228)
	by lxmail03.embl.de with SMTP; 11 Nov 2009 20:37:51 -0000
MIME-Version: 1.0
Date: Wed, 11 Nov 2009 21:40:17 +0100
From: <martinez@embl.de>
To: <vdr@linuxtv.org>
Message-ID: <df3234b05734d0debc0ca20e63f6b9d9@imap.embl.de>
X-Sender: martinez@embl.de
User-Agent: RoundCube Webmail/0.3-stable
X-LSpam-Score: -2.5 (--)
X-LSpam-Report: No, score=-2.5 required=5.0 tests=AWL=0.105,
	BAYES_00=-2.599 autolearn=ham
Subject: [vdr] rotor plugin puzzling question
X-BeenThere: vdr@linuxtv.org
X-Mailman-Version: 2.1.11
Precedence: list
Reply-To: VDR Mailing List <vdr@linuxtv.org>
List-Id: VDR Mailing List <vdr.linuxtv.org>
List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/options/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=unsubscribe>
List-Archive: <http://www.linuxtv.org/pipermail/vdr>
List-Post: <mailto:vdr@linuxtv.org>
List-Help: <mailto:vdr-request@linuxtv.org?subject=help>
List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Nov 2009 20:37:56 -0000
Status: O
X-Status: 
X-Keywords: 
X-UID: 21577

Is it just me or the newly released rotor plugin for vdr 1.7.9 needs the
following patch to the plugin itself in order to run (although it compiles
fine without it)
If the author reads these lines I would love to know why...

       while (c = strchr(c, '['))
       {
         char *e = strchr(++c, ']');
@@ -131,7 +132,7 @@
           break;
         }
       }
-      free(c);
+      free(commandstring);
     }
     cRotorPos *p = RotorPositions.GetfromSource(source->Code());
     if (p==RotorPositions.First())

--- rotor.c.old	2006-06-14 23:44:27.000000000 +0200
+++ rotor.c	2006-06-14 23:46:43.000000000 +0200
@@ -96,7 +96,8 @@
       continue;
     if ((diseqc=Diseqcs.Get(source->Code(),12000,'h')) ||
(diseqc=Diseqcs.Get(source->Code(),12000,'v')) ||
(diseqc=Diseqcs.Get(source->Code(),12000,'l')) ||
(diseqc=Diseqcs.Get(source->Code(),12000,'r'))) 
     {
-      char *c=strdup(diseqc->Commands());
+      char *commandstring=strdup(diseqc->Commands());
+      char *c=commandstring;