From patchwork Tue Nov 17 16:42:28 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rolf Ahrenberg X-Patchwork-Id: 12758 Received: from smtp-3.hut.fi ([130.233.228.93]) by mail.linuxtv.org with esmtp (Exim 4.69) (envelope-from ) id 1NAR9J-0003Yr-5s for vdr@linuxtv.org; Tue, 17 Nov 2009 17:43:25 +0100 Received: from localhost (katosiko.hut.fi [130.233.228.115]) by smtp-3.hut.fi (8.13.6/8.12.10) with ESMTP id nAHGgo5W024102 for ; Tue, 17 Nov 2009 18:42:50 +0200 Received: from smtp-3.hut.fi ([130.233.228.93]) by localhost (katosiko.hut.fi [130.233.228.115]) (amavisd-new, port 10024) with LMTP id 25640-463 for ; Tue, 17 Nov 2009 18:42:50 +0200 (EET) Received: from kosh.hut.fi (kosh.hut.fi [130.233.228.12]) by smtp-3.hut.fi (8.13.6/8.12.10) with ESMTP id nAHGgS1e024039 for ; Tue, 17 Nov 2009 18:42:28 +0200 Date: Tue, 17 Nov 2009 18:42:28 +0200 (EET) From: Rolf Ahrenberg To: VDR Mailing List In-Reply-To: <20091006061615.GB7428@media.lan> Message-ID: References: <20091006061615.GB7428@media.lan> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 X-TKK-Virus-Scanned: by amavisd-new-2.1.2-hutcc at katosiko.hut.fi X-LSpam-Score: -6.5 (------) X-LSpam-Report: No, score=-6.5 required=5.0 tests=AWL=0.130, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4 autolearn=ham Subject: Re: [vdr] VDR 1.7 and no subtitles with old PES recordings X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2009 16:43:25 -0000 Status: O X-Status: X-Keywords: X-UID: 21637 On Tue, 6 Oct 2009, jjtt@mbnet.fi wrote: > I'm contemplating updating my trusty 1.6.0 to the latest > development version, but I can't seem to get DVB subtitles > from old recordings to work. > > Subtitles are shown corretly both when viewing live tv and > when viewing new recordings, but when viewing old PES > recordings VDR just says that no subtitles are available. > > I'm using vanilla VDR and the xineliboutput plugin. Zimiq did all the hard work to pinpoint the faulty method: http://www.linuxtv.fi/viewtopic.php?p=24394#24394 At least this patch did help on my few old recordings: BR, --- rofa --- dvbsubtitle.c.orig 2009-11-17 18:29:16.000000000 +0200 +++ dvbsubtitle.c 2009-11-17 18:30:44.000000000 +0200 @@ -699,7 +699,7 @@ } if (Length > PayloadOffset + SubstreamHeaderLength) { - int64_t pts = PesGetPts(Data); + int64_t pts = PesHasPts(Data) ? PesGetPts(Data) : 0; if (pts) dbgconverter("Converter PTS: %lld\n", pts); const uchar *data = Data + PayloadOffset + SubstreamHeaderLength; // skip substream header