From patchwork Fri Mar 7 11:26:53 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rolf Ahrenberg X-Patchwork-Id: 12624 Received: from smtp-4.hut.fi ([130.233.228.94]) by www.linuxtv.org with esmtp (Exim 4.63) (envelope-from ) id 1JXajl-0000k3-GL for vdr@linuxtv.org; Fri, 07 Mar 2008 12:27:42 +0100 Received: from localhost (putosiko.hut.fi [130.233.228.114]) by smtp-4.hut.fi (8.13.6/8.12.10) with ESMTP id m27BR3Ks007551 for ; Fri, 7 Mar 2008 13:27:03 +0200 Received: from smtp-4.hut.fi ([130.233.228.94]) by localhost (putosiko.hut.fi [130.233.228.114]) (amavisd-new, port 10024) with LMTP id 15736-02 for ; Fri, 7 Mar 2008 13:27:02 +0200 (EET) Received: from kosh.hut.fi (kosh.hut.fi [130.233.228.10]) by smtp-4.hut.fi (8.13.6/8.12.10) with ESMTP id m27BQrm5007500 for ; Fri, 7 Mar 2008 13:26:53 +0200 Date: Fri, 7 Mar 2008 13:26:53 +0200 (EET) From: Rolf Ahrenberg To: VDR Mailing List In-Reply-To: <47D07212.3030003@cadsoft.de> Message-ID: References: <6473954D-6A29-4913-9E4D-0F64C6FF9669@dnainternet.net> <47CDA03D.7000305@cadsoft.de> <47CDAE49.6030706@googlemail.com> <47D07212.3030003@cadsoft.de> MIME-Version: 1.0 X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on putosiko.hut.fi X-TKK-Virus-Scanned: by amavisd-new-2.1.2-hutcc at putosiko.hut.fi X-LSpam-Score: -3.8 (---) X-LSpam-Report: No, score=-3.8 required=5.0 tests=AWL=0.250, RCVD_IN_DNSWL_MED=-4 autolearn=ham Subject: Re: [vdr] Hearing-impaired DVB subtitles X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.9 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2008 11:27:42 -0000 Status: O X-Status: X-Keywords: X-UID: 16015 On Thu, 6 Mar 2008, Klaus Schmidinger wrote: > None of these two is specified as "for the hard of hearing". Well, as Jouni already told, the Dutch is used here on YLE channels for hard of hearing purposes. :) > Maybe this is what's causing the problems here. While this makes sense for > audio, it might not be that useful for subtitles. I guess some change in > cDevice::EnsureSubtitleTrack() needs to be done to fix this. I guess this kind of small change would be enough. IMO, the subtitles should be shown only if a preferred language matches. BR, --- rofa --- device.c.orig 2008-03-07 13:18:09.000000000 +0200 +++ device.c 2008-03-07 13:18:49.000000000 +0200 @@ -1096,7 +1096,7 @@ void cDevice::EnsureSubtitleTrack(void) { if (Setup.DisplaySubtitles) { - eTrackType PreferredTrack = ttSubtitleFirst; + eTrackType PreferredTrack = ttNone; int LanguagePreference = -1; for (int i = ttSubtitleFirst; i <= ttSubtitleLast; i++) { const tTrackId *TrackId = GetTrack(eTrackType(i));