diff mbox

Hearing-impaired DVB subtitles

Message ID Pine.OSF.4.64.0803071319530.120203@kosh.hut.fi
State New
Headers

Commit Message

Rolf Ahrenberg March 7, 2008, 11:26 a.m. UTC 
  On Thu, 6 Mar 2008, Klaus Schmidinger wrote:

> None of these two is specified as "for the hard of hearing".

Well, as Jouni already told, the Dutch is used here on YLE channels for 
hard of hearing purposes. :)

> Maybe this is what's causing the problems here. While this makes sense for
> audio, it might not be that useful for subtitles. I guess some change in
> cDevice::EnsureSubtitleTrack() needs to be done to fix this.

I guess this kind of small change would be enough. IMO, the subtitles 
should be shown only if a preferred language matches.


BR,
--
rofa

Comments

Pertti Kosunen March 7, 2008, 2:25 p.m. UTC | #1 
Rolf Ahrenberg wrote:
> I guess this kind of small change would be enough. IMO, the subtitles 
> should be shown only if a preferred language matches.

I vote this for 1.6.0.
diff mbox

Patch

--- device.c.orig       2008-03-07 13:18:09.000000000 +0200
+++ device.c    2008-03-07 13:18:49.000000000 +0200
@@ -1096,7 +1096,7 @@ 
  void cDevice::EnsureSubtitleTrack(void)
  {
    if (Setup.DisplaySubtitles) {
-     eTrackType PreferredTrack = ttSubtitleFirst;
+     eTrackType PreferredTrack = ttNone;
       int LanguagePreference = -1;
       for (int i = ttSubtitleFirst; i <= ttSubtitleLast; i++) {
           const tTrackId *TrackId = GetTrack(eTrackType(i));