From patchwork Sun Oct 13 12:42:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "guido.cordaro@tiscali.it" X-Patchwork-Id: 20383 Received: from localhost ([127.0.0.1] helo=www.linuxtv.org) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1VVL0t-0004L2-QX; Sun, 13 Oct 2013 14:43:15 +0200 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1VVL0S-0004Kk-Sv for vdr@linuxtv.org; Sun, 13 Oct 2013 14:43:14 +0200 X-tubIT-Incoming-IP: 213.205.33.245 Received: from santino.mail.tiscali.it ([213.205.33.245]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp for id 1VVL0R-0002Zw-4q; Sun, 13 Oct 2013 14:42:48 +0200 Received: from [192.168.1.3] ([78.14.24.48]) by santino.mail.tiscali.it with id ccim1m00112Fa8E01cimYv; Sun, 13 Oct 2013 14:42:46 +0200 x-auth-user: guido.cordaro@tiscali.it Message-ID: <525A9546.90002@tiscali.it> Date: Sun, 13 Oct 2013 14:42:46 +0200 From: Guido Cordaro User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: VDR Mailing List References: <525A5F08.9070709@tiscali.it> <525A6119.8060807@tiscali.it> <525A6D8B.2080201@tvdr.de> In-Reply-To: <525A6D8B.2080201@tvdr.de> X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.10.13.123015 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' RCVD_FROM_IP_DATE 0.1, HTML_00_01 0.05, HTML_00_10 0.05, MIME_TEXT_ONLY_MP_MIXED 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, __ANY_URI 0, __BAT_BOUNDARY 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_MIXED 0, __FORWARDED_MSG 0, __HAS_FROM 0, __HAS_MSGID 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MOZILLA_USER_AGENT 0, __SANE_MSGID 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __URI_NS , __USER_AGENT 0' X-LSpam-Score: -1.1 (-) X-LSpam-Report: No, score=-1.1 required=5.0 tests=BAYES_00=-1.9, FREEMAIL_FROM=0.001, RDNS_NONE=0.793, URIBL_BLOCKED=0.001 autolearn=no Subject: Re: [vdr] Fix SIGNALSTRENGTH in vdr 2.0.3 TechniSat SkyStar 2 DVB-S rev 2.3P - dvbdevice.c X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: vdr-bounces@linuxtv.org Errors-To: vdr-bounces@linuxtv.org I understand your position ... and I modified the code again ... Without another unnecessary code I managed to make work well for the Signal Strength as I did with the first patch ... Tested by recompiling code VDR-2.0.3 New Patch to Fix Signal Strength in The Netsystem Skystar2 TechniSat DVB-S device ... It does not damage any other device in their operation ... in this way ... almost the same as before the source code ... Guido Cordaro Il 13/10/2013 11:53, Klaus Schmidinger ha scritto: > On 13.10.2013 11:00, guido.cordaro@tiscali.it wrote: >> Il 13/10/2013 10:51, guido.cordaro@tiscali.it ha scritto: >>> Thanks Klaus Schmidinger >>> >>> For having responded to my e-mail >>> >>> This' modified code that you send as an attachment ... >>> >>> Files created with " diff -urN > new.diff " > > Can you please elaborate on these changes? > Why did you pull stuff like FE_HAS_..., BER and UNC (as used in > GetSignalQuality()) into > GetSignalStrength()? > I can't accept the changes to Min- and MaxSignal in case of the > "TT-budget S2-3200". > I have such cards and they work fine with the original values. > > I'm really not sure what to make of your patch. It appears to me > like randomly winging in things that just may or may not work. > Unless you can give me some reasonable and clear arguments as to > why things should be changed that way, I'm afraid I can't accept this. > > Klaus > > _______________________________________________ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr --- /home/knap/Patch/vdr-2.0.3/dvbdevice.c 2013-09-01 23:04:05.000000000 +0200 +++ /home/knap/Patch/dvbdevice.c 2013-10-13 14:28:09.257450468 +0200 @@ -550,7 +550,7 @@ case 0x1AE40001: // TechniSat SkyStar HD2 (DVB-S/DVB-S2) MaxSignal = 670; break; } - int s = int(Signal) * 100 / MaxSignal; + int s = int(Signal) * 350 / MaxSignal; // Modified by knap for TechniSat SkyStar if (s > 100) s = 100; #ifdef DEBUG_SIGNALSTRENGTH