From patchwork Fri Apr  5 10:13:41 2013
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Klaus Schmidinger <Klaus.Schmidinger@tvdr.de>
X-Patchwork-Id: 17768
Received: from localhost ([127.0.0.1] helo=www.linuxtv.org)
	by www.linuxtv.org with esmtp (Exim 4.72)
	(envelope-from <vdr-bounces@linuxtv.org>)
	id 1UO3ew-0001zx-J8; Fri, 05 Apr 2013 12:14:14 +0200
Received: from mail.tu-berlin.de ([130.149.7.33])
	by www.linuxtv.org with esmtp (Exim 4.72)
	(envelope-from <Klaus.Schmidinger@tvdr.de>) id 1UO3eW-0001zk-OL
	for vdr@linuxtv.org; Fri, 05 Apr 2013 12:14:12 +0200
X-tubIT-Incoming-IP: 188.40.50.18
Received: from racoon.tvdr.de ([188.40.50.18])
	by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtps
	[TLSv1:AES256-SHA:256] for <vdr@linuxtv.org>
	id 1UO3eW-0005Sj-EJ; Fri, 05 Apr 2013 12:13:48 +0200
Received: from dolphin.tvdr.de (dolphin.tvdr.de [192.168.100.2])
	by racoon.tvdr.de (8.14.5/8.14.5) with ESMTP id r35ADlXA015504
	for <vdr@linuxtv.org>; Fri, 5 Apr 2013 12:13:47 +0200
Received: from [192.168.100.11] (falcon.tvdr.de [192.168.100.11])
	by dolphin.tvdr.de (8.14.4/8.14.4) with ESMTP id r35ADfiQ001082
	for <vdr@linuxtv.org>; Fri, 5 Apr 2013 12:13:41 +0200
Message-ID: <515EA3D5.20202@tvdr.de>
Date: Fri, 05 Apr 2013 12:13:41 +0200
From: Klaus Schmidinger <Klaus.Schmidinger@tvdr.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:17.0) Gecko/20130307 Thunderbird/17.0.4
MIME-Version: 1.0
To: VDR mailing list <vdr@linuxtv.org>
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379,
	Antispam-Data: 2013.4.5.100615
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report='
	HTML_00_01 0.05, HTML_00_10 0.05, MIME_TEXT_ONLY_MP_MIXED 0.05,
	BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0,
	BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0,
	BODY_SIZE_7000_LESS 0, SMALL_BODY 0, __ANY_URI 0,
	__BAT_BOUNDARY 0, __CP_URI_IN_BODY 0, __CT 0,
	__CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0,
	__CTYPE_MULTIPART_MIXED 0, __HAS_FROM 0, __HAS_MSGID 0,
	__MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0,
	__MOZILLA_USER_AGENT 0, __SANE_MSGID 0, __TO_MALFORMED_2 0,
	__URI_NO_MAILTO 0, __URI_NS , __USER_AGENT 0'
X-LSpam-Score: 3.3 (+++)
X-LSpam-Report: No, score=3.3 required=5.0 tests=BAYES_00=-1.9,
	RDNS_NONE=0.793, SUBJ_BROKEN_WORD=4.431 autolearn=no
Subject: [vdr] [PATCH] VDR 2.0.0: Fix initialization of cDevice::keepTracks.
X-BeenThere: vdr@linuxtv.org
X-Mailman-Version: 2.1.13
Precedence: list
Reply-To: VDR Mailing List <vdr@linuxtv.org>
List-Id: VDR Mailing List <vdr.linuxtv.org>
List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/options/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=unsubscribe>
List-Archive: <http://www.linuxtv.org/pipermail/vdr>
List-Post: <mailto:vdr@linuxtv.org>
List-Help: <mailto:vdr-request@linuxtv.org?subject=help>
List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=subscribe>
Sender: vdr-bounces@linuxtv.org
Errors-To: vdr-bounces@linuxtv.org

As reported here

   http://www.vdr-portal.de/board17-developer/board97-vdr-core/p1137010-zu-sp%C3%A4tes-initialisieren-der-variable-keeptracks-in-device-c

the member variable keepTracks is initialized too late in the cDevice c'tor.
The attached patch fixes this.

Klaus

--- device.c	2013/03/07 13:18:35	3.0
+++ device.c	2013/04/05 10:05:33
@@ -94,11 +94,11 @@
 
   player = NULL;
   isPlayingVideo = false;
+  keepTracks = false; // used in ClrAvailableTracks()!
   ClrAvailableTracks();
   currentAudioTrack = ttNone;
   currentAudioTrackMissingCount = 0;
   currentSubtitleTrack = ttNone;
-  keepTracks = false;
   liveSubtitle = NULL;
   dvbSubtitleConverter = NULL;
   autoSelectPreferredSubtitleLanguage = true;