From patchwork Sat Mar 23 16:14:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lucian Muresan X-Patchwork-Id: 17582 Received: from localhost ([127.0.0.1] helo=www.linuxtv.org) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1UJR65-0003gl-MW; Sat, 23 Mar 2013 17:15:09 +0100 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1UJR5h-0003gN-LO for vdr@linuxtv.org; Sat, 23 Mar 2013 17:15:08 +0100 X-tubIT-Incoming-IP: 209.85.215.179 Received: from mail-ea0-f179.google.com ([209.85.215.179]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtps [TLSv1:RC4-SHA:128] for id 1UJR5h-0001YK-Dy; Sat, 23 Mar 2013 17:14:45 +0100 Received: by mail-ea0-f179.google.com with SMTP id f15so1753793eak.10 for ; Sat, 23 Mar 2013 09:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :subject:content-type; bh=YvVodAL4J+XqwAi5n2q2tUwdPkKp3lym5G5lkX0GMcc=; b=oWC5NEH2+dzqZ0Zp4rD2Jem9S/HAx9T+rODnO7YH7qC6DC1Dtklb8Wx50L04x0oUoJ sGjCiKAN7WKk2uTnaJM2kp0ypP/ZGivctu/SEeaNAucSvHOtZw0KnLf03kdwFTeMwnfm l1JC3/7WaLNRi81QgLf9M0rMmBXOGT2zCdIRb3zbehG6Qszu/5x6msrXE4QL+4lTj1iZ hBPomn4xn5giV3MOowz2z+/Nku10GTDHYOnG9id0jFmxO6ylWVQNGOJB5N7LW5JKrbm9 sFnkvsYm+ipPq0OitQWC6MAlCOI/F3gN3NNU59r/DD0IY9bw13rfFoPnv2BpV6Lcx1ui ZAPg== X-Received: by 10.14.4.69 with SMTP id 45mr16016875eei.0.1364055284381; Sat, 23 Mar 2013 09:14:44 -0700 (PDT) Received: from [192.168.178.24] (p549538D8.dip.t-dialin.net. [84.149.56.216]) by mx.google.com with ESMTPS id 3sm9036583eej.6.2013.03.23.09.14.42 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 23 Mar 2013 09:14:43 -0700 (PDT) Message-ID: <514DD4F4.5090907@users.sourceforge.net> Date: Sat, 23 Mar 2013 17:14:44 +0100 From: Lucian Muresan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: VDR mailing list X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.3.23.160620 X-PMX-Spam: Gauge=X, Probability=10%, Report=' WEBMAIL_REPLYTO_NOT_FROM 0.5, HTML_00_01 0.05, HTML_00_10 0.05, MIME_TEXT_ONLY_MP_MIXED 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1900_1999 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, NO_URI_FOUND 0, RATWARE_LC_DIGITS_MSGID 0, WEBMAIL_SOURCE 0, __BAT_BOUNDARY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_MIXED 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_SENDER 0, __HAS_FROM 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MOZILLA_USER_AGENT 0, __PHISH_SPEAR_STRUCTURE_1 0, __PHISH_SPEAR_STRUCTURE_2 0, __RDNS_GMAIL 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __USER_AGENT 0, __YOUTUBE_RCVD 0' X-LSpam-Score: 1.1 (+) X-LSpam-Report: No, score=1.1 required=5.0 tests=BAYES_20=-0.001, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RDNS_NONE=0.793, T_DKIM_INVALID=0.01 autolearn=no Subject: [vdr] [PATCH] MaxThemeName and MaxSkinName limit X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: vdr-bounces@linuxtv.org Errors-To: vdr-bounces@linuxtv.org Hi, thank you Klaus for holding up your release plan for 2.0! However, I hope this minor patch won't be too much trouble for you, as it only increases the limit of 16 to theme and skin names, letting them be NAME_MAX as almost any files, since these names can also be involved in file names. Was there a good reason to limit them at 16 only, perhaps the fear that the name won't fit on the OSD? I don't really think someone would really make use of as many as 255 characters for this. On the other hand, users just encountered crashes with plugins which (unfortunately, yet) have themes of their own, when just adding a new theme with a name longer than 16 and at the same time the original plugin author relied on MaxThemeName when allocating the string length. So, what do you think, easy to adopt? Regards, Lucian diff -Naur vdr-1.7.42_orig/config.h vdr-1.7.42/config.h --- vdr-1.7.42_orig/config.h 2013-03-16 16:12:14.000000000 +0100 +++ vdr-1.7.42/config.h 2013-03-23 16:57:48.378701000 +0100 @@ -53,8 +53,8 @@ #define MAXOSDHEIGHT 1200 #define MaxFileName NAME_MAX // obsolete - use NAME_MAX directly instead! -#define MaxSkinName 16 -#define MaxThemeName 16 +#define MaxSkinName NAME_MAX // obsolete - use NAME_MAX directly instead! +#define MaxThemeName NAME_MAX // obsolete - use NAME_MAX directly instead! // Basically VDR works according to the DVB standard, but there are countries/providers // that use other standards, which in some details deviate from the DVB standard.