From patchwork Thu Nov 8 19:43:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Huelswitt X-Patchwork-Id: 15404 Received: from localhost ([127.0.0.1] helo=www.linuxtv.org) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TWY16-0003Ci-6Q; Thu, 08 Nov 2012 20:43:56 +0100 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TWY13-0003Cd-Kz for vdr@linuxtv.org; Thu, 08 Nov 2012 20:43:54 +0100 X-tubIT-Incoming-IP: 213.165.64.22 Received: from mailout-de.gmx.net ([213.165.64.22]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with smtp for id 1TWY13-0002Rg-Gu; Thu, 08 Nov 2012 20:43:53 +0100 Received: (qmail invoked by alias); 08 Nov 2012 19:43:44 -0000 Received: from ip-109-90-124-49.unitymediagroup.de (EHLO [192.168.1.6]) [109.90.124.49] by mail.gmx.net (mp040) with SMTP; 08 Nov 2012 20:43:44 +0100 X-Authenticated: #10968362 X-Provags-ID: V01U2FsdGVkX19ue95oD35u02MEzSGMjkFG/e63fdVFnunq+F6r9/ Uor62lPl2udutJ Message-ID: <509C0B70.20506@gmx.de> Date: Thu, 08 Nov 2012 20:43:44 +0100 From: Stefan Huelswitt User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: VDR Mailing List References: <509A7206.3010806@linenshorts.com> <509A8860.1010400@linenshorts.com> <509B7910.5070706@tvdr.de> In-Reply-To: <509B7910.5070706@tvdr.de> X-Y-GMX-Trusted: 0 X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.11.8.193618 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, MIME_TEXT_ONLY_MP_MIXED 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1700_1799 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, __ANY_URI 0, __BAT_BOUNDARY 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_MIXED 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __HAS_FROM 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MOZILLA_USER_AGENT 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NS , __USER_AGENT 0' X-LSpam-Score: -1.1 (-) X-LSpam-Report: No, score=-1.1 required=5.0 tests=BAYES_00=-1.9, FREEMAIL_FROM=0.001, RDNS_NONE=0.793 autolearn=no Subject: Re: [vdr] polarization character case in channels.conf X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: vdr-bounces@linuxtv.org Errors-To: vdr-bounces@linuxtv.org Hi, I can confirm this problem, at least in 1.7.27 (which I'm using at the moment). I use the attached patch to resolve it. Am 08.11.2012 10:19, schrieb Klaus Schmidinger: >>> Well, there is a toupper() in cDvbTransponderParameters::Parse(), so >>> I would expect that all characters can be given in either upper- or >>> lowercase. Right, but the toupper() is only in the comparision, but it passes the original (lowercase) value. And later during tuning the comparision fails. Regards. diff -uN -x .dependencies -x vdr.pc -x Make.config -x '*.o' -x '*.rej' vdr-1.7.27-orig/dvbdevice.c vdr-current-1.7.27/dvbdevice.c --- vdr-1.7.27-orig/dvbdevice.c 2012-03-25 12:41:45.000000000 +0200 +++ vdr-current-1.7.27/dvbdevice.c 2012-07-21 19:12:57.542055052 +0200 @@ -769,7 +771,7 @@ frequency -= Setup.LnbFrequHi; tone = SEC_TONE_ON; } - int volt = (dtp.Polarization() == 'V' || dtp.Polarization() == 'R') ? SEC_VOLTAGE_13 : SEC_VOLTAGE_18; + int volt = (dtp.Polarization() == 'V' || dtp.Polarization() == 'R' || dtp.Polarization() == 'v' || dtp.Polarization() == 'r') ? SEC_VOLTAGE_13 : SEC_VOLTAGE_18; if (GetBondedMaster() != this) { tone = SEC_TONE_OFF; volt = SEC_VOLTAGE_13;