| Message ID | 5049CD8B.2030900@tvdr.de |
|---|---|
| State | New |
| Headers |
Received: from localhost ([127.0.0.1] helo=www.linuxtv.org) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <vdr-bounces@linuxtv.org>) id 1T9vtE-0006DL-4e; Fri, 07 Sep 2012 12:34:20 +0200 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <Klaus.Schmidinger@tvdr.de>) id 1T9vso-0006Ca-Hw for vdr@linuxtv.org; Fri, 07 Sep 2012 12:34:19 +0200 X-tubIT-Incoming-IP: 188.40.50.18 Received: from racoon.tvdr.de ([188.40.50.18]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtps [TLSv1:AES256-SHA:256] for <vdr@linuxtv.org> id 1T9vso-0001Ad-EK; Fri, 07 Sep 2012 12:33:54 +0200 Received: from dolphin.tvdr.de (dolphin.tvdr.de [192.168.100.2]) by racoon.tvdr.de (8.14.5/8.14.5) with ESMTP id q87AXr3o023529 for <vdr@linuxtv.org>; Fri, 7 Sep 2012 12:33:53 +0200 Received: from [192.168.100.10] (hawk.tvdr.de [192.168.100.10]) by dolphin.tvdr.de (8.14.4/8.14.4) with ESMTP id q87AXlVv010759 for <vdr@linuxtv.org>; Fri, 7 Sep 2012 12:33:47 +0200 Message-ID: <5049CD8B.2030900@tvdr.de> Date: Fri, 07 Sep 2012 12:33:47 +0200 From: Klaus Schmidinger <Klaus.Schmidinger@tvdr.de> User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120825 Thunderbird/15.0 MIME-Version: 1.0 To: vdr@linuxtv.org References: <CAFHrtEQtKJRJjh4z2zmrwr7BKDUBRu2tqBEJS1vJazB42S2oxw@mail.gmail.com> <4F802386.2080706@gmx.de> <4F8142C8.4040005@gmx.de> <4F81C974.6030809@gmx.de> <CAFHrtES8_DdhRD1vZgpn8GM3mmuJTeZLTu6_kbFNTkRct3jhjA@mail.gmail.com> <CAA7C2qiJ9hFXLDWKdhsmEQAfsL==V7o3xo5V8qR7JzfKGgWVww@mail.gmail.com> <CAFHrtESjr2BF6jGEb_Oh_unJpA-65K1HXnZc754=ibkCZFgDaQ@mail.gmail.com> <4F82B1D9.6090908@tvdr.de> <4F82E1A7.6020906@gmx.de> <4F82F094.8020509@tvdr.de> <4FAA810A.10209@gmx.de> <50421255.3050204@tvdr.de> <5048F4CF.5000405@gmx.de> In-Reply-To: <5048F4CF.5000405@gmx.de> X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.9.7.102418 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_MEDIA_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_MAILTO 0, __URI_NO_PATH 0, __URI_NO_WWW 0, __USER_AGENT 0' X-LSpam-Score: -1.1 (-) X-LSpam-Report: No, score=-1.1 required=5.0 tests=BAYES_00=-1.9, RDNS_NONE=0.793 autolearn=no Subject: Re: [vdr] Filesystem hierachy standard patch needs review. X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: VDR Mailing List <vdr@linuxtv.org> List-Id: VDR Mailing List <vdr.linuxtv.org> List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/options/vdr>, <mailto:vdr-request@linuxtv.org?subject=unsubscribe> List-Archive: <http://www.linuxtv.org/pipermail/vdr> List-Post: <mailto:vdr@linuxtv.org> List-Help: <mailto:vdr-request@linuxtv.org?subject=help> List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=subscribe> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: vdr-bounces@linuxtv.org Errors-To: vdr-bounces@linuxtv.org |
Commit Message
Klaus Schmidinger
Sept. 7, 2012, 10:33 a.m. UTC
On 06.09.2012 21:09, Manuel Reimer wrote: > Klaus Schmidinger wrote: >> Attached is a revised version of the patch, as I intend to adopt >> it in version 1.7.30. > > Didn't try it, so far, but I had a look at it and maybe, I've found a small problem: > > +# By default VDR requires only one single directory to operate: > VIDEODIR = /video > -CONFDIR = $(VIDEODIR) > +# See Make.config.template if you want to build VDR according to the FHS ("File system Hierarchy Standard") > > [...] > > + > +install-conf: > + @cp *.conf $(DESTDIR)$(CONFDIR) > > > For me this seems like "install-conf" does not longer work if FHS is *not* used, as "CONFDIR" is not defined without the FHS mode enabled? Mabe this would help: Please let me know if this should be added. Klaus
Comments
Am 07.09.2012 12:33, schrieb Klaus Schmidinger: > On 06.09.2012 21:09, Manuel Reimer wrote: >> Klaus Schmidinger wrote: >>> Attached is a revised version of the patch, as I intend to adopt >>> it in version 1.7.30. >> >> Didn't try it, so far, but I had a look at it and maybe, I've found a >> small problem: >> >> +# By default VDR requires only one single directory to operate: >> VIDEODIR = /video >> -CONFDIR = $(VIDEODIR) >> +# See Make.config.template if you want to build VDR according to the >> FHS ("File system Hierarchy Standard") >> >> [...] >> >> + >> +install-conf: >> + @cp *.conf $(DESTDIR)$(CONFDIR) >> >> >> For me this seems like "install-conf" does not longer work if FHS is >> *not* used, as "CONFDIR" is not defined without the FHS mode enabled? > > Mabe this would help: > > --- Makefile 2012/09/01 13:22:33 2.28 > +++ Makefile 2012/09/07 10:31:35 > @@ -76,6 +76,10 @@ > DEFINES += -DPLUGINDIR=\"$(PLUGINLIBDIR)\" > DEFINES += -DLOCDIR=\"$(LOCDIR)\" > > +CONFDIR ?= $(VIDEODIR) > +CACHEDIR ?= $(VIDEODIR) > +RESDIR ?= $(CONFDIR) > + > # The version numbers of VDR and the plugin API (taken from VDR's > "config.h"): > > VDRVERSION = $(shell sed -ne '/define > VDRVERSION/s/^.*"\(.*\)".*$$/\1/p' config.h) > > > Please let me know if this should be added. > Hmm, CONFDIR ist already defined in the Makefile.
On 07.09.2012 13:04, Christopher Reimer wrote: > Am 07.09.2012 12:33, schrieb Klaus Schmidinger: >> On 06.09.2012 21:09, Manuel Reimer wrote: >>> Klaus Schmidinger wrote: >>>> Attached is a revised version of the patch, as I intend to adopt >>>> it in version 1.7.30. >>> >>> Didn't try it, so far, but I had a look at it and maybe, I've found a >>> small problem: >>> >>> +# By default VDR requires only one single directory to operate: >>> VIDEODIR = /video >>> -CONFDIR = $(VIDEODIR) >>> +# See Make.config.template if you want to build VDR according to the >>> FHS ("File system Hierarchy Standard") >>> >>> [...] >>> >>> + >>> +install-conf: >>> + @cp *.conf $(DESTDIR)$(CONFDIR) >>> >>> >>> For me this seems like "install-conf" does not longer work if FHS is >>> *not* used, as "CONFDIR" is not defined without the FHS mode enabled? >> >> Mabe this would help: >> >> --- Makefile 2012/09/01 13:22:33 2.28 >> +++ Makefile 2012/09/07 10:31:35 >> @@ -76,6 +76,10 @@ >> DEFINES += -DPLUGINDIR=\"$(PLUGINLIBDIR)\" >> DEFINES += -DLOCDIR=\"$(LOCDIR)\" >> >> +CONFDIR ?= $(VIDEODIR) >> +CACHEDIR ?= $(VIDEODIR) >> +RESDIR ?= $(CONFDIR) >> + >> # The version numbers of VDR and the plugin API (taken from VDR's >> "config.h"): >> >> VDRVERSION = $(shell sed -ne '/define >> VDRVERSION/s/^.*"\(.*\)".*$$/\1/p' config.h) >> >> >> Please let me know if this should be added. >> > Hmm, CONFDIR ist already defined in the Makefile. Not after vdr-1.7.29-fhs.diff has been applied. The above addition is meant to be made after applying that patch. Klaus
--- Makefile 2012/09/01 13:22:33 2.28 +++ Makefile 2012/09/07 10:31:35 @@ -76,6 +76,10 @@ DEFINES += -DPLUGINDIR=\"$(PLUGINLIBDIR)\" DEFINES += -DLOCDIR=\"$(LOCDIR)\" +CONFDIR ?= $(VIDEODIR) +CACHEDIR ?= $(VIDEODIR) +RESDIR ?= $(CONFDIR) + # The version numbers of VDR and the plugin API (taken from VDR's "config.h"): VDRVERSION = $(shell sed -ne '/define VDRVERSION/s/^.*"\(.*\)".*$$/\1/p' config.h)