From patchwork Sun May 27 11:37:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anssi Hannula X-Patchwork-Id: 12953 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1SYbmx-0005k7-8U for vdr@linuxtv.org; Sun, 27 May 2012 13:38:00 +0200 X-tubIT-Incoming-IP: 130.230.160.32 Received: from mail-gw-out1.cc.tut.fi ([130.230.160.32]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp for id 1SYbmw-0006g0-Ir; Sun, 27 May 2012 13:37:35 +0200 X-AuditID: 82e6a020-b7fbb6d000000ab8-7d-4fc211fc9aac Received: from mail2.tut.fi (mail2.tut.fi [130.230.162.20]) by mail-gw-out1.cc.tut.fi (Symantec Messaging Gateway) with SMTP id 44.BD.02744.CF112CF4; Sun, 27 May 2012 14:37:32 +0300 (EEST) Received: from sigma.onse.fi (host-109-204-144-132.tp-fne.tampereenpuhelin.net [109.204.144.132]) by mail2.tut.fi (Postfix) with ESMTPSA id 8FFB520A51 for ; Sun, 27 May 2012 14:37:32 +0300 (EEST) Message-ID: <4FC211FB.4030108@iki.fi> Date: Sun, 27 May 2012 14:37:31 +0300 From: Anssi Hannula User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120426 Thunderbird/10.0.4 MIME-Version: 1.0 To: VDR Mailing List References: <4FC1276B.1060404@makhutov.org> <4FC1431C.1060000@e-tobi.net> In-Reply-To: <4FC1431C.1060000@e-tobi.net> X-Enigmail-Version: 1.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsXS9GyRiO4fwUP+Bv9ma1isWPqM1YHRY/o0 mQDGKC6blNSczLLUIn27BK6Mh7vuMhfs5K2Yse0qWwNjP3cXIyeHhICJxL9ra9khbDGJC/fW s3UxcnEICexjlDjQ/4AVJCEkcINRYsINThCbV0BVYsOv32ANLED2meltzCA2m4CWRMPVhUBx Dg5RgQiJ+c8iIcoFJU7OfMICYosIqEl0ndsFVi4sYCSx/fJKFpByIQFPiYY1TCBhTqAp684v YoE4R1xi+fbXYDazQIBE66WfrBMY+WchmToLSQrC1pF41/eAGcKWl9j+dg6U7SLR/+YNI6a4 r8T2Sz9ZFjCyr2IUy03MzNFNL9fNLy0x1EtO1ispLdFLy9zECA7jBQo7GF9O0z/EKMDBqMTD ezD6oL8Qa2JZcWXuIUZJDiYlUd4YvkP+QnxJ+SmVGYnFGfFFpTmpxYcYJTiYlUR48zcAlfOm JFZWpRblw6RkODiUJHjNgTEnJFiUmp5akZaZA4xWmDQTBydIOw9QezBIDW9xQWJucWY6RP4U o6KUOK8ySEIAJJFRmgfXC0oVuWcmtLxiFAc6VphXEqSKB5hm4LpfAQ1mAho87SbIXcUliQgp qQZG37RZXxjyVE1SYrLFN+6cI9n9PMktmWVvTnDZNU72yUYH497szlj2bFb/Lmt78570OoGN +lwz7y/u96vgkNFvkJilPcnbP+my5/JDPBoS7K32P0rc3fuP/XoY9G8/S+4ni+LHHDvdV7qa m3xcHsSi/4zt/gHxOKF95o5qcSGpu2Z16T77naTEUpyRaKjFXFScCAAlpB628AIAAA== X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.27.112721 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, MIME_TEXT_ONLY_MP_MIXED 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1600_1699 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, __ANY_URI 0, __BAT_BOUNDARY 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_MIXED 0, __DATE_TZ_RU 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_MAILTO 0, __URI_NO_PATH 0, __URI_NO_WWW 0, __USER_AGENT 0' X-LSpam-Score: -3.4 (---) X-LSpam-Report: No, score=-3.4 required=5.0 tests=BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793 autolearn=ham Subject: Re: [vdr] Force VDR to save channels.conf X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 May 2012 11:38:00 -0000 Status: O X-Status: X-Keywords: X-UID: 26324 26.05.2012 23:54, Tobi kirjoitti: > On 26.05.2012 20:56, Artem Makhutov wrote: > >> How ever - when I restart VDR the changes are not getting saved to >> channels.conf. > > Check the syslog. There might be a plugin not cleanly shutting down, > making the vdr abort it's shutdown sequence causing it's settings to not > be saved. Unless things have changed very recently, VDR doesn't save channels.conf on shutdown. It only saves it a) Immediately after user manually modifies channels via VDR b) 10 minutes after automatic channel update I've been hit with this many times as well, so I'd suggest to change VDR so that it saves automatic channel updates on exit as well. Suggested patch attached (only compile-tested, so actual testing is needed). Index: vdr-1.7.26/vdr.c =================================================================== --- vdr-1.7.26/vdr.c +++ vdr-1.7.26/vdr.c 2012-05-27 14:32:06.886993810 +0300 @@ -1299,6 +1299,10 @@ Setup.CurrentVolume = cDevice::CurrentVolume(); Setup.Save(); } + if (Channels.Modified()) { + // Save any automatic channels.conf modifications + Channels.Save(); + } cDevice::Shutdown(); EpgHandlers.Clear(); PluginManager.Shutdown(true);