vdr-iptv-0.0.5 + vdr-xine audio problem

Message ID 4F6AB5F748%linux@youmustbejoking.demon.co.uk
State New
Headers

Commit Message

Darren Salt Jan. 22, 2008, 6:42 p.m. UTC
  I demand that Antti Seppälä may or may not have written...

> Jouni Karvo wrote:
>> I really have no idea of which settings to try next.  Configuring 
>> xine-ui is not really an easy thing.

> Few people have reported audio problems in xine-lib version 1.1.9.

> The setting audio.synchronization.slow_fast_audio (discussed here
> http://www.linuxtv.org/pipermail/vdr/2008-January/015210.html) might help.

> Also changing audio.synchronization.av_sync_method and/or
> audio.synchronization.resample_mode may have an effect on your audio
> problems.

This patch should fix it. If you find that it works, report back and I'll
make sure that it gets committed.
  

Comments

Ville Skyttä Jan. 23, 2008, 5 p.m. UTC | #1
On Tuesday 22 January 2008, Darren Salt wrote:
> I demand that Antti Seppälä may or may not have written...
>
> > Jouni Karvo wrote:
> >> I really have no idea of which settings to try next.  Configuring
> >> xine-ui is not really an easy thing.
> >
> > Few people have reported audio problems in xine-lib version 1.1.9.
> >
> > The setting audio.synchronization.slow_fast_audio (discussed here
> > http://www.linuxtv.org/pipermail/vdr/2008-January/015210.html) might
> > help.
> >
> > Also changing audio.synchronization.av_sync_method and/or
> > audio.synchronization.resample_mode may have an effect on your audio
> > problems.
>
> This patch should fix it. If you find that it works, report back and I'll
> make sure that it gets committed.

I'm not using any xine related functionality with VDR, but I tried the patch 
below.

Unfortunately it makes things even worse for me with Amarok than vanilla 
1.1.9.1 - with vanilla 1.1.9.1 audio was ok until I tried to play a radio 
stream, then nothing until restart.  With this patch, the same breakage 
appears to occur much more frequently, looks like audio gets lost when trying 
to play a 2nd song after a fresh restart (quickly tried in a session where I 
first played a MP3 (success), then tried a FLAC (fails), and everything else 
fails after that, no need to even involve radio streams).

Reverting this changeset fixes these problems for me.
http://hg.debian.org/hg/xine-lib/xine-lib?cmd=changeset;node=1867fae812913d2ad953fb91359f886620bf1cf1;style=gitweb


> diff --git a/src/xine-engine/audio_out.c b/src/xine-engine/audio_out.c
> --- a/src/xine-engine/audio_out.c
> +++ b/src/xine-engine/audio_out.c
> @@ -1619,6 +1619,7 @@ static void ao_close(xine_audio_port_t *
>        }
>        /* make sure there are no more buffers on queue */
>        fifo_wait_empty(this->out_fifo);
> +      ao_set_property(this_gen, AO_PROP_DISCARD_BUFFERS, 0);
>      }
>
>      pthread_mutex_lock( &this->driver_lock );
  
Jouni Karvo Jan. 24, 2008, 6:04 p.m. UTC | #2
Ville Skyttä kirjoitti:
> On Tuesday 22 January 2008, Darren Salt wrote:
>> This patch should fix it. If you find that it works, report back and I'll
>> make sure that it gets committed.
> 
> I'm not using any xine related functionality with VDR, but I tried the patch 
> below.
> 
> Unfortunately it makes things even worse for me with Amarok than vanilla 
> 1.1.9.1 - with vanilla 1.1.9.1 audio was ok until I tried to play a radio 

With this patch, all error messages are gone (except for this)

video_out: thread created
audio_out: thread created
xine_interface: unknown or deprecated stream param 10 set
xine_stream_new
xine_interface: unknown or deprecated stream param 10 set
xine_stream_new
xine_interface: unknown or deprecated stream param 10 set

...but so is audio.  With the patch, all normal TV channels also are 
dead quiet.

yours,	
		Jouni
  
Darren Salt Jan. 26, 2008, 3:29 p.m. UTC | #3
I demand that Jouni Karvo may or may not have written...

> Ville Skyttä kirjoitti:
>> On Tuesday 22 January 2008, Darren Salt wrote:
>>> This patch should fix it. If you find that it works, report back and I'll
>>> make sure that it gets committed.
>> I'm not using any xine related functionality with VDR, but I tried the
>> patch below.
>> Unfortunately it makes things even worse for me with Amarok than vanilla 
>> 1.1.9.1 - with vanilla 1.1.9.1 audio was ok until I tried to play a radio 

> With this patch, all error messages are gone (except for this)

> video_out: thread created
> audio_out: thread created
> xine_interface: unknown or deprecated stream param 10 set
> xine_stream_new
[etc.]

> ...but so is audio.  With the patch, all normal TV channels also are dead
> quiet.

Current hg should be fine. Anybody who wants to test it doesn't have very
long to do so ;-)
  

Patch

diff --git a/src/xine-engine/audio_out.c b/src/xine-engine/audio_out.c
--- a/src/xine-engine/audio_out.c
+++ b/src/xine-engine/audio_out.c
@@ -1619,6 +1619,7 @@  static void ao_close(xine_audio_port_t *
       }
       /* make sure there are no more buffers on queue */
       fifo_wait_empty(this->out_fifo);
+      ao_set_property(this_gen, AO_PROP_DISCARD_BUFFERS, 0);
     }
 
     pthread_mutex_lock( &this->driver_lock );