Message ID | 4F6AB5F748%linux@youmustbejoking.demon.co.uk |
---|---|
State | New |
Headers |
Received: from anchor-post-34.mail.demon.net ([194.217.242.92]) by www.linuxtv.org with esmtp (Exim 4.63) (envelope-from <linux@youmustbejoking.demon.co.uk>) id 1JHOCm-000511-Cw for vdr@linuxtv.org; Tue, 22 Jan 2008 19:50:40 +0100 Received: from youmustbejoking.demon.co.uk ([80.176.152.238] helo=pentagram.youmustbejoking.demon.co.uk) by anchor-post-34.mail.demon.net with esmtp (Exim 4.67) id 1JHOCl-0001Ch-DD for vdr@linuxtv.org; Tue, 22 Jan 2008 18:50:39 +0000 Received: from [192.168.0.5] (helo=flibble.youmustbejoking.demon.co.uk) by pentagram.youmustbejoking.demon.co.uk with esmtp (Exim 4.63) (envelope-from <linux@youmustbejoking.demon.co.uk>) id 1JHOCY-00047t-4i for vdr@linuxtv.org; Tue, 22 Jan 2008 18:50:38 +0000 Date: Tue, 22 Jan 2008 18:42:46 +0000 From: Darren Salt <linux@youmustbejoking.demon.co.uk> To: vdr@linuxtv.org Message-ID: <4F6AB5F748%linux@youmustbejoking.demon.co.uk> In-Reply-To: <4794DF33.7010707@niksula.hut.fi> References: <47250672.8090009@niksula.hut.fi> <47921373.2010401@iki.fi> <ACBE1D3C2292D74B80583E2C584394A709E70B9E@COLORADO.medewerker.fontys.local> <479237E4.2060605@iki.fi> <47924ECC.80101@niksula.hut.fi> <47925B92.30004@iki.fi> <479310D9.6010505@niksula.hut.fi> <4793A7EE.6040200@iki.fi> <4794DF33.7010707@niksula.hut.fi> Mail-Followup-To: vdr@linuxtv.org User-Agent: Gemini/2.29a (Qt/3.3.7) (Linux-x86_64) X-SDate: Tue, 5257 Sep 1993 18:42:46 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 192.168.0.5 X-SA-Exim-Mail-From: linux@youmustbejoking.demon.co.uk X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on pentagram.youmustbejoking.demon.co.uk X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.2.3 X-SA-Exim-Version: 4.2.1 (built Tue, 09 Jan 2007 17:23:22 +0000) X-SA-Exim-Scanned: Yes (on pentagram.youmustbejoking.demon.co.uk) Subject: Re: [vdr] vdr-iptv-0.0.5 + vdr-xine audio problem X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.9 Precedence: list Reply-To: VDR Mailing List <vdr@linuxtv.org> List-Id: VDR Mailing List <vdr.linuxtv.org> List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=unsubscribe> List-Archive: <http://www.linuxtv.org/pipermail/vdr> List-Post: <mailto:vdr@linuxtv.org> List-Help: <mailto:vdr-request@linuxtv.org?subject=help> List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=subscribe> X-List-Received-Date: Tue, 22 Jan 2008 18:50:40 -0000 Status: O X-Status: X-Keywords: X-UID: 15239 |
Commit Message
Darren Salt
Jan. 22, 2008, 6:42 p.m. UTC
I demand that Antti Seppälä may or may not have written... > Jouni Karvo wrote: >> I really have no idea of which settings to try next. Configuring >> xine-ui is not really an easy thing. > Few people have reported audio problems in xine-lib version 1.1.9. > The setting audio.synchronization.slow_fast_audio (discussed here > http://www.linuxtv.org/pipermail/vdr/2008-January/015210.html) might help. > Also changing audio.synchronization.av_sync_method and/or > audio.synchronization.resample_mode may have an effect on your audio > problems. This patch should fix it. If you find that it works, report back and I'll make sure that it gets committed.
Comments
On Tuesday 22 January 2008, Darren Salt wrote: > I demand that Antti Seppälä may or may not have written... > > > Jouni Karvo wrote: > >> I really have no idea of which settings to try next. Configuring > >> xine-ui is not really an easy thing. > > > > Few people have reported audio problems in xine-lib version 1.1.9. > > > > The setting audio.synchronization.slow_fast_audio (discussed here > > http://www.linuxtv.org/pipermail/vdr/2008-January/015210.html) might > > help. > > > > Also changing audio.synchronization.av_sync_method and/or > > audio.synchronization.resample_mode may have an effect on your audio > > problems. > > This patch should fix it. If you find that it works, report back and I'll > make sure that it gets committed. I'm not using any xine related functionality with VDR, but I tried the patch below. Unfortunately it makes things even worse for me with Amarok than vanilla 1.1.9.1 - with vanilla 1.1.9.1 audio was ok until I tried to play a radio stream, then nothing until restart. With this patch, the same breakage appears to occur much more frequently, looks like audio gets lost when trying to play a 2nd song after a fresh restart (quickly tried in a session where I first played a MP3 (success), then tried a FLAC (fails), and everything else fails after that, no need to even involve radio streams). Reverting this changeset fixes these problems for me. http://hg.debian.org/hg/xine-lib/xine-lib?cmd=changeset;node=1867fae812913d2ad953fb91359f886620bf1cf1;style=gitweb > diff --git a/src/xine-engine/audio_out.c b/src/xine-engine/audio_out.c > --- a/src/xine-engine/audio_out.c > +++ b/src/xine-engine/audio_out.c > @@ -1619,6 +1619,7 @@ static void ao_close(xine_audio_port_t * > } > /* make sure there are no more buffers on queue */ > fifo_wait_empty(this->out_fifo); > + ao_set_property(this_gen, AO_PROP_DISCARD_BUFFERS, 0); > } > > pthread_mutex_lock( &this->driver_lock );
Ville Skyttä kirjoitti: > On Tuesday 22 January 2008, Darren Salt wrote: >> This patch should fix it. If you find that it works, report back and I'll >> make sure that it gets committed. > > I'm not using any xine related functionality with VDR, but I tried the patch > below. > > Unfortunately it makes things even worse for me with Amarok than vanilla > 1.1.9.1 - with vanilla 1.1.9.1 audio was ok until I tried to play a radio With this patch, all error messages are gone (except for this) video_out: thread created audio_out: thread created xine_interface: unknown or deprecated stream param 10 set xine_stream_new xine_interface: unknown or deprecated stream param 10 set xine_stream_new xine_interface: unknown or deprecated stream param 10 set ...but so is audio. With the patch, all normal TV channels also are dead quiet. yours, Jouni
I demand that Jouni Karvo may or may not have written... > Ville Skyttä kirjoitti: >> On Tuesday 22 January 2008, Darren Salt wrote: >>> This patch should fix it. If you find that it works, report back and I'll >>> make sure that it gets committed. >> I'm not using any xine related functionality with VDR, but I tried the >> patch below. >> Unfortunately it makes things even worse for me with Amarok than vanilla >> 1.1.9.1 - with vanilla 1.1.9.1 audio was ok until I tried to play a radio > With this patch, all error messages are gone (except for this) > video_out: thread created > audio_out: thread created > xine_interface: unknown or deprecated stream param 10 set > xine_stream_new [etc.] > ...but so is audio. With the patch, all normal TV channels also are dead > quiet. Current hg should be fine. Anybody who wants to test it doesn't have very long to do so ;-)
diff --git a/src/xine-engine/audio_out.c b/src/xine-engine/audio_out.c --- a/src/xine-engine/audio_out.c +++ b/src/xine-engine/audio_out.c @@ -1619,6 +1619,7 @@ static void ao_close(xine_audio_port_t * } /* make sure there are no more buffers on queue */ fifo_wait_empty(this->out_fifo); + ao_set_property(this_gen, AO_PROP_DISCARD_BUFFERS, 0); } pthread_mutex_lock( &this->driver_lock );