Message ID | 4E6A4EDE.6000803@ventoso.org |
---|---|
State | New |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <luca@ventoso.org>) id 1R252Z-0005Oo-83 for vdr@linuxtv.org; Fri, 09 Sep 2011 19:39:24 +0200 X-tubIT-Incoming-IP: 188.165.38.232 Received: from 15.mo1.mail-out.ovh.net ([188.165.38.232] helo=mo1.mail-out.ovh.net) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp for <vdr@linuxtv.org> id 1R252Y-00046k-EZ; Fri, 09 Sep 2011 19:38:58 +0200 Received: from mail645.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo1.mail-out.ovh.net (Postfix) with SMTP id 3BEE81008DE6 for <vdr@linuxtv.org>; Fri, 9 Sep 2011 19:39:28 +0200 (CEST) Received: from b0.ovh.net (HELO queueout) (213.186.33.50) by b0.ovh.net with SMTP; 9 Sep 2011 19:42:51 +0200 Received: from 4.pool85-52-13.dynamic.orange.es (HELO ventoso.org) (postmaster%ventoso.org@85.52.13.4) by ns0.ovh.net with SMTP; 9 Sep 2011 19:42:50 +0200 Received: from [192.168.10.28] (unknown [192.168.10.28]) by ventoso.org (Postfix) with ESMTP id 63049C26BD5 for <vdr@linuxtv.org>; Fri, 9 Sep 2011 19:38:52 +0200 (CEST) Message-ID: <4E6A4EDE.6000803@ventoso.org> Date: Fri, 09 Sep 2011 19:37:34 +0200 From: Luca Olivetti <luca@ventoso.org> User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110501 Mandriva/3.1.10-0.1mdv2010.0 (2010.0) Thunderbird/3.1.10 MIME-Version: 1.0 To: VDR Mailing List <vdr@linuxtv.org> X-Ovh-Mailout: 178.32.228.1 (mo1.mail-out.ovh.net) References: <4E63804E.8070109@tvdr.de> <4E638935.3000006@ventoso.org> <4E638E37.7030503@tvdr.de> <4E6397C5.3020207@ventoso.org> <4E63BB48.6010807@ventoso.org> <4E63E82E.3080105@tvdr.de> <4E63F360.8040500@ventoso.org> <4E63F6CB.9040905@ventoso.org> <4E64F589.8070405@tvdr.de> <4E650A5C.30404@ventoso.org> <4E650C71.3070709@ventoso.org> <4E6A28B1.6030409@tvdr.de> In-Reply-To: <4E6A28B1.6030409@tvdr.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 5771925873577986397 X-Ovh-Remote: 85.52.13.4 (4.pool85-52-13.dynamic.orange.es) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-Spam-Check: DONE|U 0.5/N X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeftddrvdehucetggdotefuucfrrhhofhhilhgvmecuqfggjfenuceurghilhhouhhtmecufedttdenuc X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2011.9.9.172414 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, NO_URI_FOUND 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __USER_AGENT 0' X-LSpam-Score: -4.2 (----) X-LSpam-Report: No, score=-4.2 required=5.0 tests=BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3 autolearn=ham Subject: Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21 X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: VDR Mailing List <vdr@linuxtv.org> List-Id: VDR Mailing List <vdr.linuxtv.org> List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/options/vdr>, <mailto:vdr-request@linuxtv.org?subject=unsubscribe> List-Archive: <http://www.linuxtv.org/pipermail/vdr> List-Post: <mailto:vdr@linuxtv.org> List-Help: <mailto:vdr-request@linuxtv.org?subject=help> List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=subscribe> X-List-Received-Date: Fri, 09 Sep 2011 17:39:24 -0000 Status: O X-Status: X-Keywords: X-UID: 25125 |
Commit Message
Luca Olivetti
Sept. 9, 2011, 5:37 p.m. UTC
Al 09/09/11 16:54, En/na Klaus Schmidinger ha escrit: >> I think this is still needed for output plugins that don't implement the method, >> so that they should at least work as before this modification. > > Can you please point out exactly which modificaton you are > referring to? I'm referring to the modification that changed GetVideoSize from being purely informational to being used for something. In case you're interested, with the patch below, output plugins that don't implement GetVideoSize will have the subtitles working as before. I know that the proper fix is to implement GetVideoSize and GetOsdSize (I actually did afterwards), but at least it doesn't break what was working before. Bye
Comments
On 09.09.2011 19:37, Luca Olivetti wrote: > Al 09/09/11 16:54, En/na Klaus Schmidinger ha escrit: > >>> I think this is still needed for output plugins that don't implement the method, >>> so that they should at least work as before this modification. >> >> Can you please point out exactly which modificaton you are >> referring to? > > I'm referring to the modification that changed GetVideoSize > from being purely informational to being used for something. > In case you're interested, with the patch below, output plugins that > don't implement GetVideoSize will have the subtitles working as > before. I know that the proper fix is to implement GetVideoSize > and GetOsdSize (I actually did afterwards), but at least it doesn't > break what was working before. > > --- dvbsubtitle.c.orig 2011-09-04 19:11:12.426133000 +0200 > +++ dvbsubtitle.c 2011-09-09 19:27:46.064725000 +0200 > @@ -887,7 +887,7 @@ > double VideoAspect; > cDevice::PrimaryDevice()->GetOsdSize(OsdWidth, OsdHeight, OsdAspect); > cDevice::PrimaryDevice()->GetVideoSize(VideoWidth, VideoHeight, VideoAspect); > - if (OsdWidth == displayWidth&& OsdHeight == displayHeight) { > + if ((OsdWidth == displayWidth&& OsdHeight == displayHeight) || VideoWidth == 0) { > osdFactorX = osdFactorY = 1.0; > osdDeltaX = osdDeltaY = 0; > } You're right - adopted for 1.7.22. Klaus
--- dvbsubtitle.c.orig 2011-09-04 19:11:12.426133000 +0200 +++ dvbsubtitle.c 2011-09-09 19:27:46.064725000 +0200 @@ -887,7 +887,7 @@ double VideoAspect; cDevice::PrimaryDevice()->GetOsdSize(OsdWidth, OsdHeight, OsdAspect); cDevice::PrimaryDevice()->GetVideoSize(VideoWidth, VideoHeight, VideoAspect); - if (OsdWidth == displayWidth && OsdHeight == displayHeight) { + if ((OsdWidth == displayWidth && OsdHeight == displayHeight) || VideoWidth == 0) { osdFactorX = osdFactorY = 1.0; osdDeltaX = osdDeltaY = 0; }