diff mbox

xineliboutput subtitle crop

Message ID 4D83769A.6050504@centrum.cz
State New
Headers

Commit Message

jdobry@centrum.cz March 18, 2011, 3:13 p.m. UTC 
  Hello,

On vdr 1.7.17 I have problem with xineliboutput and subtitles. It's 
oversized and cropped.
Problem is probably incompatibility to change OSD layer size on 1.7.17

Here is my hotfix. I am not sure, if it is correct because I don't know 
vdr/xineliboutput internals.  But it siply works for me.

Jiri
PS: many thanks for nice piece of SW, specially thanks to Klaus.


      m_Device->GetOsdSize(W, H, Aspect);

Comments

Petri Hintukainen March 18, 2011, 5:11 p.m. UTC | #1 
pe, 2011-03-18 kello 16:13 +0100, jdobry@centrum.cz kirjoitti:
> Hello,
> 
> On vdr 1.7.17 I have problem with xineliboutput and subtitles. It's 
> oversized and cropped.
> Problem is probably incompatibility to change OSD layer size on 1.7.17
> 
> Here is my hotfix. I am not sure, if it is correct because I don't know 
> vdr/xineliboutput internals.  But it siply works for me.

Looks correct, at least for DVB subtitles. Did you test only with DVB
subtitles or also with teletext subtitles ?

> Jiri
> PS: many thanks for nice piece of SW, specially thanks to Klaus.
> 
> 
> --- osd.c.old    2011-03-18 15:55:32.681879469 +0100
> +++ osd.c    2011-03-18 16:02:54.111874506 +0100
> @@ -393,10 +393,13 @@
> 
>   #if VDRVERSNUM >= 10708
> 
> +#if VDRVERSNUM < 10717
>     if (xc.osd_spu_scaling && (m_Layer == OSD_LEVEL_SUBTITLES || m_Layer 
> == OSD_LEVEL_TTXTSUBS)) {
>       m_ExtentWidth  = 720;
>       m_ExtentHeight = 576;
> -  } else {
> +  } else
> +#endif
> +  {
>       double Aspect;
>       int    W, H;
>       m_Device->GetOsdSize(W, H, Aspect);
> 
> 
> _______________________________________________
> vdr mailing list
> vdr@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Mika Laitio March 19, 2011, 7:54 a.m. UTC | #2 
> Looks correct, at least for DVB subtitles. Did you test only with DVB
> subtitles or also with teletext subtitles ?

How can I see whether the channel is sending teletext or dvb subtitles?

MIka
diff mbox

Patch

--- osd.c.old    2011-03-18 15:55:32.681879469 +0100
+++ osd.c    2011-03-18 16:02:54.111874506 +0100
@@ -393,10 +393,13 @@ 

  #if VDRVERSNUM >= 10708

+#if VDRVERSNUM < 10717
    if (xc.osd_spu_scaling && (m_Layer == OSD_LEVEL_SUBTITLES || m_Layer 
== OSD_LEVEL_TTXTSUBS)) {
      m_ExtentWidth  = 720;
      m_ExtentHeight = 576;
-  } else {
+  } else
+#endif
+  {
      double Aspect;
      int    W, H;