From patchwork Mon Feb 14 17:46:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anssi Hannula X-Patchwork-Id: 12863 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.69) (envelope-from ) id 1Pp2V7-0003NW-9L for vdr@linuxtv.org; Mon, 14 Feb 2011 18:46:18 +0100 X-tubIT-Incoming-IP: 83.102.40.135 Received: from sypressi.dnainternet.net ([83.102.40.135]) by mail.tu-berlin.de (exim-4.74/mailfrontend-b) with esmtp for id 1Pp2V6-0000WR-99; Mon, 14 Feb 2011 18:46:17 +0100 Received: from localhost (localhost [127.0.0.1]) by sypressi.dnainternet.net (Postfix) with ESMTP id E9756C6BBE for ; Mon, 14 Feb 2011 19:46:15 +0200 (EET) X-Virus-Scanned: DNA Postiturva at dnainternet.net X-Spam-Flag: NO X-Spam-Score: -1.44 X-Spam-Level: X-Spam-Status: No, score=-1.44 tagged_above=-9999 required=6 tests=[ALL_TRUSTED=-1.44] Received: from sypressi.dnainternet.net ([83.102.40.135]) by localhost (sypressi.dnainternet.net [127.0.0.1]) (amavisd-new, port 10041) with ESMTP id ZfdWETwmL2tW for ; Mon, 14 Feb 2011 19:46:15 +0200 (EET) Received: from omenapuu.dnainternet.net (omenapuu.dnainternet.net [83.102.40.212]) by sypressi.dnainternet.net (Postfix) with ESMTP id C1F78C6E57 for ; Mon, 14 Feb 2011 19:46:15 +0200 (EET) Received: from mail.onse.fi (host-109-204-162-131.tp-fne.tampereenpuhelin.net [109.204.162.131]) by omenapuu.dnainternet.net (Postfix) with ESMTP id B3ADC2BAF3 for ; Mon, 14 Feb 2011 19:46:14 +0200 (EET) Received: from sigma.onse.fi (sigma [10.0.0.8]) by mail.onse.fi (Postfix) with ESMTP id 39B7E2081C5 for ; Mon, 14 Feb 2011 19:46:14 +0200 (EET) Message-ID: <4D596A65.80907@iki.fi> Date: Mon, 14 Feb 2011 19:46:13 +0200 From: Anssi Hannula User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101214 Mandriva/3.1.7-1mdv2011.0 (2011.0) Thunderbird/3.1.7 MIME-Version: 1.0 To: vdr@linuxtv.org X-Enigmail-Version: 1.1.2 X-PMX-Version: 5.5.4.371499, Antispam-Engine: 2.7.1.369594, Antispam-Data: 2011.2.14.173319 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MIME_TEXT_ONLY_MP_MIXED 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1400_1499 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, __BAT_BOUNDARY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_MIXED 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __USER_AGENT 0' X-LSpam-Score: -3.6 (---) X-LSpam-Report: No, score=-3.6 required=5.0 tests=BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1 autolearn=ham Subject: [vdr] [PATCH] do not flag all audio tracks as "clean effects" in remux.c X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Feb 2011 17:46:18 -0000 Status: O X-Status: X-Keywords: X-UID: 24438 Hi! cPatPmtGenerator::MakeLanguageDescriptor in remux.c incorrectly flags all audio tracks as "clean effects", which means a track without any voice or language. The proper solution would be to preserve the audio_type of the original stream (which may indicate e.g. a visual-impaired audio track, as used for e.g. automated subtitles-to-speech audio tracks by YLE here in Finland). The attached patch is a simpler stop-gap measure that simply always sets the audio_type to the value of 0x00 which means a "normal" track, which is obviously better than marking the track as a special "clean effects" one. --- vdr-1.7.16/remux.c 2010-06-05 16:32:15.000000000 +0300 +++ vdr-1.7.16-m/remux.c 2011-02-14 19:37:58.575610709 +0200 @@ -225,7 +225,7 @@ Target[i++] = *Language++; Target[i++] = *Language++; Target[i++] = *Language++; - Target[i++] = 0x01; // audio type + Target[i++] = 0x00; // audio type Target[Length] += 0x04; // length if (*Language == '+') Language++;