Message ID | 4BED5A90.2040703@tvdr.de |
---|---|
State | New |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.69) (envelope-from <Klaus.Schmidinger@tvdr.de>) id 1OCve3-0007nH-Ty for vdr@linuxtv.org; Fri, 14 May 2010 16:13:44 +0200 X-tubIT-Incoming-IP: 188.40.50.18 Received: from racoon.tvdr.de ([188.40.50.18]) by mail.tu-berlin.de (exim-4.69/mailfrontend-b) with esmtps [TLSv1:AES256-SHA:256] for <vdr@linuxtv.org> id 1OCve3-00071G-7q; Fri, 14 May 2010 16:13:43 +0200 Received: from whale.tvdr.de (whale.tvdr.de [192.168.100.6]) by racoon.tvdr.de (8.14.3/8.14.3) with ESMTP id o4EEDfSf027288 for <vdr@linuxtv.org>; Fri, 14 May 2010 16:13:42 +0200 Received: from [192.168.100.10] (hawk.tvdr.de [192.168.100.10]) by whale.tvdr.de (8.14.3/8.14.3) with ESMTP id o4EEDaYQ028913 for <vdr@linuxtv.org>; Fri, 14 May 2010 16:13:36 +0200 Message-ID: <4BED5A90.2040703@tvdr.de> Date: Fri, 14 May 2010 16:13:36 +0200 From: Klaus Schmidinger <Klaus.Schmidinger@tvdr.de> User-Agent: Thunderbird 2.0.0.24 (X11/20100302) MIME-Version: 1.0 To: vdr@linuxtv.org References: <756524.23736.qm@web23201.mail.ird.yahoo.com> In-Reply-To: <756524.23736.qm@web23201.mail.ird.yahoo.com> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (racoon.tvdr.de [188.40.50.18]); Fri, 14 May 2010 16:13:42 +0200 (CEST) X-tubIT-Score: 0.0 () X-PMX-Version: 5.5.4.371499, Antispam-Engine: 2.7.1.369594, Antispam-Data: 2010.5.14.140315 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1500_1599 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, TO_NO_NAME 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_MEDIA_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_MAILTO 0, __URI_NO_PATH 0, __URI_NO_WWW 0, __USER_AGENT 0' X-LSpam-Score: -3.4 (---) X-LSpam-Report: No, score=-3.4 required=5.0 tests=AWL=0.226, BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1 autolearn=ham Subject: Re: [vdr] vdr and aac support X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: VDR Mailing List <vdr@linuxtv.org> List-Id: VDR Mailing List <vdr.linuxtv.org> List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/options/vdr>, <mailto:vdr-request@linuxtv.org?subject=unsubscribe> List-Archive: <http://www.linuxtv.org/pipermail/vdr> List-Post: <mailto:vdr@linuxtv.org> List-Help: <mailto:vdr-request@linuxtv.org?subject=help> List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=subscribe> X-List-Received-Date: Fri, 14 May 2010 14:13:44 -0000 Status: O X-Status: X-Keywords: X-UID: 22920 |
Commit Message
Klaus Schmidinger
May 14, 2010, 2:13 p.m. UTC
On 07.05.2010 09:53, Newsy Paper wrote: > Hi! > > there are some channels using aac for audio. I.e. SABC1 at 23.5°East 10758 V 22000 8/9 DVB-S2 > Seems vdr doesn't support aac as no pid is entered neither for apid nor for ddpid. I think xine should support acc or doesn't it? So it should be no big deal do extend vdr to support aac. Please try this and see if it makes any difference: Klaus
Comments
thx Klaus for your patch, but seems like there's something missing. Perhaps in remux.c? DDpid and Apid are both 0 If I enter aac pid in ddpid field it's set back to 0 again. kind regards Newspaperman --- Klaus Schmidinger <Klaus.Schmidinger@tvdr.de> schrieb am Fr, 14.5.2010: > Von: Klaus Schmidinger <Klaus.Schmidinger@tvdr.de> > Betreff: Re: [vdr] vdr and aac support > An: vdr@linuxtv.org > Datum: Freitag, 14. Mai, 2010 16:13 Uhr > On 07.05.2010 09:53, Newsy Paper > wrote: > > Hi! > > > > there are some channels using aac for audio. I.e. > SABC1 at 23.5°East 10758 V 22000 8/9 DVB-S2 > > Seems vdr doesn't support aac as no pid is entered > neither for apid nor for ddpid. I think xine should support > acc or doesn't it? So it should be no big deal do extend vdr > to support aac. > > Please try this and see if it makes any difference: > > --- pat.c 2010/03/27 > 15:17:46 2.9 > +++ pat.c 2010/05/14 > 14:12:31 > @@ -401,6 +401,7 @@ > > switch > (d->getDescriptorTag()) { > > case > SI::AC3DescriptorTag: > > case > SI::EnhancedAC3DescriptorTag: > + > case > SI::AACDescriptorTag: > > > dpid = esPid; > > > ProcessCaDescriptors = true; > > > break; > > --- eit.c 2010/01/08 > 15:17:09 2.11 > +++ eit.c 2010/05/14 > 14:06:55 > @@ -257,7 +257,7 @@ > > SI::ComponentDescriptor *cd = > (SI::ComponentDescriptor *)d; > > uchar Stream = cd->getStreamContent(); > > uchar Type = cd->getComponentType(); > - > if (1 <= Stream && Stream <= > 4 && Type != 0) { // 1=video, 2=audio, 3=subtitles, > 4=AC3 > + > if (1 <= Stream && Stream <= > 6 && Type != 0) { // 1=MPEG2-video, 2=MPEG1-audio, > 3=subtitles, 4=AC3-audio, 5=H.264-video, 6=HEAAC-audio > > if (!Components) > > Components = new cComponents; > > char buffer[Utf8BufSize(256)]; > > > Klaus > > _______________________________________________ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr >
On Fri, 14 May 2010 16:13:36 +0200 Klaus Schmidinger <Klaus.Schmidinger@tvdr.de> wrote: > On 07.05.2010 09:53, Newsy Paper wrote: > > Hi! > > > > there are some channels using aac for audio. I.e. SABC1 at > > 23.5°East 10758 V 22000 8/9 DVB-S2 Seems vdr doesn't support aac as > > no pid is entered neither for apid nor for ddpid. I think xine > > should support acc or doesn't it? So it should be no big deal do > > extend vdr to support aac. > > Please try this and see if it makes any difference: > > --- pat.c 2010/03/27 15:17:46 2.9 > +++ pat.c 2010/05/14 14:12:31 > @@ -401,6 +401,7 @@ > switch (d->getDescriptorTag()) { > case SI::AC3DescriptorTag: > case SI::EnhancedAC3DescriptorTag: > + case SI::AACDescriptorTag: > dpid = esPid; > ProcessCaDescriptors = true; > break; > > --- eit.c 2010/01/08 15:17:09 2.11 > +++ eit.c 2010/05/14 14:06:55 > @@ -257,7 +257,7 @@ > SI::ComponentDescriptor *cd = > (SI::ComponentDescriptor *)d; uchar Stream = cd->getStreamContent(); > uchar Type = cd->getComponentType(); > - if (1 <= Stream && Stream <= 4 && Type != 0) { // > 1=video, 2=audio, 3=subtitles, 4=AC3 > + if (1 <= Stream && Stream <= 6 && Type != 0) { // > 1=MPEG2-video, 2=MPEG1-audio, 3=subtitles, 4=AC3-audio, > 5=H.264-video, 6=HEAAC-audio if (!Components) Components = new > cComponents; char buffer[Utf8BufSize(256)]; > The second change marks at least the HD Recordings as such - usefull for applications needing to know this w/o analyzing files :) Thanks !
hello everybody, in my case of he-aac streamtype 0x11 coming in, if you want to record or listen to xineliboutput i have to change in remux.c and pat.c in the following lines, pat.c case 0x04: / / STREAMTYPE_13818_AUDIO + case 0x11: / / ISO/IEC 14496-3 Audio with LATM transport syntax thus adds the audio pid correctly remux.c for (int n = 0; Channel->Apid(n); n++) { - i += MakeStream(buf + i, 0x04, Channel->Apid(n)); + i += MakeStream(buf + i, 0x11, Channel->Apid(n)); const char *Alang = Channel->Alang(n); case 0x04: / / STREAMTYPE_13818_AUDIO + case 0x11: / / ISO/IEC 14496-3 Audio with LATM transport syntax but this way I can not hear sound from other channels, only the channels with streamtype 0x11 is there any way to identify the audio streamtype in this line so that the MakeStream (buf + i, streamaudiotype, Channel-> APID (n)); Excuse my English Best regards 2010/5/15 Newsy Paper <newspaperman_germany@yahoo.com>: > thx Klaus for your patch, but seems like there's something missing. Perhaps in remux.c? > > DDpid and Apid are both 0 > If I enter aac pid in ddpid field it's set back to 0 again. > > kind regards > > Newspaperman > > --- Klaus Schmidinger <Klaus.Schmidinger@tvdr.de> schrieb am Fr, 14.5.2010: > >> Von: Klaus Schmidinger <Klaus.Schmidinger@tvdr.de> >> Betreff: Re: [vdr] vdr and aac support >> An: vdr@linuxtv.org >> Datum: Freitag, 14. Mai, 2010 16:13 Uhr >> On 07.05.2010 09:53, Newsy Paper >> wrote: >> > Hi! >> > >> > there are some channels using aac for audio. I.e. >> SABC1 at 23.5°East 10758 V 22000 8/9 DVB-S2 >> > Seems vdr doesn't support aac as no pid is entered >> neither for apid nor for ddpid. I think xine should support >> acc or doesn't it? So it should be no big deal do extend vdr >> to support aac. >> >> Please try this and see if it makes any difference: >> >> --- pat.c 2010/03/27 >> 15:17:46 2.9 >> +++ pat.c 2010/05/14 >> 14:12:31 >> @@ -401,6 +401,7 @@ >> >> switch >> (d->getDescriptorTag()) { >> >> case >> SI::AC3DescriptorTag: >> >> case >> SI::EnhancedAC3DescriptorTag: >> + >> case >> SI::AACDescriptorTag: >> >> >> dpid = esPid; >> >> >> ProcessCaDescriptors = true; >> >> >> break; >> >> --- eit.c 2010/01/08 >> 15:17:09 2.11 >> +++ eit.c 2010/05/14 >> 14:06:55 >> @@ -257,7 +257,7 @@ >> >> SI::ComponentDescriptor *cd = >> (SI::ComponentDescriptor *)d; >> >> uchar Stream = cd->getStreamContent(); >> >> uchar Type = cd->getComponentType(); >> - >> if (1 <= Stream && Stream <= >> 4 && Type != 0) { // 1=video, 2=audio, 3=subtitles, >> 4=AC3 >> + >> if (1 <= Stream && Stream <= >> 6 && Type != 0) { // 1=MPEG2-video, 2=MPEG1-audio, >> 3=subtitles, 4=AC3-audio, 5=H.264-video, 6=HEAAC-audio >> >> if (!Components) >> >> Components = new cComponents; >> >> char buffer[Utf8BufSize(256)]; >> >> >> Klaus >> >> _______________________________________________ >> vdr mailing list >> vdr@linuxtv.org >> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr >> > > > > _______________________________________________ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr >
hi Luis, seems like an ugly hack. Channel I'm receiving here has: Stream_type: 15 (0x0f) [= ISO/IEC 13818-7 Audio with ADTS transport sytax] kind regards Newspaperman --- Luis Fernandes <telping@gmail.com> schrieb am Sa, 15.5.2010: > Von: Luis Fernandes <telping@gmail.com> > Betreff: Re: [vdr] vdr and aac support > An: "VDR Mailing List" <vdr@linuxtv.org> > Datum: Samstag, 15. Mai, 2010 17:40 Uhr > hello everybody, in my case of he-aac > streamtype 0x11 coming in, if > you want to record or listen to xineliboutput i have to > change in > remux.c and pat.c in the following lines, > > pat.c > > case 0x04: / / STREAMTYPE_13818_AUDIO > + case 0x11: / / ISO/IEC 14496-3 Audio with LATM transport > syntax > > > thus adds the audio pid correctly > > remux.c > > for (int n = 0; Channel->Apid(n); n++) { > - i += MakeStream(buf > + i, 0x04, Channel->Apid(n)); > + i += MakeStream(buf + i, > 0x11, Channel->Apid(n)); > const char *Alang = > Channel->Alang(n); > > case 0x04: / / STREAMTYPE_13818_AUDIO > + case 0x11: / / ISO/IEC 14496-3 Audio with LATM transport > syntax > > > but this way I can not hear sound from other channels, only > the > channels with streamtype 0x11 > is there any way to identify the audio streamtype in this > line so that > the MakeStream (buf + i, streamaudiotype, Channel-> APID > (n)); > > Excuse my English > Best regards > > 2010/5/15 Newsy Paper <newspaperman_germany@yahoo.com>: > > thx Klaus for your patch, but seems like there's > something missing. Perhaps in remux.c? > > > > DDpid and Apid are both 0 > > If I enter aac pid in ddpid field it's set back to 0 > again. > > > > kind regards > > > > Newspaperman > > > > --- Klaus Schmidinger <Klaus.Schmidinger@tvdr.de> > schrieb am Fr, 14.5.2010: > > > >> Von: Klaus Schmidinger <Klaus.Schmidinger@tvdr.de> > >> Betreff: Re: [vdr] vdr and aac support > >> An: vdr@linuxtv.org > >> Datum: Freitag, 14. Mai, 2010 16:13 Uhr > >> On 07.05.2010 09:53, Newsy Paper > >> wrote: > >> > Hi! > >> > > >> > there are some channels using aac for audio. > I.e. > >> SABC1 at 23.5°East 10758 V 22000 8/9 DVB-S2 > >> > Seems vdr doesn't support aac as no pid is > entered > >> neither for apid nor for ddpid. I think xine > should support > >> acc or doesn't it? So it should be no big deal do > extend vdr > >> to support aac. > >> > >> Please try this and see if it makes any > difference: > >> > >> --- pat.c 2010/03/27 > >> 15:17:46 2.9 > >> +++ pat.c 2010/05/14 > >> 14:12:31 > >> @@ -401,6 +401,7 @@ > >> > >> switch > >> (d->getDescriptorTag()) { > >> > >> case > >> SI::AC3DescriptorTag: > >> > >> case > >> SI::EnhancedAC3DescriptorTag: > >> + > >> case > >> SI::AACDescriptorTag: > >> > >> > >> dpid = esPid; > >> > >> > >> ProcessCaDescriptors = true; > >> > >> > >> break; > >> > >> --- eit.c 2010/01/08 > >> 15:17:09 2.11 > >> +++ eit.c 2010/05/14 > >> 14:06:55 > >> @@ -257,7 +257,7 @@ > >> > >> SI::ComponentDescriptor *cd = > >> (SI::ComponentDescriptor *)d; > >> > >> uchar Stream = cd->getStreamContent(); > >> > >> uchar Type = cd->getComponentType(); > >> - > >> if (1 <= Stream && Stream <= > >> 4 && Type != 0) { // 1=video, 2=audio, > 3=subtitles, > >> 4=AC3 > >> + > >> if (1 <= Stream && Stream <= > >> 6 && Type != 0) { // 1=MPEG2-video, > 2=MPEG1-audio, > >> 3=subtitles, 4=AC3-audio, 5=H.264-video, > 6=HEAAC-audio > >> > >> if (!Components) > >> > >> Components = new cComponents; > >> > >> char buffer[Utf8BufSize(256)]; > >> > >> > >> Klaus > >> > >> _______________________________________________ > >> vdr mailing list > >> vdr@linuxtv.org > >> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > >> > > > > > > > > _______________________________________________ > > vdr mailing list > > vdr@linuxtv.org > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > _______________________________________________ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr >
--- pat.c 2010/03/27 15:17:46 2.9 +++ pat.c 2010/05/14 14:12:31 @@ -401,6 +401,7 @@ switch (d->getDescriptorTag()) { case SI::AC3DescriptorTag: case SI::EnhancedAC3DescriptorTag: + case SI::AACDescriptorTag: dpid = esPid; ProcessCaDescriptors = true; break; --- eit.c 2010/01/08 15:17:09 2.11 +++ eit.c 2010/05/14 14:06:55 @@ -257,7 +257,7 @@ SI::ComponentDescriptor *cd = (SI::ComponentDescriptor *)d; uchar Stream = cd->getStreamContent(); uchar Type = cd->getComponentType(); - if (1 <= Stream && Stream <= 4 && Type != 0) { // 1=video, 2=audio, 3=subtitles, 4=AC3 + if (1 <= Stream && Stream <= 6 && Type != 0) { // 1=MPEG2-video, 2=MPEG1-audio, 3=subtitles, 4=AC3-audio, 5=H.264-video, 6=HEAAC-audio if (!Components) Components = new cComponents; char buffer[Utf8BufSize(256)];