Channel wrapping in live-tv
Commit Message
Hi,
One small feature I find is missing from vdr is to have the possibility
to go from the last channel to the first channel and vice versa when
changing channel to next/previous channel in live-tv mode. This is the
normal behaviour in most TVs. So I made a small patch for vdr-1.7.11
(can be applied also to vdr-1.6.0) to make this possible with a menu
option to enable/disable the feature. Would it be possible to have this
feature included in future releases of vdr?
Comments
On Monday 11 January 2010, Matti Lehtimäki wrote:
> Hi,
>
> One small feature I find is missing from vdr is to have the possibility
> to go from the last channel to the first channel and vice versa when
> changing channel to next/previous channel in live-tv mode. This is the
> normal behaviour in most TVs. So I made a small patch for vdr-1.7.11
> (can be applied also to vdr-1.6.0) to make this possible with a menu
> option to enable/disable the feature. Would it be possible to have this
> feature included in future releases of vdr?
I haven't tested the patch, but it sounds useful to me. I wonder if it's
really necessary to make this configurable though - why not just go ahead and
do the wrap-around unconditionally? VDR has more than enough config options
already...
On Mon, Jan 11, 2010 at 9:36 PM, Ville Skyttä <ville.skytta@iki.fi> wrote:
> On Monday 11 January 2010, Matti Lehtimäki wrote:
>> Hi,
>>
>> One small feature I find is missing from vdr is to have the possibility
>> to go from the last channel to the first channel and vice versa when
>> changing channel to next/previous channel in live-tv mode. This is the
>> normal behaviour in most TVs. So I made a small patch for vdr-1.7.11
>> (can be applied also to vdr-1.6.0) to make this possible with a menu
>> option to enable/disable the feature. Would it be possible to have this
>> feature included in future releases of vdr?
>
> I haven't tested the patch, but it sounds useful to me. I wonder if it's
> really necessary to make this configurable though - why not just go ahead and
> do the wrap-around unconditionally? VDR has more than enough config options
> already...
>
Well, I for one would prefer to current behaviour over wrapping.
-Petri
Do you mean switching between the last channel viewed and the current
channel? or channel.conf wrap around? Because last channel switch is
already in by pressing the 0 key.
On 1/11/2010 11:23 AM, Matti Lehtimäki wrote:
> Hi,
>
> One small feature I find is missing from vdr is to have the possibility
> to go from the last channel to the first channel and vice versa when
> changing channel to next/previous channel in live-tv mode. This is the
> normal behaviour in most TVs. So I made a small patch for vdr-1.7.11
> (can be applied also to vdr-1.6.0) to make this possible with a menu
> option to enable/disable the feature. Would it be possible to have this
> feature included in future releases of vdr?
>
>
>
> _______________________________________________
> vdr mailing list
> vdr@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Timothy D. Lenz wrote:
> Do you mean switching between the last channel viewed and the current
> channel? or channel.conf wrap around? Because last channel switch is
> already in by pressing the 0 key.
I mean channels.conf wrap around.
Am 11.01.2010 20:36, schrieb Ville Skyttä:
> I haven't tested the patch, but it sounds useful to me. I wonder if it's
> really necessary to make this configurable though - why not just go ahead and
> do the wrap-around unconditionally? VDR has more than enough config options
> already...
Finally an one-click way to directly go to channel 1431 (BFM TV, yet
another french news channel) - that's what I was waiting for. vote++ for
an option to disable this behavior.
Cheers,
Udo
On Saturday 16 January 2010, Udo Richter wrote:
> Finally an one-click way to directly go to channel 1431 (BFM TV, yet
> another french news channel) - that's what I was waiting for.
Exactly, me too. Because new channels added by VDR tend to end up at the end
of the channels list.
@@ -299,6 +299,7 @@
CurrentDolby = 0;
InitialChannel = 0;
InitialVolume = -1;
+ ChannelsWrap = 0;
EmergencyExit = 1;
}
@@ -486,6 +487,7 @@
else if (!strcasecmp(Name, "CurrentDolby")) CurrentDolby = atoi(Value);
else if (!strcasecmp(Name, "InitialChannel")) InitialChannel = atoi(Value);
else if (!strcasecmp(Name, "InitialVolume")) InitialVolume = atoi(Value);
+ else if (!strcasecmp(Name, "ChannelsWrap")) ChannelsWrap = atoi(Value);
else if (!strcasecmp(Name, "EmergencyExit")) EmergencyExit = atoi(Value);
else
return false;
@@ -578,6 +580,7 @@
Store("CurrentDolby", CurrentDolby);
Store("InitialChannel", InitialChannel);
Store("InitialVolume", InitialVolume);
+ Store("ChannelsWrap", ChannelsWrap);
Store("EmergencyExit", EmergencyExit);
Sort();
@@ -272,6 +272,7 @@
int CurrentDolby;
int InitialChannel;
int InitialVolume;
+ int ChannelsWrap;
int EmergencyExit;
int __EndData__;
cSetup(void);
@@ -2746,6 +2746,7 @@
Add(new cMenuEditIntItem( tr("Setup.Miscellaneous$Channel entry timeout (ms)"), &data.ChannelEntryTimeout, 0));
Add(new cMenuEditChanItem(tr("Setup.Miscellaneous$Initial channel"), &data.InitialChannel, tr("Setup.Miscellaneous$as before")));
Add(new cMenuEditIntItem( tr("Setup.Miscellaneous$Initial volume"), &data.InitialVolume, -1, 255, tr("Setup.Miscellaneous$as before")));
+ Add(new cMenuEditBoolItem(tr("Setup.Miscellaneous$Channels wrap"), &data.ChannelsWrap));
Add(new cMenuEditBoolItem(tr("Setup.Miscellaneous$Emergency exit"), &data.EmergencyExit));
}
@@ -3245,6 +3246,8 @@
if (Direction) {
while (Channel) {
Channel = Direction > 0 ? Channels.Next(Channel) : Channels.Prev(Channel);
+ if (Setup.ChannelsWrap && !Channel)
+ Channel = Direction > 0 ? Channels.First() : Channels.Last();
if (Channel && !Channel->GroupSep() && cDevice::GetDevice(Channel, 0, true))
return Channel;
}