Failed to read channels.conf after adding transponder

  On 06/18/08 15:12, Tim wrote:
> Am Mittwoch 18 Juni 2008 schrieb Frank Scherthan:
>> Hi
>>
>> Hanno Zulla schrieb:
>>>> Is there an easy fix I could test right now? Can I disable the
>>>> channel-checking?
>>> Yes, you can. Check the DVB settings menu.
>> You are wrong. I am not talking about *updating channels*.
>> I know about that and as a workaround, I switched it off.
>> BUT:
>> This is NOT what I am looking for.
>>
>> I want to disable the check, for invalid channels in channels.conf
>> I just don't care, if a channel is not "tuneable".
> in config.h, in the function "bool Load()" at about line 123 (vdr 1.4.7) 
> uncomment 2 lines:
>                    else {
>                       esyslog("ERROR: error in %s, line %d", fileName, line);
>                       delete l;
>                       //RC: we do not want to exit vdr just because of a 
> simple error
>                       //result = false;
>                       //break;
>                       }
>                    }
>                 }
> this will cause vdr to go on starting even if an error accours in a config 
> file and increase waf. ;)

Since this kind of complaints keeps occuring ever again, I guess it's best
to simply report errors when reading config files (as suggested by Tim)



Of course Tim's change would have had the same result, but it also would
have made it completely impossible for the caller of cConfig::Load() to
determine if the call was successful.

Well, whether this actually increases the WAF remains to be seen. Starting
VDR with inconsistent config files may have all kinds of effects...

Klaus
  

On Saturday 06 September 2008, Klaus Schmidinger wrote:
>
> Since this kind of complaints keeps occuring ever again, I guess it's best
> to simply report errors when reading config files (as suggested by Tim)
[...]

Somewhat related - I'm wondering why comments are not allowed in 
channels.conf, remote.conf, setup.conf and timers.conf?

Or actually more generally why an option for disallowing comments in some 
*.conf files exists in the first place :)
  

On 09/06/08 18:38, Ville Skyttä wrote:
> On Saturday 06 September 2008, Klaus Schmidinger wrote:
>> Since this kind of complaints keeps occuring ever again, I guess it's best
>> to simply report errors when reading config files (as suggested by Tim)
> [...]
> 
> Somewhat related - I'm wondering why comments are not allowed in 
> channels.conf, remote.conf, setup.conf and timers.conf?
> 
> Or actually more generally why an option for disallowing comments in some 
> *.conf files exists in the first place :)

Some files are "human written" and will not be overwritten by VDR.
In those files comments make sense.

Other files are automatically written by VDR, so comments don't make
much sense there.

But I have no problem with allowing comments in all files and just
dropping them when automatically writing back those files.
Is this something you'd like to have?

Klaus
  

On Saturday 06 September 2008, Klaus Schmidinger wrote:
> On 09/06/08 18:38, Ville Skyttä wrote:
> >
> > Somewhat related - I'm wondering why comments are not allowed in
> > channels.conf, remote.conf, setup.conf and timers.conf?
> >
> > Or actually more generally why an option for disallowing comments in some
> > *.conf files exists in the first place :)
>
> Some files are "human written" and will not be overwritten by VDR.
> In those files comments make sense.
>
> Other files are automatically written by VDR, so comments don't make
> much sense there.
>
> But I have no problem with allowing comments in all files and just
> dropping them when automatically writing back those files.
> Is this something you'd like to have?

Yes, I think that's fine.  It'd allow distro packagers to ship those files 
with some meaningful comments in them out of the box instead of just empty 
files.  Especially channels.conf which (as far as I'm up to date with VDR's 
current behavior) still needs to be initially generated with external tools.