From patchwork Wed Jun 18 14:55:30 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Evertz X-Patchwork-Id: 12661 Received: from sour.ops.eusc.inter.net ([84.23.254.154]) by www.linuxtv.org with esmtp (Exim 4.63) (envelope-from ) id 1K8z4w-0005PP-Pq for vdr@linuxtv.org; Wed, 18 Jun 2008 16:56:09 +0200 X-Trace: 4d7c7065766572747a40736e6166752e64657c38352e3137392e362e3139367c31 4b387a344f2d3030303355612d55507c31323133383030393333 Received: from sour.ops.eusc.inter.net ([10.154.10.19] helo=localhost) by sour.ops.eusc.inter.net with esmtpsa (Exim 4.69) id 1K8z4O-0003Ua-UP for vdr@linuxtv.org; Wed, 18 Jun 2008 16:55:33 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by pec6.gallier.dorf (8.13.8/8.13.8/SuSE Linux 0.8) with ESMTP id m5IEtTNj026220 for ; Wed, 18 Jun 2008 16:55:32 +0200 Message-ID: <485921E2.1@pec.homeip.net> Date: Wed, 18 Jun 2008 16:55:30 +0200 From: Peter Evertz User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: VDR Mailing List References: <4857EEEA.4000706@gmx.de> <48580849.5050109@hanno.de> <4858B4B4.5060504@gmx.de> <200806181512.55401.rollercoaster@reel-multimedia.com> In-Reply-To: <200806181512.55401.rollercoaster@reel-multimedia.com> X-LSpam-Score: -2.6 (--) X-LSpam-Report: No, score=-2.6 required=5.0 tests=AWL=0.000, BAYES_00=-2.599 autolearn=ham Subject: Re: [vdr] Failed to read channels.conf after adding transponder X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.9 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jun 2008 14:56:09 -0000 Status: O X-Status: X-Keywords: X-UID: 17132 Tim schrieb: > Am Mittwoch 18 Juni 2008 schrieb Frank Scherthan: > >> Hi >> >> Hanno Zulla schrieb: >> >>>> Is there an easy fix I could test right now? Can I disable the >>>> channel-checking? >>>> >>> Yes, you can. Check the DVB settings menu. >>> >> You are wrong. I am not talking about *updating channels*. >> I know about that and as a workaround, I switched it off. >> BUT: >> This is NOT what I am looking for. >> >> I want to disable the check, for invalid channels in channels.conf >> I just don't care, if a channel is not "tuneable". >> > in config.h, in the function "bool Load()" at about line 123 (vdr 1.4.7) > uncomment 2 lines: > else { > esyslog("ERROR: error in %s, line %d", fileName, line); > delete l; > //RC: we do not want to exit vdr just because of a > simple error > //result = false; > //break; > } > } > } > this will cause vdr to go on starting even if an error accours in a config > file and increase waf. ;) > It happens again today. So I made a quick fix. Are you sure that your fix will increase the WAF ? I don't know if VDR works correctly with a "broken" channels list. I prefer not to add broken channels. The patch does not help for channels that modify pids to a broken state, but prevents to add broken channels. --- channels.c.org 2008-04-12 15:49:12.000000000 +0200 +++ channels.c 2008-06-18 12:20:17.000000000 +0200 @@ -1151,6 +1151,11 @@ NewChannel->CopyTransponderData(Transponder); NewChannel->SetId(Nid, Tid, Sid, Rid); NewChannel->SetName(Name, ShortName, Provider); + if(! NewChannel->GetChannelID().Valid()) { + esyslog("ERROR: new channel data results in invalid ID!"); + free(NewChannel); + return(NULL); + } Add(NewChannel); ReNumber(); return NewChannel;