diff mbox

VDR 1.5.17 - pre 1.3.19 compatibility mode problems

Message ID 4801CA34.1070802@gmx.de
State New
Headers

Commit Message

Reinhard Nissl April 13, 2008, 8:54 a.m. UTC 
  Hi,

Stefan Lucke schrieb:

> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 62 (counter is at 8)
> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = DA (counter is at 9)
> Apr 13 09:48:11 jarada vdr: [7765] switching to pre 1.3.19 Dolby Digital compatibility mode - substream id = DA
> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = DA (counter is at 0)
> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 41 (counter is at 0)
> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 0B (counter is at 1)
> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = D6 (counter is at 2)
> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = C6 (counter is at 2)
> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 5A (counter is at 3)
> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 0B (counter is at 4)
> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 6C (counter is at 4)
> 
> Wondering why the are different substream ids are reported with the same counter value ;-).
> 
>> This additional check was suggested by Marco Schlüßler, so maybe he can comment
>> on this and maybe find out why this is interfering with the pre 1.3.19 Dolby Digital
>> detection?

Maybe I should have posted this patch to the list earlier too. 
Without the patch, the counter will restart from 0 and prevent 
VDR to run in compatibility mode just after VDR was going to 
activate compatibility mode.

Bye.

Comments

Klaus Schmidinger April 13, 2008, 8:57 a.m. UTC | #1 
On 04/13/08 10:54, Reinhard Nissl wrote:
> Hi,
> 
> Stefan Lucke schrieb:
> 
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> 62 (counter is at 8)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> DA (counter is at 9)
>> Apr 13 09:48:11 jarada vdr: [7765] switching to pre 1.3.19 Dolby 
>> Digital compatibility mode - substream id = DA
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> DA (counter is at 0)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> 41 (counter is at 0)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> 0B (counter is at 1)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> D6 (counter is at 2)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> C6 (counter is at 2)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> 5A (counter is at 3)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> 0B (counter is at 4)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> 6C (counter is at 4)
>>
>> Wondering why the are different substream ids are reported with the 
>> same counter value ;-).
>>
>>> This additional check was suggested by Marco Schlüßler, so maybe he 
>>> can comment
>>> on this and maybe find out why this is interfering with the pre 
>>> 1.3.19 Dolby Digital
>>> detection?
> 
> Maybe I should have posted this patch to the list earlier too. Without 
> the patch, the counter will restart from 0 and prevent VDR to run in 
> compatibility mode just after VDR was going to activate compatibility mode.

You've beat me by just a few seconds - I was just about to post the patch
you sent me privately, too ;-)

Klaus
Stefan Lucke April 13, 2008, 9:55 a.m. UTC | #2 
On Sunday 13 April 2008, Reinhard Nissl wrote:
> Hi,
> 
> Stefan Lucke schrieb:
> 
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 62 (counter is at 8)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = DA (counter is at 9)
> > Apr 13 09:48:11 jarada vdr: [7765] switching to pre 1.3.19 Dolby Digital compatibility mode - substream id = DA
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = DA (counter is at 0)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 41 (counter is at 0)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 0B (counter is at 1)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = D6 (counter is at 2)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = C6 (counter is at 2)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 5A (counter is at 3)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 0B (counter is at 4)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 6C (counter is at 4)
> > 
> > Wondering why the are different substream ids are reported with the same counter value ;-).
> > 
> >> This additional check was suggested by Marco Schlüßler, so maybe he can comment
> >> on this and maybe find out why this is interfering with the pre 1.3.19 Dolby Digital
> >> detection?
> 
> Maybe I should have posted this patch to the list earlier too. 

Ack.
Maybe I should have tested my old recordings a bit earlier ;-) .

> Without the patch, the counter will restart from 0 and prevent 

Bingo.
With patch, vdr-1.6.0 could replay these old recodings with sound,
at least normal stereo.
Thanks.

> VDR to run in compatibility mode just after VDR was going to 
> activate compatibility mode.
> 

 
Stefan Lucke
diff mbox

Patch

--- ../vdr-1.5.18-dvbs2-other/device.c	2008-03-19 22:33:06.000000000 +0100
+++ device.c	2008-04-06 18:53:53.000000000 +0200
@@ -1335,6 +1346,7 @@  pre_1_3_19_PrivateStreamDeteced:
                          if (pre_1_3_19_PrivateStream > MIN_PRE_1_3_19_PRIVATESTREAM) {
                             dsyslog("switching to pre 1.3.19 Dolby Digital compatibility mode - substream id = %02X", SubStreamId);
                             ClrAvailableTracks();
+                            pre_1_3_19_PrivateStream = MIN_PRE_1_3_19_PRIVATESTREAM + 1;
                             goto pre_1_3_19_PrivateStreamDeteced;
                             }
                          }