From patchwork Wed Mar 5 21:12:43 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Olivetti X-Patchwork-Id: 12620 Received: from 61.pool85-52-226.static.orange.es ([85.52.226.61] helo=ventoso.org) by www.linuxtv.org with esmtp (Exim 4.63) (envelope-from ) id 1JX0vN-0001Tu-7w for vdr@linuxtv.org; Wed, 05 Mar 2008 22:13:21 +0100 Received: from [192.168.10.30] (unknown [192.168.10.30]) by ventoso.org (Postfix) with ESMTP id 70A1CCAB6D6 for ; Wed, 5 Mar 2008 22:12:42 +0100 (CET) Message-ID: <47CF0CCB.70309@ventoso.org> Date: Wed, 05 Mar 2008 22:12:43 +0100 From: Luca Olivetti User-Agent: Thunderbird 2.0.0.4 (X11/20070620) MIME-Version: 1.0 To: VDR Mailing List References: <20080304205553.GA29585@srotta.homeip.net> <20080304211025.GA29694@srotta.homeip.net> <47CDC07F.6090107@cadsoft.de> <20080305120231.GA32268@srotta.homeip.net> <20080305164745.GA923@srotta.homeip.net> <47CECF7B.5090709@cadsoft.de> <20080305173822.GA1219@srotta.homeip.net> In-Reply-To: <20080305173822.GA1219@srotta.homeip.net> X-LSpam-Score: 0.0 (/) Subject: Re: [vdr] DXR3 and subtitles in 1.5.x X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.9 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Mar 2008 21:13:22 -0000 Status: O X-Status: X-Keywords: X-UID: 15973 En/na Sami Sundell ha escrit: > On Wed, Mar 05, 2008 at 05:51:07PM +0100, Klaus Schmidinger wrote: > >> I'd say this whole thing is a DXR3 problem, not a core VDR problem. >> Therefore I'm afraid I can't contribute to the solution... > > Looks like it, but thanks anyway. > > ... found the 0.2.x-branch in the dxr3 plugin CVS, which gives me Yes, that's the "good" one (I don't think anybody is working on the HEAD version). > picture but still bleeding subtitles. Now it won't crash if I try to > access the OSD, it just stops responding to remote. :P Well, I also had to modify dvbsubtitle.c (with some hints from the dxr3-plugin mailing list), and since I go from one vdr version to the next one with the patch, I forgot it. Attached is a diff from the stock dvbsubtitle.c in 1.5.17 and the version I'm using. I don't know if it's a good or bad patch but it works here, no bleeding and the lirc remote is responsive. I also cannot say if any of the other patches I have make a difference. Bye --- vdr-1.5.17.orig/dvbsubtitle.c 2007-11-25 14:33:08.000000000 +0100 +++ vdr-1.5.17/dvbsubtitle.c 2008-01-20 19:24:05.785023000 +0100 @@ -983,13 +983,22 @@ return; tArea *Areas = Page->GetAreas(); int NumAreas = Page->regions.Count(); - int Bpp = 8; bool Reduced = false; - while (osd->CanHandleAreas(Areas, NumAreas) != oeOk) { + for (int i = 0; i < NumAreas; i++) { + if (Areas[i].bpp > 2) { + Areas[i].bpp = 2; + Reduced = true; + } + } + + /* + int Bpp = 4; + bool Reduced = false; + //while (osd->CanHandleAreas(Areas, NumAreas) != oeOk) { int HalfBpp = Bpp / 2; if (HalfBpp >= 2) { for (int i = 0; i < NumAreas; i++) { - if (Areas[i].bpp >= Bpp) { + while (Areas[i].bpp >= Bpp) { Areas[i].bpp = HalfBpp; Reduced = true; } @@ -998,7 +1007,9 @@ } else return; // unable to draw bitmaps + // } + */ if (Reduced) { for (int i = 0; i < NumAreas; i++) { cSubtitleRegion *sr = Page->regions.Get(i);