From patchwork Sun Jan 13 17:56:21 2008
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Reinhard Nissl <rnissl@gmx.de>
X-Patchwork-Id: 12578
Received: from mail.gmx.net ([213.165.64.20])
	by www.linuxtv.org with smtp (Exim 4.63)
	(envelope-from <rnissl@gmx.de>) id 1JE74m-00023K-Sg
	for vdr@linuxtv.org; Sun, 13 Jan 2008 18:56:52 +0100
Received: (qmail invoked by alias); 13 Jan 2008 17:56:22 -0000
Received: from p549308CE.dip0.t-ipconnect.de (EHLO [192.168.101.15])
	[84.147.8.206]
	by mail.gmx.net (mp002) with SMTP; 13 Jan 2008 18:56:22 +0100
X-Authenticated: #527675
X-Provags-ID: V01U2FsdGVkX1/O60Ua3avOP3DveozgOt9o+bn+gxi/2tB+qAxiDM
	j3lAKc5eqybC6X
Message-ID: <478A50C5.8080409@gmx.de>
Date: Sun, 13 Jan 2008 18:56:21 +0100
From: Reinhard Nissl <rnissl@gmx.de>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; de;
	rv:1.8.1.9) Gecko/20070801 SUSE/2.0.0.9-0.1 Thunderbird/2.0.0.9
	Mnenhy/0.7.5.666
MIME-Version: 1.0
To: VDR Mailing List <vdr@linuxtv.org>
References: <eddfa47b0801100456g662905ccl88e257f9c36f576c@mail.gmail.com>
	<200801121637.32921.stefan@lucke.in-berlin.de>
	<eddfa47b0801120828o7b506cc6w8400df50a56c73e0@mail.gmail.com>
	<200801122247.54574.stefan@lucke.in-berlin.de>	<47894CBD.4090800@gmx.de>
	<eddfa47b0801130419g589ceec2rc9cf94ed2804448b@mail.gmail.com>
In-Reply-To: <eddfa47b0801130419g589ceec2rc9cf94ed2804448b@mail.gmail.com>
X-Y-GMX-Trusted: 0
Subject: Re: [vdr] BUG: DVB-T and DVB-S[2] do not work with VDR & multiproto
X-BeenThere: vdr@linuxtv.org
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: VDR Mailing List <vdr@linuxtv.org>
List-Id: VDR Mailing List <vdr.linuxtv.org>
List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=unsubscribe>
List-Archive: <http://www.linuxtv.org/pipermail/vdr>
List-Post: <mailto:vdr@linuxtv.org>
List-Help: <mailto:vdr-request@linuxtv.org?subject=help>
List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Jan 2008 17:56:53 -0000
Status: O
X-Status: 
X-Keywords: 
X-UID: 15080

Hi,

Morfsta schrieb:

>> Please report the debug output here for further investigation.
> 
> Attached are two files - tuning to the same DVB-T channel using either
> system and the Philips frontend... vdr-1.4.x shows the channel fine,
> 1.5.12 does not.
> 
> Hope this helps and thanks again for your assistance.

Hmm, the translation layer doesn't work correctly. It doesn't
translate new bandwidth value 1 to old bandwidth value 0,
although there exists code to do this translation, and it should
get called as the other translations happen correctly.

As a result the old driver uses a bandwidth of 7 MHz instead of 8
MHz.

While copying the code here to ask for help in searching the bug,
it seems that I found the bug -- a missing break in the DVB-T
case ;-)

Please try the attached patch.

Bye.

diff --git a/linux/drivers/media/dvb/dvb-core/dvb_frontend.c b/linux/drivers/media/dvb/dvb-core/dvb_frontend.c
--- a/linux/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/linux/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -413,7 +441,7 @@ int newapi_to_olddrv(struct dvbfe_params
 			ofdm->transmission_mode = TRANSMISSION_MODE_AUTO;
 			break;
 		default:
-			dprintk("%s: Unsupported transmission mode %x\n", __func__, dvbt->bandwidth);
+			dprintk("%s: Unsupported transmission mode %x\n", __func__, dvbt->transmission_mode);
 			return -EINVAL;
 		}
 		switch (dvbt->guard_interval) {
@@ -454,6 +482,7 @@ int newapi_to_olddrv(struct dvbfe_params
 			}
 			break;
 		}
+		break;
 	case DVBFE_DELSYS_ATSC:
 		newmod_to_oldmod(atsc->modulation, &vsb->modulation);
 		break;