From patchwork Sun Sep  2 13:44:47 2007
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Luca Olivetti <luca@ventoso.org>
X-Patchwork-Id: 12525
Received: from 61.pool85-52-226.static.orange.es ([85.52.226.61]
	helo=ventoso.org) by www.linuxtv.org with esmtp (Exim 4.63)
	(envelope-from <luca@ventoso.org>) id 1IRplN-0002qp-5o
	for vdr@linuxtv.org; Sun, 02 Sep 2007 15:45:17 +0200
Received: from [192.168.10.30] (unknown [192.168.10.30])
	by ventoso.org (Postfix) with ESMTP id 4D1C7C34FD1
	for <vdr@linuxtv.org>; Sun,  2 Sep 2007 15:44:44 +0200 (CEST)
Message-ID: <46DABE4F.1070300@ventoso.org>
Date: Sun, 02 Sep 2007 15:44:47 +0200
From: Luca Olivetti <luca@ventoso.org>
User-Agent: Thunderbird 2.0.0.4 (X11/20070620)
MIME-Version: 1.0
To: VDR Mailing List <vdr@linuxtv.org>
References: <46D666B1.7030504@ventoso.org>
	<Pine.OSF.4.64.0708302049001.151682@kosh.hut.fi>
	<46DAB79C.6060206@ventoso.org>	<46DABAA1.5040800@googlemail.com>
	<46DABC77.3050801@ventoso.org>
In-Reply-To: <46DABC77.3050801@ventoso.org>
Subject: Re: [vdr] vdr-1.5.9 and ttxtsubs patch/plugin
X-BeenThere: vdr@linuxtv.org
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: VDR Mailing List <vdr@linuxtv.org>
List-Id: VDR Mailing List <vdr.linuxtv.org>
List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=unsubscribe>
List-Archive: <http://www.linuxtv.org/pipermail/vdr>
List-Post: <mailto:vdr@linuxtv.org>
List-Help: <mailto:vdr-request@linuxtv.org?subject=help>
List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Sep 2007 13:45:17 -0000
Status: O
X-Status: 
X-Keywords: 
X-UID: 14013

En/na Luca Olivetti ha escrit:
> En/na Petri Helin ha escrit:
>> Luca Olivetti wrote:
>>> En/na Rolf Ahrenberg ha escrit:
>>>> DVB subtitles are working nicely in my FF setup and someone reported 
>>>> that ttxtsubs are working with xineliboutput.
>>> I somewhat doubt it, since I had to bypass the "IsOpen" test to make it 
>>> work with a properly (I think) patched dxr3 plugin.
>> There is nothing to doubt about. Ttxtsubs do work with xineliboutput and 
>> VDR-1.5.9. Or was it something else you had doubts about?
> 
> 
> You're right, I've re-checked without my patch and it works (though with 
> the osd level the "IsOpen" check is not really necessary).

though the attached patch is IMO needed (otherwise the plugin doesn't 
take into account the "volatile" main menu setting but only the setup 
menu setting in order to decide whether do display the subtitles or not).

Bye

--- ttxtsubsdisplay.c~	2007-09-02 15:40:57.901730000 +0200
+++ ttxtsubsdisplay.c	2007-09-02 15:40:57.911730000 +0200
@@ -386,7 +386,7 @@
   cOSDSelfMemoryLock selfmem(&gSelfMem);
   cMutexLock lock(&mOsdLock);
 
-  if(!globals.mDoDisplay) {
+  if(!globals.mRealDoDisplay) {
     //dprint("NOT displaying subtitles because disabled!\n");
     return;
   }