vdr-1.5.9 and ttxtsubs patch/plugin

Message ID 46DABE4F.1070300@ventoso.org
State New
Headers

Commit Message

Luca Olivetti Sept. 2, 2007, 1:44 p.m. UTC
  En/na Luca Olivetti ha escrit:
> En/na Petri Helin ha escrit:
>> Luca Olivetti wrote:
>>> En/na Rolf Ahrenberg ha escrit:
>>>> DVB subtitles are working nicely in my FF setup and someone reported 
>>>> that ttxtsubs are working with xineliboutput.
>>> I somewhat doubt it, since I had to bypass the "IsOpen" test to make it 
>>> work with a properly (I think) patched dxr3 plugin.
>> There is nothing to doubt about. Ttxtsubs do work with xineliboutput and 
>> VDR-1.5.9. Or was it something else you had doubts about?
> 
> 
> You're right, I've re-checked without my patch and it works (though with 
> the osd level the "IsOpen" check is not really necessary).

though the attached patch is IMO needed (otherwise the plugin doesn't 
take into account the "volatile" main menu setting but only the setup 
menu setting in order to decide whether do display the subtitles or not).

Bye
  

Patch

--- ttxtsubsdisplay.c~	2007-09-02 15:40:57.901730000 +0200
+++ ttxtsubsdisplay.c	2007-09-02 15:40:57.911730000 +0200
@@ -386,7 +386,7 @@ 
   cOSDSelfMemoryLock selfmem(&gSelfMem);
   cMutexLock lock(&mOsdLock);
 
-  if(!globals.mDoDisplay) {
+  if(!globals.mRealDoDisplay) {
     //dprint("NOT displaying subtitles because disabled!\n");
     return;
   }