| Message ID | 46DAB79C.6060206@ventoso.org |
|---|---|
| State | New |
| Headers |
Received: from 61.pool85-52-226.static.orange.es ([85.52.226.61] helo=ventoso.org) by www.linuxtv.org with esmtp (Exim 4.63) (envelope-from <luca@ventoso.org>) id 1IRpJg-000063-Cg for vdr@linuxtv.org; Sun, 02 Sep 2007 15:16:40 +0200 Received: from [192.168.10.30] (unknown [192.168.10.30]) by ventoso.org (Postfix) with ESMTP id 68552CA3A66 for <vdr@linuxtv.org>; Sun, 2 Sep 2007 15:16:09 +0200 (CEST) Message-ID: <46DAB79C.6060206@ventoso.org> Date: Sun, 02 Sep 2007 15:16:12 +0200 From: Luca Olivetti <luca@ventoso.org> User-Agent: Thunderbird 2.0.0.4 (X11/20070620) MIME-Version: 1.0 To: VDR Mailing List <vdr@linuxtv.org> References: <46D666B1.7030504@ventoso.org> <Pine.OSF.4.64.0708302049001.151682@kosh.hut.fi> In-Reply-To: <Pine.OSF.4.64.0708302049001.151682@kosh.hut.fi> Content-Type: multipart/mixed; boundary="------------000905040104010200000407" Subject: Re: [vdr] vdr-1.5.9 and ttxtsubs patch/plugin X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.9 Precedence: list Reply-To: VDR Mailing List <vdr@linuxtv.org> List-Id: VDR Mailing List <vdr.linuxtv.org> List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=unsubscribe> List-Archive: <http://www.linuxtv.org/pipermail/vdr> List-Post: <mailto:vdr@linuxtv.org> List-Help: <mailto:vdr-request@linuxtv.org?subject=help> List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=subscribe> X-List-Received-Date: Sun, 02 Sep 2007 13:16:40 -0000 Status: O X-Status: X-Keywords: X-UID: 14010 |
Commit Message
Luca Olivetti
Sept. 2, 2007, 1:16 p.m. UTC
En/na Rolf Ahrenberg ha escrit: > On Thu, 30 Aug 2007, Luca Olivetti wrote: > >> With a quick look (and I remark "quick" so I may be wrong) it seems that >> the patches now don't change anymore the osd but use the new osd level >> in vdr-1.5.9. > > Yes. I've set subtitles to use level 10 and ttxtsubs to 20. > >> I'd like to know if the new patch is supposed to be working, or the >> cause the subtitles aren't showing is my hurriedly patched dxr3 and xine >> plugins. > > DVB subtitles are working nicely in my FF setup and someone reported > that ttxtsubs are working with xineliboutput. I somewhat doubt it, since I had to bypass the "IsOpen" test to make it work with a properly (I think) patched dxr3 plugin. Patch attached. Bye
Comments
Luca Olivetti wrote: > En/na Rolf Ahrenberg ha escrit: >> DVB subtitles are working nicely in my FF setup and someone reported >> that ttxtsubs are working with xineliboutput. > > I somewhat doubt it, since I had to bypass the "IsOpen" test to make it > work with a properly (I think) patched dxr3 plugin. There is nothing to doubt about. Ttxtsubs do work with xineliboutput and VDR-1.5.9. Or was it something else you had doubts about? -Petri
En/na Petri Helin ha escrit: > Luca Olivetti wrote: >> En/na Rolf Ahrenberg ha escrit: >>> DVB subtitles are working nicely in my FF setup and someone reported >>> that ttxtsubs are working with xineliboutput. >> I somewhat doubt it, since I had to bypass the "IsOpen" test to make it >> work with a properly (I think) patched dxr3 plugin. > > There is nothing to doubt about. Ttxtsubs do work with xineliboutput and > VDR-1.5.9. Or was it something else you had doubts about? You're right, I've re-checked without my patch and it works (though with the osd level the "IsOpen" check is not really necessary).
On Sun, 2 Sep 2007, Luca Olivetti wrote: > You're right, I've re-checked without my patch and it works (though with > the osd level the "IsOpen" check is not really necessary). Well, you're right too and it was a bummer in my patch - somehow forgot to check those IsOpen calls when re-patching the ttxtsubs. I also integrated your mRealDoDisplay fix. BR, -- rofa
En/na Rolf Ahrenberg ha escrit: > On Sun, 2 Sep 2007, Luca Olivetti wrote: > >> You're right, I've re-checked without my patch and it works (though with >> the osd level the "IsOpen" check is not really necessary). > > Well, you're right too and it was a bummer in my patch - somehow forgot > to check those IsOpen calls when re-patching the ttxtsubs. I also > integrated your mRealDoDisplay fix. Considering that 1) The last released version of the plugin is 3 and a half years old 2) Neither me nor google haven't seen the author here or anywhere else since 3 and a half years ago 3) The (compressed) patch size is about half the (compressed) plugin source 4) You've been almost the only one that took care of the plugin (ok, I did some very minor things, and probably there have been other contributors, but you did the rest) why don't you take maintainership of the plugin, release a full tarball, and be done with it? Bonus points if you release a "stable" (or if you prefer "dead" ;-) version for "stable" vdr and a bleeding edge version (without the #if APIVERSION madness!) for the development version ;-) If Ragnar is alive and listening, please speak up. Bye
Luca Olivetti wrote: > En/na Rolf Ahrenberg ha escrit: > >> On Sun, 2 Sep 2007, Luca Olivetti wrote: >> >> >>> You're right, I've re-checked without my patch and it works (though with >>> the osd level the "IsOpen" check is not really necessary). >>> >> Well, you're right too and it was a bummer in my patch - somehow forgot >> to check those IsOpen calls when re-patching the ttxtsubs. I also >> integrated your mRealDoDisplay fix. >> > > Considering that > > 1) The last released version of the plugin is 3 and a half years old > 2) Neither me nor google haven't seen the author here or anywhere else > since 3 and a half years ago > 3) The (compressed) patch size is about half the (compressed) plugin source > 4) You've been almost the only one that took care of the plugin (ok, I > did some very minor things, and probably there have been other > contributors, but you did the rest) > > why don't you take maintainership of the plugin, release a full tarball, > and be done with it? > Bonus points if you release a "stable" (or if you prefer "dead" ;-) > version for "stable" vdr and a bleeding edge version (without the #if > APIVERSION madness!) for the development version ;-) > > If Ragnar is alive and listening, please speak up. > > Bye > I agree with you Luca. I had an email conversation (in Swedish) with Ragnar a year ago and he said he doesn't use VDR anymore, so it's not likely we'll to hear anything from him here again. I don't know what the situation is in Germany, but if Claus will eventually integrate Teletext+subs in the VDR core that's the best solution for us in Sweden. /Magnus H
On Mon, 3 Sep 2007, Luca Olivetti wrote: > why don't you take maintainership of the plugin, release a full tarball, > and be done with it? Because I don't want it. The plugin needs a complete rewrite and there's no point to do it before Klaus has integrated necessary parts into VDR's core (OSD handling, subtitles menu/key, ..) that's hopefully next sunday :) I don't even had any ttxtsubs channels available for years and been just maintaining the plugin for my friends by doing as little as it requires... and besides, I've been getting those damn bug reports already, but been able to reject them by saying I'm not the maintainer! I'd like to see the ttxtsubs (and closed captions) integrated into core VDR before the next stable release as they are IMO essential features that should work out-of-box. -- rofa
En/na Rolf Ahrenberg ha escrit: > On Mon, 3 Sep 2007, Luca Olivetti wrote: > >> why don't you take maintainership of the plugin, release a full tarball, >> and be done with it? > > Because I don't want it. The plugin needs a complete rewrite and there's > no point to do it before Klaus has integrated necessary parts into VDR's > core (OSD handling, subtitles menu/key, ..) ...subtitles recording... > that's hopefully next sunday > :) I don't even had any ttxtsubs channels available for years and been > just maintaining the plugin for my friends by doing as little as it > requires... and besides, I've been getting those damn bug reports > already, but been able to reject them by saying I'm not the maintainer! fair enough > I'd like to see the ttxtsubs (and closed captions) integrated into core > VDR before the next stable release as they are IMO essential features > that should work out-of-box. I hope Klaus is listening ;-) Bye
On 09/03/07 23:57, Luca Olivetti wrote: > En/na Rolf Ahrenberg ha escrit: >> On Mon, 3 Sep 2007, Luca Olivetti wrote: >> >>> why don't you take maintainership of the plugin, release a full tarball, >>> and be done with it? >> Because I don't want it. The plugin needs a complete rewrite and there's >> no point to do it before Klaus has integrated necessary parts into VDR's >> core (OSD handling, subtitles menu/key, ..) > > ...subtitles recording... > >> that's hopefully next sunday Well, I`m not sure about that - but it won't be too long ;-) DVB subtitles will be fully integrated in the next developer version, thanks to Marco Schlüßler who povided the main parts of the DVB subtitle handling. There are just a few remaining issues that need to be solved before I'll release it. >> :) I don't even had any ttxtsubs channels available for years and been >> just maintaining the plugin for my friends by doing as little as it >> requires... and besides, I've been getting those damn bug reports >> already, but been able to reject them by saying I'm not the maintainer! > > fair enough > >> I'd like to see the ttxtsubs (and closed captions) integrated into core >> VDR before the next stable release as they are IMO essential features >> that should work out-of-box. > > I hope Klaus is listening ;-) Once DVB subtitles are fully working. ttxt subtitles will be next. I haven't looked into the code of the ttxt subtitle plugin, yet, but currently my idea is to convert the ttxt subtitles into DVB subtitles, so that VDR only needs to handle one type of subtitiles for recording and live viewing. Klaus
En/na Klaus Schmidinger ha escrit: > I haven't looked into the code of the ttxt subtitle plugin, yet, but > currently my idea is to convert the ttxt subtitles into DVB subtitles, > so that VDR only needs to handle one type of subtitiles for recording > and live viewing. Aren't dvb subtitles just bitmaps? If so, converting the text to a bitmap for recording doesn't seem a good idea to me. Bye
Luca Olivetti wrote: > Aren't dvb subtitles just bitmaps? If so, converting the text to a > bitmap for recording doesn't seem a good idea to me. Second that. /Richard
On 9/4/07, Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de> wrote: > DVB subtitles will be fully integrated in the next developer > version, thanks to Marco Schlüßler who povided the main parts > of the DVB subtitle handling. Does this include NA closed-captioning/line21 support as well or are Euros the only ones who get this treat? :) Cheers
On Tue, 4 Sep 2007, Klaus Schmidinger wrote: > DVB subtitles will be fully integrated in the next developer > version, thanks to Marco Schlüßler who povided the main parts > of the DVB subtitle handling. There are just a few remaining > issues that need to be solved before I'll release it. Does your implementation provide compatibility for external demuxers like ProjectX and recordings made with current subtitles plugin? Marco's patch does the remuxing a bit differently as the subtitles plugin. I'd also like see some features currently found in the subtitles plugin in VDR's implementation: vertical offset and transparency adjustments. BR, -- rofa
On 09/04/07 23:45, Luca Olivetti wrote: > En/na Klaus Schmidinger ha escrit: > >> I haven't looked into the code of the ttxt subtitle plugin, yet, but >> currently my idea is to convert the ttxt subtitles into DVB subtitles, >> so that VDR only needs to handle one type of subtitiles for recording >> and live viewing. > > Aren't dvb subtitles just bitmaps? If so, converting the text to a > bitmap for recording doesn't seem a good idea to me. Well, in the end they would have to be displayed as bitmaps, anyway. Besides, the DVB subtitle specs also provide a means of having character strings instead of bitmaps. I'm not sure yet how it's going to be, but I'm certainly not going to have two (or three, with "Closed Captioning") different subtitling methods throughout VDR. There's _one_ mechanism, based on "ETS 300 743", and anything else will be converted to this as early as possible. Klaus
On 09/05/07 01:00, VDR User wrote: > On 9/4/07, Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de> wrote: >> DVB subtitles will be fully integrated in the next developer >> version, thanks to Marco Schlüßler who povided the main parts >> of the DVB subtitle handling. > > Does this include NA closed-captioning/line21 support as well or are > Euros the only ones who get this treat? :) Not directly, since AFAICS "Closed Captioning" has nothing in common with DVB subtitles. But maybe the CC texts can be easily converted to DVB subtitles, just like it's going to be with teletext subtitles. In that case I don't see why CC shouldn't be supported. Klaus
On 09/05/07 07:35, Rolf Ahrenberg wrote: > On Tue, 4 Sep 2007, Klaus Schmidinger wrote: > >> DVB subtitles will be fully integrated in the next developer >> version, thanks to Marco Schlüßler who povided the main parts >> of the DVB subtitle handling. There are just a few remaining >> issues that need to be solved before I'll release it. > > Does your implementation provide compatibility for external demuxers It stores the DVB subtitles into PES packets with ids ranging from 0x20...0x3F, if that's what you mean. > like ProjectX and recordings made with current subtitles plugin? > Marco's patch does the remuxing a bit differently as the subtitles > plugin. We'll have to see about that. If it doesn't work immediately (which would mean that the subtitle plugin did it wrong ;-) I'm sure there can be some compatibility code or a tool that converts existing recordings. > I'd also like see some features currently found in the subtitles plugin > in VDR's implementation: vertical offset and transparency adjustments. Let's see about that once the basic functionality works. Klaus
Klaus Schmidinger wrote: > On 09/04/07 23:45, Luca Olivetti wrote: >> En/na Klaus Schmidinger ha escrit: >> >>> I haven't looked into the code of the ttxt subtitle plugin, yet, but >>> currently my idea is to convert the ttxt subtitles into DVB subtitles, >>> so that VDR only needs to handle one type of subtitiles for recording >>> and live viewing. >> Aren't dvb subtitles just bitmaps? If so, converting the text to a >> bitmap for recording doesn't seem a good idea to me. > > Well, in the end they would have to be displayed as bitmaps, anyway. > Besides, the DVB subtitle specs also provide a means of having > character strings instead of bitmaps. I'm not sure yet how it's > going to be, but I'm certainly not going to have two (or three, with > "Closed Captioning") different subtitling methods throughout VDR. > There's _one_ mechanism, based on "ETS 300 743", and anything else > will be converted to this as early as possible. I don't think converting text to bitmaps is a good idea, you'll lose the ability to format the text at your will, and the ability to export them as .srt or .sub files.
On 09/05/07 18:13, Anssi Hannula wrote: > Klaus Schmidinger wrote: >> On 09/04/07 23:45, Luca Olivetti wrote: >>> En/na Klaus Schmidinger ha escrit: >>> >>>> I haven't looked into the code of the ttxt subtitle plugin, yet, but >>>> currently my idea is to convert the ttxt subtitles into DVB subtitles, >>>> so that VDR only needs to handle one type of subtitiles for recording >>>> and live viewing. >>> Aren't dvb subtitles just bitmaps? If so, converting the text to a >>> bitmap for recording doesn't seem a good idea to me. >> Well, in the end they would have to be displayed as bitmaps, anyway. >> Besides, the DVB subtitle specs also provide a means of having >> character strings instead of bitmaps. I'm not sure yet how it's >> going to be, but I'm certainly not going to have two (or three, with >> "Closed Captioning") different subtitling methods throughout VDR. >> There's _one_ mechanism, based on "ETS 300 743", and anything else >> will be converted to this as early as possible. > > I don't think converting text to bitmaps is a good idea, you'll lose the > ability to format the text at your will, and the ability to export them > as .srt or .sub files. Well, as I said, the DVB subtitle structures also provide means of storing character strings. Klaus
>> Does your implementation provide compatibility for external demuxers > fyi, some successfully use the dvbtextsubs aka dvbsubs tool to extract ttxtsubs: cvs -d:pserver:anonymous@dvbtools.cvs.sourceforge.net:/cvsroot/dvbtools login cvs -z3 -d:pserver:anonymous@dvbtools.cvs.sourceforge.net:/cvsroot/dvbtools co -P dvbsubs mfg, best, sean
--- ttxtsubsdisplay.c.orig 2007-09-02 13:38:44.621547000 +0200 +++ ttxtsubsdisplay.c 2007-09-02 15:07:14.774866000 +0200 @@ -413,12 +413,12 @@ delete tmp; } +#if defined(APIVERSNUM) && APIVERSNUM < 10509 if (cOsd::IsOpen()) { //dprint("NOT displaying subtitles because of other OSD activities!\n"); return; } else { -#if defined(APIVERSNUM) && APIVERSNUM < 10509 mOsd = cOsdProvider::NewOsd(SCREENLEFT, SCREENTOP); #else mOsd = cOsdProvider::NewOsd(SCREENLEFT, SCREENTOP, 20); // level 20 @@ -427,7 +427,9 @@ //dprint("Error: cOsdProvider::NewOsd() returned NULL!\n"); return; } +#if defined(APIVERSNUM) && APIVERSNUM < 10509 } +#endif #if defined(APIVERSNUM) && APIVERSNUM < 10503 cFont::SetCode(I18nCharSets()[globals.i18nLanguage()]);