From patchwork Sun Jul  1 14:21:05 2007
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>
X-Patchwork-Id: 12486
Received: from raven.cadsoft.de ([217.7.101.211])
	by www.linuxtv.org with esmtp (Exim 4.63)
	(envelope-from <Klaus.Schmidinger@cadsoft.de>) id 1I50Ib-0002BV-9n
	for vdr@linuxtv.org; Sun, 01 Jul 2007 16:21:13 +0200
Received: from [10.10.1.10] (67-41-151-57.hlrn.qwest.net [67.41.151.57])
	by raven.cadsoft.de (8.13.3/8.13.3) with ESMTP id l61ELAVq011333
	for <vdr@linuxtv.org>; Sun, 1 Jul 2007 16:21:11 +0200
Message-ID: <4687B851.5080608@cadsoft.de>
Date: Sun, 01 Jul 2007 16:21:05 +0200
From: Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>
Organization: CadSoft Computer GmbH
User-Agent: Thunderbird 1.5.0.12 (X11/20060911)
MIME-Version: 1.0
To: vdr@linuxtv.org
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(raven.cadsoft.de [217.7.101.211]);
	Sun, 01 Jul 2007 16:21:12 +0200 (CEST)
Subject: [vdr] Buffer overflow in initializing character table
X-BeenThere: vdr@linuxtv.org
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: VDR Mailing List <vdr@linuxtv.org>
List-Id: VDR Mailing List <vdr.linuxtv.org>
List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=unsubscribe>
List-Archive: <http://www.linuxtv.org/pipermail/vdr>
List-Post: <mailto:vdr@linuxtv.org>
List-Help: <mailto:vdr-request@linuxtv.org?subject=help>
List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Jul 2007 14:21:13 -0000
Status: O
X-Status: 
X-Keywords: 
X-UID: 13439

Marco Schlüßler has sent me the attached patch that fixes a
buffer overflow in initializing VDR's character table.

Since I'll be away from home for another two weeks and this
might be a problem for others, too, I'm posting it here before
the next official developer version.

Klaus

diff -bur vdr-1.5.5_orig/tools.c vdr-1.5.5/tools.c
--- vdr-1.5.5_orig/tools.c	2007-06-26 21:03:21.000000000 +0200
+++ vdr-1.5.5/tools.c	2007-06-26 21:05:18.000000000 +0200
@@ -756,7 +756,7 @@
      char buf[129];
      for (int i = 0; i < 128; i++)
          buf[i] = i + 128;
-     buf[129] = 0;
+     buf[128] = 0;
      cCharSetConv csc(CharacterTable);
      const char *s = csc.Convert(buf);
      int i = 0;