diff mbox

vdr-1.5.3 - issue with translations out of plugins

Message ID 466F1311.9000301@cadsoft.de
State New
Headers

Commit Message

Klaus Schmidinger June 12, 2007, 9:41 p.m. UTC 
  On 06/12/07 22:54, alexander-riedel@t-online.de wrote:
> Hi,
> please try both patches together.
> I have also problems after ma first patch with softdevice translations,
> but now with Christian's patch is OK.

I haven't had much time to look into this, yet,
but I believe the attached patch should be all it takes
to fix this.

Can you please try this one?

Klaus

Comments

Alexander Riedel June 12, 2007, 10:21 p.m. UTC | #1 
unfortunately this patches do not fix Transtation problems complete.
i still have segmentation faults for example with softdevice plugin.
maybe this help: vdr has translation "none". softdevice as also
"none".....
at this translation "none" have i core dumps...

Klaus what about gettext? This ist better alternative to "Home-made"
converting.

Or minimaly without on the fly converting of i18n strings,  these string
use from the begin as utf8 strings.

??

-----Original Message-----
Date: Tue, 12 Jun 2007 23:41:37 +0200
Subject: Re: [vdr] vdr-1.5.3 - issue with translations out of plugins
From: Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>
To: vdr@linuxtv.org

On 06/12/07 22:54, alexander-riedel@t-online.de wrote:
> Hi,
> please try both patches together.
> I have also problems after ma first patch with softdevice
translations,
> but now with Christian's patch is OK.

I haven't had much time to look into this, yet,
but I believe the attached patch should be all it takes
to fix this.

Can you please try this one?

Klaus
Klaus Schmidinger June 13, 2007, 6:35 a.m. UTC | #2 
On 06/13/07 00:21, alexander-riedel@t-online.de wrote:
> unfortunately this patches do not fix Transtation problems complete.
> i still have segmentation faults for example with softdevice plugin.
> maybe this help: vdr has translation "none". softdevice as also
> "none".....
> at this translation "none" have i core dumps...

Well, it was just a quick shot.
I'll look into it over the weekened.

> Klaus what about gettext? This ist better alternative to "Home-made"
> converting.

In the long run this is the plan, but as a first step I wanted to
do the freetype and UTF-8 stuff separately.

> Or minimaly without on the fly converting of i18n strings,  these string
> use from the begin as utf8 strings.

At least the German texts need to remain iso8859-1, because I maintain
these myself ;-)

Klaus
Joachim Wilke June 13, 2007, 7:30 p.m. UTC | #3 
2007/6/12, Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>:
> I haven't had much time to look into this, yet,
> but I believe the attached patch should be all it takes
> to fix this.

It works here!

Regards,
Joachim.
Lucian Muresan June 29, 2007, 5:21 a.m. UTC | #4 
Hi Klaus,

Klaus Schmidinger wrote:
> On 06/13/07 00:21, alexander-riedel@t-online.de wrote:
>> unfortunately this patches do not fix Transtation problems complete.
>> i still have segmentation faults for example with softdevice plugin.
>> maybe this help: vdr has translation "none". softdevice as also
>> "none".....
>> at this translation "none" have i core dumps...
> 
> Well, it was just a quick shot.
> I'll look into it over the weekened.
> 
>> Klaus what about gettext? This ist better alternative to "Home-made"
>> converting.
> 
> In the long run this is the plan, but as a first step I wanted to
> do the freetype and UTF-8 stuff separately.
> 
>> Or minimaly without on the fly converting of i18n strings,  these string
>> use from the begin as utf8 strings.

If you remeber the thread almost 2 years ago, "OSD language settings 
stored as language code (was: i18n.c sorted)" 
http://linvdr.org/mailinglists/vdr/2005/11/msg00646.html at that time 
you first found it a good idea, then postponed it for 1.5.x. Right after 
that I also developed a working gettext patch based on this one, and of 
course, Alexander Riedel's UTF8-patch as it looked like at that time.
Now you integrated utf8/freetype in vanilla VDR yourself, and from what 
I've read (haven't tried or looked at the code yet) it seems you used at 
least parts of that UTF8 ideas. What plans do you have about gettext, 
how long would that run be? Would it make sense if I'd rework my gettext 
patch based on the current VDR developer version in the near future (I 
developed it exactly having in mind your sketched ideas fom that time

"There would be one file for each language in VDR itself, and each
plugin would also have its own set of language files. There will
also be a way of converting the exiting i18n files into the new
format." ). Interested (in the next weeks, not right now...)?

Lucian
Klaus Schmidinger June 30, 2007, 1:43 a.m. UTC | #5 
On 06/29/07 07:21, Lucian Muresan wrote:
> Hi Klaus,
> 
> Klaus Schmidinger wrote:
>> On 06/13/07 00:21, alexander-riedel@t-online.de wrote:
>>> unfortunately this patches do not fix Transtation problems complete.
>>> i still have segmentation faults for example with softdevice plugin.
>>> maybe this help: vdr has translation "none". softdevice as also
>>> "none".....
>>> at this translation "none" have i core dumps...
>> Well, it was just a quick shot.
>> I'll look into it over the weekened.
>>
>>> Klaus what about gettext? This ist better alternative to "Home-made"
>>> converting.
>> In the long run this is the plan, but as a first step I wanted to
>> do the freetype and UTF-8 stuff separately.
>>
>>> Or minimaly without on the fly converting of i18n strings,  these string
>>> use from the begin as utf8 strings.
> 
> If you remeber the thread almost 2 years ago, "OSD language settings 
> stored as language code (was: i18n.c sorted)" 
> http://linvdr.org/mailinglists/vdr/2005/11/msg00646.html at that time 
> you first found it a good idea, then postponed it for 1.5.x. Right after 
> that I also developed a working gettext patch based on this one, and of 
> course, Alexander Riedel's UTF8-patch as it looked like at that time.
> Now you integrated utf8/freetype in vanilla VDR yourself, and from what 
> I've read (haven't tried or looked at the code yet) it seems you used at 
> least parts of that UTF8 ideas. What plans do you have about gettext, 
> how long would that run be? Would it make sense if I'd rework my gettext 
> patch based on the current VDR developer version in the near future (I 
> developed it exactly having in mind your sketched ideas fom that time

I'm currently on vacation and won't be home until July 14.

I thought I had a gettext patch in my inbox, but apparently I
can't find it. Have you sent that to me before?

Just send me your patch as it is (doesn't necessarily need
to work with version 1.5.5 directly) and I'll take a look at it.

Klaus
diff mbox

Patch

--- i18n.c	2007/06/09 08:44:54	1.294
+++ i18n.c	2007/06/12 21:31:19
@@ -6851,7 +6851,8 @@ 
                    return t;
                 }
              }
-         p = Phrases;
+         p = OriginalPhrases = Phrases;
+         ConvertedPhrases = &Converted;
          }
      esyslog("%s%sno translation found for '%s' in language %d (%s)", Plugin ? Plugin : "", Plugin ? ": " : "", s, Setup.OSDLanguage, Phrases[0][Setup.OSDLanguage]);
      }