Re: Problem with vdr-1.4.4-1 and extrecmenu

  Klaus Schmidinger wrote:
> Add the line
> 
> #define uint64 uint64_t
> 
> to VDR/tools.h.
> 
> I'll add this in the next maintenance patch, too.
> In the long run all plugins should change this to uint64_t, though.

better, re-add it as typedef as it was before. Attached.

Cheers,

Udo
  

Udo Richter wrote:
> Klaus Schmidinger wrote:
>> Add the line
>>
>> #define uint64 uint64_t
>>
>> to VDR/tools.h.
>>
>> I'll add this in the next maintenance patch, too.
>> In the long run all plugins should change this to uint64_t, though.
> 
> better, re-add it as typedef as it was before. Attached.

I want to get rid of this completely, so it will be a #define
that, if possible, causes a compile time warning. And at some later
point I'll remove that #define.

Klaus
  

On Sunday 03 December 2006 15:53, Klaus Schmidinger wrote:
> Udo Richter wrote:
> > Klaus Schmidinger wrote:
> >> Add the line
> >>
> >> #define uint64 uint64_t
> >>
> >> to VDR/tools.h.
> >>
> >> I'll add this in the next maintenance patch, too.
> >> In the long run all plugins should change this to uint64_t, though.
> >
> > better, re-add it as typedef as it was before. Attached.
>
> I want to get rid of this completely, so it will be a #define
> that, if possible, causes a compile time warning. And at some later
> point I'll remove that #define.
>
> Klaus
>

Why not just keep it away. I think it is not too hard to replace that in the 
plugins.

Matthias
  

Matthias Schwarzott wrote:
> On Sunday 03 December 2006 15:53, Klaus Schmidinger wrote:
>> Udo Richter wrote:
>>> Klaus Schmidinger wrote:
>>>> Add the line
>>>>
>>>> #define uint64 uint64_t
>>>>
>>>> to VDR/tools.h.
>>>>
>>>> I'll add this in the next maintenance patch, too.
>>>> In the long run all plugins should change this to uint64_t, though.
>>> better, re-add it as typedef as it was before. Attached.
>> I want to get rid of this completely, so it will be a #define
>> that, if possible, causes a compile time warning. And at some later
>> point I'll remove that #define.
>>
>> Klaus
>>
> 
> Why not just keep it away. I think it is not too hard to replace that in the 
> plugins.
> 
> Matthias

You're probably right.
By the time I'll release the next maintenance patch I guess
all plugins will have been updated, anyway.

Klaus
  

Klaus Schmidinger wrote:
> Matthias Schwarzott wrote:
>> Why not just keep it away. I think it is not too hard to replace that 
>> in the plugins.
> 
> You're probably right.
> By the time I'll release the next maintenance patch I guess
> all plugins will have been updated, anyway.

This strikes on the control plugin and the streamdev plugin, both rather 
un-maintained. Plus, plugin maintainers may need to make sure / test, 
that adapted plugins also compile on 1.4.4 and earlier, as this may need 
an additional #include <stdint.h> here and there.

What about keeping it for the 1.4.x cycle and dropping it in the first 
1.5.x version?

Cheers,

Udo
  

Udo Richter wrote:
> Klaus Schmidinger wrote:
>> Matthias Schwarzott wrote:
>>> Why not just keep it away. I think it is not too hard to replace that 
>>> in the plugins.
>>
>> You're probably right.
>> By the time I'll release the next maintenance patch I guess
>> all plugins will have been updated, anyway.
> 
> This strikes on the control plugin and the streamdev plugin, both rather 
> un-maintained. Plus, plugin maintainers may need to make sure / test, 
> that adapted plugins also compile on 1.4.4 and earlier, as this may need 
> an additional #include <stdint.h> here and there.
> 
> What about keeping it for the 1.4.x cycle and dropping it in the first 
> 1.5.x version?

That's what I was heading at with the #define...

Klaus