wrong behaviour when mixing channel group selection and channel number entering

Message ID 449E4C4E.9000603@gmx.de
State New
Headers

Commit Message

Andreas Regel June 25, 2006, 8:41 a.m. UTC
  Hi,

I found a bug in vdr 1.4.1 with maintenance patch 1, that occurs when 
doing the following:

1. select a channel group using left/right keys
2. when the channel display is still open enter a channel number
3. wait until entered channel is tuned
4. press ok to remove window -> now the first channel in the previously 
selected group is tuned which is not the expected behaviour.

attached patch fixes the problem

Best regards,
Andreas
  

Comments

Klaus Schmidinger July 23, 2006, 9:25 a.m. UTC | #1
Andreas Regel wrote:
> Hi,
> 
> I found a bug in vdr 1.4.1 with maintenance patch 1, that occurs when 
> doing the following:
> 
> 1. select a channel group using left/right keys
> 2. when the channel display is still open enter a channel number
> 3. wait until entered channel is tuned
> 4. press ok to remove window -> now the first channel in the previously 
> selected group is tuned which is not the expected behaviour.
> 
> attached patch fixes the problem
> 
> ------------------------------------------------------------------------
> 
> --- menu.c.org	2006-06-25 10:33:23.000000000 +0200
> +++ menu.c	2006-06-25 10:34:19.000000000 +0200
> @@ -3170,6 +3170,7 @@
>              return osEnd;
>              }
>      case k1 ... k9:
> +         group = -1;
>           if (number >= 0) {
>              if (number > Channels.MaxNumber())
>                 number = Key - k0;
> 
> 
> ------------------------------------------------------------------------

Ok, this makes sense.

Just wondering: the line numbers are off by about 24 - do you
have other patches in there?

Klaus
  

Patch

--- menu.c.org	2006-06-25 10:33:23.000000000 +0200
+++ menu.c	2006-06-25 10:34:19.000000000 +0200
@@ -3170,6 +3170,7 @@ 
             return osEnd;
             }
     case k1 ... k9:
+         group = -1;
          if (number >= 0) {
             if (number > Channels.MaxNumber())
                number = Key - k0;