From patchwork Sat Apr 29 10:56:20 2006
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Tobias Grimm <listaccount@e-tobi.net>
X-Patchwork-Id: 12289
Received: from moutng.kundenserver.de ([212.227.126.177])
	by www.linuxtv.org with esmtp (Exim 4.50) id 1FZn89-0006OU-A1
	for vdr@linuxtv.org; Sat, 29 Apr 2006 12:56:53 +0200
Received: from [84.184.28.183] (helo=[192.168.30.10])
	by mrelayeu.kundenserver.de (node=mrelayeu1) with ESMTP (Nemesis),
	id 0MKwpI-1FZn7d1k4A-0002CV; Sat, 29 Apr 2006 12:56:41 +0200
Message-ID: <44534654.1030502@e-tobi.net>
Date: Sat, 29 Apr 2006 12:56:20 +0200
From: Tobias Grimm <listaccount@e-tobi.net>
User-Agent: Debian Thunderbird 1.0.7 (X11/20051017)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: VDR Mailing List <vdr@linuxtv.org>
Subject: Re: [vdr] [ANNOUNCE] VDR developer version 1.3.49 - Memleak
References: <44521D96.3060101@cadsoft.de>
In-Reply-To: <44521D96.3060101@cadsoft.de>
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	login:3a660adf8439ddc7be7d699eb4083112
X-BeenThere: vdr@linuxtv.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: VDR Mailing List <vdr@linuxtv.org>
List-Id: VDR Mailing List <vdr.linuxtv.org>
List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=unsubscribe>
List-Archive: <http://www.linuxtv.org/pipermail/vdr>
List-Post: <mailto:vdr@linuxtv.org>
List-Help: <mailto:vdr-request@linuxtv.org?subject=help>
List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Apr 2006 10:56:53 -0000
Status: O
X-Status: 
X-Keywords: 
X-UID: 9138

Klaus Schmidinger wrote:

> Please take a thorough look at the changes - especially the ones
> to the actual program code files - to help avoid any stupid last
> minute bugs.


When checking VDR with valgrind, I found a small memory leak. The
attached patch should fix it.

Regards,

Tobias

--- vdr-1.3.49.orig/eit.c
+++ vdr-1.3.49/eit.c
@@ -104,7 +104,10 @@
       cComponents *Components = NULL;
       for (SI::Loop::Iterator it2; (d = SiEitEvent.eventDescriptors.getNext(it2)); ) {
           if (ExternalData && d->getDescriptorTag() != SI::ComponentDescriptorTag)
+          {
+             delete d;
              continue;
+          }  
           switch (d->getDescriptorTag()) {
             case SI::ExtendedEventDescriptorTag: {
                  SI::ExtendedEventDescriptor *eed = (SI::ExtendedEventDescriptor *)d;