[ANNOUNCE] VDR developer version 1.3.49 - Memleak

Message ID 44534654.1030502@e-tobi.net
State New
Headers

Commit Message

Tobias Grimm April 29, 2006, 10:56 a.m. UTC
  Klaus Schmidinger wrote:

> Please take a thorough look at the changes - especially the ones
> to the actual program code files - to help avoid any stupid last
> minute bugs.


When checking VDR with valgrind, I found a small memory leak. The
attached patch should fix it.

Regards,

Tobias
  

Comments

Klaus Schmidinger April 29, 2006, 11:41 a.m. UTC | #1
Tobias Grimm wrote:
> Klaus Schmidinger wrote:
> 
>> Please take a thorough look at the changes - especially the ones
>> to the actual program code files - to help avoid any stupid last
>> minute bugs.
> 
> 
> When checking VDR with valgrind, I found a small memory leak. The
> attached patch should fix it.

Thanks - applied for version 1.4.0.

Klaus
  

Patch

--- vdr-1.3.49.orig/eit.c
+++ vdr-1.3.49/eit.c
@@ -104,7 +104,10 @@ 
       cComponents *Components = NULL;
       for (SI::Loop::Iterator it2; (d = SiEitEvent.eventDescriptors.getNext(it2)); ) {
           if (ExternalData && d->getDescriptorTag() != SI::ComponentDescriptorTag)
+          {
+             delete d;
              continue;
+          }  
           switch (d->getDescriptorTag()) {
             case SI::ExtendedEventDescriptorTag: {
                  SI::ExtendedEventDescriptor *eed = (SI::ExtendedEventDescriptor *)d;