From patchwork Wed Apr 5 06:55:36 2006 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harri Kaimio X-Patchwork-Id: 12245 Received: from fep32-0.kolumbus.fi ([193.229.0.63] helo=fep32-app.kolumbus.fi) by www.linuxtv.org with esmtp (Exim 4.50) id 1FR1vm-00019o-3X for vdr@linuxtv.org; Wed, 05 Apr 2006 08:55:54 +0200 Received: from [127.0.0.1] (really [80.186.66.73]) by fep32-app.kolumbus.fi with ESMTP id <20060405065552.HEEY18511.fep32-app.kolumbus.fi@[127.0.0.1]> for ; Wed, 5 Apr 2006 09:55:52 +0300 Message-ID: <443369E8.9020708@kaimio.fi> Date: Wed, 05 Apr 2006 09:55:36 +0300 From: Harri Kaimio User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: VDR Mailing List Subject: Re: [vdr] pvr350 TV out not working with VDR References: <443214C3.6060903@kaimio.fi> <443354DE.20903@kaimio.fi> In-Reply-To: <443354DE.20903@kaimio.fi> X-Enigmail-Version: 0.94.0.0 X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2006 06:55:54 -0000 Status: O X-Status: X-Keywords: X-UID: 8720 Well, that was easy. Here's the patch for pvr350 plugin: ------- ---- BR, H Harri Kaimio wrote: > Hi, > > status update: I got my TV-out working with VDR 1.3.41 and older > versions. So it seems that something changed between 1.3.41 and 1.3.44 > breaks the PVR350 plug-in. I'll try to find out the exact reason, any > help is appreciated... > > BR, H > > Harri Kaimio wrote: >> Hi, >> >> I am having problems installing PVR-350 as VDR output device. I have VDR >> 1.3.44 and vdr-pvr350 0.0.4pre1 plugin. I get only OSD information on my >> TV - no video nor audio. >> >> VDR works OK with softdevice and the PVR350 TV-out works with other >> software (I can even play VDR recordings using simply "cat > >> /dev/video16". So HW seems to be working but something in my VDR >> installation is broken. >> >> Any ideas? Or has anyone succeeded with this combination? >> >> BR, Harri >> >> >> _______________________________________________ >> vdr mailing list >> vdr@linuxtv.org >> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > _______________________________________________ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr diff -ur pvr350-0.0.4pre1/device.c /tmp/pvr350-0.0.4pre1/device.c --- pvr350-0.0.4pre1/device.c 2005-02-12 21:15:16.000000000 +0200 +++ /tmp/pvr350-0.0.4pre1/device.c 2006-04-05 09:08:54.000000000 +0300 @@ -321,7 +321,11 @@ streams to find out the aspect ratio that's needed */ #if VDRVERSNUM >= 10318 +#if VDRVERSNUM >= 10342 +int cPvr350Device::PlayAudio(const uchar *Data, int Length, uchar id ) +#else int cPvr350Device::PlayAudio(const uchar *Data, int Length) +#endif { return PlayVideo(Data,Length); } diff -ur pvr350-0.0.4pre1/device.h /tmp/pvr350-0.0.4pre1/device.h --- pvr350-0.0.4pre1/device.h 2005-02-12 21:14:25.000000000 +0200 +++ /tmp/pvr350-0.0.4pre1/device.h 2006-04-05 09:11:46.000000000 +0300 @@ -74,8 +74,12 @@ virtual void StillPicture(const uchar *Data, int Length); virtual int PlayVideo(const uchar *Data, int Length); #if VDRVERSNUM > 10318 +#if VDRVERSNUM >= 10342 + virtual int PlayAudio( const uchar *Data, int Length, uchar id ); +#else virtual int PlayAudio(const uchar *Data, int Length); #endif +#endif virtual void SetVideoFormat(bool VideoFormat16_9); virtual void SetVolumeDevice(int Volume); #if VDRVERSNUM < 10307