diff mbox

Wrong language selected from transmission (YLE2 Olympics)

Message ID 43FF1622.3040105@cadsoft.de
State New
Headers

Commit Message

Klaus Schmidinger Feb. 24, 2006, 2:20 p.m. UTC 
  Ville Aakko wrote:
> Ville Aakko kirjoitti viestissään (lähetysaika tiistai, 21. helmikuuta 2006 
> 14:19):
> 
>>Hi,
>>
>>It seems VDR chooses the wrong language on some transmission for some
>>reason. I have three favourite languages (i.e,. "Äänen kielet: 3") chosen
>>in VDR: Finnish, Swedish ang english. 
> 
> 
> I noticed the discussion "Audio channel problem" right after my posting. Maybe 
> these problems are related? 
> 
> When switching audio channel, I (too) only see numbers one and two. It seems 
> VDR chooses 1 as the default always, but on YLE2 Olympics the Finnish 
> commentary is on track 2 (and the Swedish on track 1). I can't confirm this 
> now since YLE2 is the only channel sending two different audio channels at 
> the moment.
> 
> So, maybe I should try this patch and see what it does on DVB-C, too?
> 
> <http://users.tkk.fi/~rahrenbe/vdr/vdr-1.3.43-audiotracks.diff.gz>

The actual problem was in cDevice::AttachPlayer().

Please try the attached patch (and revert to the original code in SetTrackDescriptions()
in case you have applied Rolf's patch).

If this doesn't help, please provide the channels.conf entry of the
channel, together with the epg.data entry of an event where you have
different audio languages.

Klaus

Comments

Ville Aakko Feb. 25, 2006, 6:21 p.m. UTC | #1 
2006/2/24, Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>:
> The actual problem was in cDevice::AttachPlayer().
>
> Please try the attached patch (and revert to the original code in SetTrackDescriptions()
> in case you have applied Rolf's patch).
>
> If this doesn't help, please provide the channels.conf entry of the
> channel, together with the epg.data entry of an event where you have
> different audio languages.

Hi,

The patch seems to work perfectly!

Well, it works for me at least for the Men's Slalom running just now.
Even the labels are correct (swe & fin, and the latter one selected as
default and contains the right language). Also, before applying the
patch I noticed the EPG was also in Swedish (I hadn't noticed that
before). It seems to be corrected with the patch above, too, or then
it was something else.

I also tried recording, and it seems it still automatically chooses
swedish. The audio choises for recordings are 2xfin (and "fin & 2" for
recordings made before applying your patch, it seems). The second
"fin" get's selected (but contains the Swedish commentary) for
default.

I don't think I'll be recording anything from these Olympics, so it
doesn't really matter for me, but if you need someone to test your
patches I sure can do that ;). Thanks!



--
--
Ville Aakko - ville.aakko@gmail.com
Klaus Schmidinger Feb. 26, 2006, 3:30 p.m. UTC | #2 
Ville Aakko wrote:
> 2006/2/24, Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>:
> 
>>The actual problem was in cDevice::AttachPlayer().
>>
>>Please try the attached patch (and revert to the original code in SetTrackDescriptions()
>>in case you have applied Rolf's patch).
>>
>>If this doesn't help, please provide the channels.conf entry of the
>>channel, together with the epg.data entry of an event where you have
>>different audio languages.
> 
> 
> Hi,
> 
> The patch seems to work perfectly!
> 
> Well, it works for me at least for the Men's Slalom running just now.
> Even the labels are correct (swe & fin, and the latter one selected as
> default and contains the right language). Also, before applying the
> patch I noticed the EPG was also in Swedish (I hadn't noticed that
> before). It seems to be corrected with the patch above, too, or then
> it was something else.
> 
> I also tried recording, and it seems it still automatically chooses
> swedish. The audio choises for recordings are 2xfin (and "fin & 2" for
> recordings made before applying your patch, it seems). The second
> "fin" get's selected (but contains the Swedish commentary) for
> default.
> 
> I don't think I'll be recording anything from these Olympics, so it
> doesn't really matter for me, but if you need someone to test your
> patches I sure can do that ;). Thanks!

If you encounter any case where the labels are wrong, please send me
the channels.conf entry of that channel, the info.vdr file of the recording
and the corresponding entry from the epg.data file.

Note that automatic laguage selection for replay doesn't work, yet.

Klaus
diff mbox

Patch

--- device.c	2006/02/04 14:58:24	1.123
+++ device.c	2006/02/24 14:05:26
@@ -934,10 +934,10 @@ 
   if (CanReplay()) {
      if (player)
         Detach(player);
-     if (!Transferring())
-        ClrAvailableTracks();
      pesAssembler->Reset();
      player = Player;
+     if (!Transferring())
+        ClrAvailableTracks();
      SetPlayMode(player->playMode);
      player->device = this;
      player->Activate(true);