Annoying bug with ttxtsubs

Message ID 43B95FB9.705@dnainternet.net
State New
Headers

Commit Message

Kimmo Taskinen Jan. 2, 2006, 5:15 p.m. UTC
  Hi,

I believe you provided a working patch for this already in August. You 
must have forgotten to apply it for the soppatykki edition. I didn't 
notice the problem because I had disabled EPG scan.

+ Kimmo


 


Rolf Ahrenberg wrote:

> On Tue, 27 Dec 2005, "Sami J. Mäkinen" wrote:
>
>> When watching live view with ttxt subtitles, it is working ok, always.
>> I have not seen subtitles from a wrong channel or anything similar.
>
>
> I guess your DVB card is doing EPG scanning on background while you're 
> watching recordings. Disable it to check if it cures the symptons. I 
> haven't used ttxtsubs plugin since early 2004, so you won't get any 
> "working" patches from the web page you mentioned unless someone sends 
> me fixes for things like that.
>
> BR,
> -- 
> rofa
>
> _______________________________________________
> vdr mailing list
> vdr@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
>
  

Comments

Rolf Ahrenberg Jan. 2, 2006, 7:16 p.m. UTC | #1
On Mon, 2 Jan 2006, Kimmo Taskinen wrote:

> I believe you provided a working patch for this already in August. You must 
> have forgotten to apply it for the soppatykki edition. I didn't notice the 
> problem because I had disabled EPG scan.

Well, I got reports that the change broke subtitling on some setups so I 
did drop it from soppatykki. However, if someone confirms that it really 
has some positive effects (with EPG scan enabled!) I'll add it back.

BR,
--
rofa
  

Patch

--- ttxtsubs.c.pe	2005-08-28 13:03:07.000000000 +0300
+++ ttxtsubs.c	2005-08-28 13:05:19.000000000 +0300
@@ -438,7 +438,7 @@ 
 #endif
   //dprint("cPluginTtxtsubs::ChannelSwitch(devicenr: %d, channelnr: %d) - mDispl: %x\n",  Device->DeviceNumber(), ChannelNumber, mDispl); // XXX
 
-  if(Device->IsPrimaryDevice()) {
+  if(Device->IsPrimaryDevice() && !Device->Replaying()) {
     if(ChannelNumber) {
       getchmutex.Lock();
       switchChannel=ChannelNumber;