From patchwork Tue Nov 15 22:16:46 2005
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Frank Scherthan <frank.scherthan@gmx.de>
X-Patchwork-Id: 12093
Received: from mail.gmx.net ([213.165.64.20])
	by www.linuxtv.org with smtp (Exim 4.50) id 1Ec978-0001Fm-Ta
	for vdr@linuxtv.org; Tue, 15 Nov 2005 23:17:18 +0100
Received: (qmail invoked by alias); 15 Nov 2005 22:16:48 -0000
Received: from p54AC955F.dip0.t-ipconnect.de (EHLO [192.168.0.2])
	[84.172.149.95]
	by mail.gmx.net (mp030) with SMTP; 15 Nov 2005 23:16:48 +0100
X-Authenticated: #596386
Message-ID: <437A5E4E.60408@gmx.de>
Date: Tue, 15 Nov 2005 23:16:46 +0100
From: Frank Scherthan <frank.scherthan@gmx.de>
User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051013)
X-Accept-Language: de-DE, de, en-us, en
MIME-Version: 1.0
To: VDR Mailing List <vdr@linuxtv.org>
Subject: Re: [vdr] [ANNOUNCE] vdr-autosort-0.0.6
References: <5.1.0.14.0.20051115101300.00a62b30@server2.server-einstellung.de>
In-Reply-To: 
 <5.1.0.14.0.20051115101300.00a62b30@server2.server-einstellung.de>
X-Y-GMX-Trusted: 0
X-BeenThere: vdr@linuxtv.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: VDR Mailing List <vdr@linuxtv.org>
List-Id: VDR Mailing List <vdr.linuxtv.org>
List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=unsubscribe>
List-Archive: <http://www.linuxtv.org/pipermail/vdr>
List-Post: <mailto:vdr@linuxtv.org>
List-Help: <mailto:vdr-request@linuxtv.org?subject=help>
List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Nov 2005 22:17:19 -0000
Status: O
X-Status: 
X-Keywords: 
X-UID: 6151

CopyPoint schrieb:
> 
>   ...first steps to usability...
> 
> http://www.copypointburscheid.de/linux/vdr-autosort-0.0.6.tgz
> 
> ------------------------------------------------------------------------------------------------------------------------------
> 
> 2005-11-14: Version 0.0.6
> 
> - Added a Setup Menu (described in README)
> - Added multi-level OSD-Messages to let you know whats going on
> - You can reload config and start a complete AutoSort-Run from mainmenu,
>     but VDR is unusable for this time (20min here).
>                  !!! USE WITH CARE !!
> - Housekeeping will be interrupted by any remote key now
> - Implemented 'SetCaFF' and 'SetCa0'. You need the patch to delete Ca
> special values (autosort will tell you)
> ------------------------------------------------------------------------------------------------------------------------------
> 
> 
> I hope it's a bit more comfortable now.

Yes! It is :)

There are still 3 warnings, nothing to care to much about
:
g++ -O2 -Wall -Woverloaded-virtual -c -D_GNU_SOURCE
-DPLUGIN_NAME_I18N='"autosort"' -I../../../include
-I/usr/src/linux/include autosort.c
autosort.c: In member function 'void cNewAutoSort::CheckDelimiters()':
autosort.c:929: warning: suggest parentheses around assignment used as
truth value
autosort.c:952: warning: suggest parentheses around assignment used as
truth value
autosort.c:974: warning: suggest parentheses around assignment used as
truth value

Happens with
g++ (GCC) 4.0.3 20051023 (prerelease) (Debian 4.0.2-3)

Attached a patch to get rid of the warnings...

Frank

diff -Naur autosort-0.0.6/autosort.c autosort-0.0.6_orig/autosort.c
--- autosort-0.0.6/autosort.c	2005-11-15 21:12:22.000000000 +0100
+++ autosort-0.0.6_orig/autosort.c	2005-11-15 23:13:35.000000000 +0100
@@ -926,7 +926,7 @@
     if (messageLevel >= 1) Skins.Message(mtStatus,"AutoSort: Check for missing Group Delimiters", messageTime);
     group = AutoGroups.GetFirstByOrder();    
     bool foundNext;
-    while (group = AutoGroups.GetNextByOrder(group->OIdx())){
+    while ((group = AutoGroups.GetNextByOrder(group->OIdx()))){
       foundNext = false;
       for (cChannel *channel = Channels.Get(Channels.GetNextGroup(firstGroupChIdx)); (channel && !foundNext); channel = Channels.Get(Channels.GetNextGroup(channel->Index()))) 
         {
@@ -949,7 +949,7 @@
       {      
       foundNext = false;
       group = AutoGroups.GetFirstByOrder();    
-      while (group = AutoGroups.GetNextByOrder(group->OIdx())){
+      while ((group = AutoGroups.GetNextByOrder(group->OIdx()))){
         if (strcmp(channel->Name(),group->Name()) == 0) 
           {
           foundNext = true;
@@ -971,7 +971,7 @@
     cAutoGroup *nextGroup = group;
     cChannel *channel = Channels.Get(group->GetChIndex());
 
-    while (nextGroup = AutoGroups.GetNextByOrder(group->OIdx())){
+    while ((nextGroup = AutoGroups.GetNextByOrder(group->OIdx()))){
       channel = Channels.Get(Channels.GetNextGroup(group->GetChIndex()));
       if (!strcmp(channel->Name(),nextGroup->Name())){
         group = nextGroup;