From patchwork Fri Sep 16 07:17:42 2005
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>
X-Patchwork-Id: 12028
Received: from tiger.cadsoft.de ([217.7.101.210])
	by www.linuxtv.org with esmtp (Exim 4.34) id 1EGATg-0001Lt-Di
	for vdr@linuxtv.org; Fri, 16 Sep 2005 09:17:44 +0200
Received: from raven.cadsoft.de (raven.cadsoft.de [217.7.101.211])
	by tiger.cadsoft.de (8.12.7/8.12.7) with ESMTP id j8G7Hhrc006782
	for <vdr@linuxtv.org>; Fri, 16 Sep 2005 09:17:43 +0200
Received: from [192.168.1.71] (falcon.cadsoft.de [192.168.1.71])
	by raven.cadsoft.de (8.13.3/8.13.3) with ESMTP id j8G7Hgom019082
	for <vdr@linuxtv.org>; Fri, 16 Sep 2005 09:17:42 +0200
Message-ID: <432A7196.8020207@cadsoft.de>
Date: Fri, 16 Sep 2005 09:17:42 +0200
From: Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>
Organization: CadSoft Computer GmbH
User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050317)
X-Accept-Language: en, de
MIME-Version: 1.0
To: vdr@linuxtv.org
Subject: Re: [vdr] VDR 1.3.32 crashes if recording date is in the future
References: 
 <!~!UENERkVCMDkAAQACAAAAAAAAAAAAAAAAABgAAAAAAAAA6B3JW8I230+fq5wrGgkhYcKAAAAQAAAA5yiJugIRlUKhsCDFcxoFJAEAAAAA@gmx.net>
In-Reply-To: 
 <!~!UENERkVCMDkAAQACAAAAAAAAAAAAAAAAABgAAAAAAAAA6B3JW8I230+fq5wrGgkhYcKAAAAQAAAA5yiJugIRlUKhsCDFcxoFJAEAAAAA@gmx.net>
X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-2.0
	(tiger.cadsoft.de [217.7.101.210]);
	Fri, 16 Sep 2005 09:17:43 +0200 (CEST)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(raven.cadsoft.de [192.168.1.1]);
	Fri, 16 Sep 2005 09:17:42 +0200 (CEST)
X-BeenThere: vdr@linuxtv.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Klaus Schmidinger's VDR <vdr@linuxtv.org>
List-Id: Klaus Schmidinger's VDR <vdr.linuxtv.org>
List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=unsubscribe>
List-Archive: <http://www.linuxtv.org/pipermail/vdr>
List-Post: <mailto:vdr@linuxtv.org>
List-Help: <mailto:vdr-request@linuxtv.org?subject=help>
List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Sep 2005 07:17:44 -0000
Status: O
X-Status: 
X-Keywords: 
X-UID: 5009

Marco Kremer wrote:
> Hi Klaus,
> 
> I tried 1.3.32 (plain, only remote-Plugin) and it always crashed with a
> "Speicherzugriffsfehler". I tried to debug it (i'm no programmer at all) and
> it fails at
> 
> [Switching to Thread -1208472992 (LWP 18423)]
> 0x080cb1d6 in cRecording (this=0x840f170,
>     FileName=0x840f114
> "Chaos_City/1x01_-_001_-_New_York_New_York_(Pilot)/2007-01-01.00.12.10.99.re
> c") at recording.c:506
> 506                         data[1] = (char *)realloc(data[1], len + 1 +
> strlen(data[2]) + 1);
> 
> I use future dates to reorder my recordings -> this doesn't happen with
> vdr-1.3.28.
> 
> Could this be changed ?

See the patch posted here by Achim Tuffentsammer <a.tuffentsammer@web.de>
yesterday:


Klaus

--- recording-org.c     2005-09-15 19:25:49.000000000 +0200
+++ recording.c 2005-09-15 19:26:15.000000000 +0200
@@ -500,7 +500,7 @@
                // if line 1 is too long, it can't be the short text,
                // so assume the short text is missing and concatenate
                // line 1 and line 2 to be the long text:
-              int len = strlen(data[1]);
+              int len = ( data[1] ) ? strlen(data[1]) : 0;
                if (len > 80) {
                   data[1] = (char *)realloc(data[1], len + 1 + strlen(data[2]) + 1);
                   strcat(data[1], "\n");