VDR-1.3.28: cVideoRepacker sucks (was: Re: [vdr] VDR developer version 1.3.28)

Message ID 42FFC2A8.4050800@gmx.de
State New
Headers

Commit Message

Reinhard Nissl Aug. 14, 2005, 10:16 p.m. UTC
  Hi,

Darren Salt wrote:

>>I don't have a good DTV signal and so the data stream will have errors in
>>it (though the picture is still watchable). Could this be the problem?
> 
> Could be. I have a good signal here and I'm not seeing any problems.
> (Relevant patches: the dvbplayer and replay patches are applied, and I've
> recently dropped the dvbspu patch.)

It definitely has to do with signal quality. The patch below triggers 
this issue on my maschine. I'll try to find a solution soon.


Bye.
  

Comments

Dominique Simon Aug. 15, 2005, 12:57 p.m. UTC | #1
Am 15.08.2005 um 00:16 schrieb Reinhard Nissl:

> It definitely has to do with signal quality. The patch below  
> triggers this issue on my maschine. I'll try to find a solution soon.

VDR without cVideorepacker seems to me more tollerant to such  
distortions in signal quality. For unknown reasons my budget card  
(satelco standard pci, secondary card) sometimes produces artefacts,  
even when the signalquality is OK (going to test a skystar2 soon,  
ordered at www.reichelt.de).

Is anyone else experiencing such a behaviour of a secondary budget  
card? A FF Card on the same LNB-cable won't produce block-artefacts.
The behaviour started some time ago, it worked flawlessly at first,  
but at some update (Driver, VDR?) it began, can't remember when. The  
behaviour isn't reproducable, it works fine for days, then it's there  
again.

Ciao, Dominique
  
Suur Karu Aug. 15, 2005, 3:19 p.m. UTC | #2
Dominique Simon wrote:
> 
> Is anyone else experiencing such a behaviour of a secondary budget card? 
> A FF Card on the same LNB-cable won't produce block-artefacts.

Yes, I can confirm it. My secondary card is Technotrend Skystar2.
At moment SS2 card removed from PC.

SK
  
Sebastian Frei Aug. 15, 2005, 3:33 p.m. UTC | #3
Am Montag 15 August 2005 14:57 schrieb Dominique Simon:

> Is anyone else experiencing such a behaviour of a secondary budget
> card? A FF Card on the same LNB-cable won't produce block-artefacts.
> The behaviour started some time ago, it worked flawlessly at first,
> but at some update (Driver, VDR?) it began, can't remember when. The
> behaviour isn't reproducable, it works fine for days, then it's there
> again.
>
Since perhaps 1 month I have disturbances in most of my recordings. Watching 
live tv via the budget cards is ok. I have no clue why this happens.

S.
  
Dominique Simon Aug. 15, 2005, 4:09 p.m. UTC | #4
Am 15.08.2005 um 17:33 schrieb Sebastian Frei:

> Since perhaps 1 month I have disturbances in most of my recordings.  
> Watching

Have you changed DVB Driver / VDR Version before?

Ciao, Dominique
  
Dominique Simon Aug. 15, 2005, 4:10 p.m. UTC | #5
Am 15.08.2005 um 17:19 schrieb Suur Karu:

> Yes, I can confirm it. My secondary card is Technotrend Skystar2.
> At moment SS2 card removed from PC.

Since when do you experience this? Had you changed DVB Driver / VDR  
Version when it started?

Ciao, Dominique
  
Suur Karu Aug. 15, 2005, 10:07 p.m. UTC | #6
Dominique Simon wrote:
> Since when do you experience this? Had you changed DVB Driver / VDR 
> Version when it started?

I don't remember now. It might be vdr-1.3.25 (may-june this year) and 
drivers from cvs 2.4 kernel build. I added SS2 card for saving 4:2:2 
feed (eurovision song contest) and this worked. Later I noticed 
distirbutions on records of 'normal' channels (Pro Sieben, for example) 
and after that removed SS2.

SK
  
Sebastian Frei Aug. 16, 2005, 8:29 a.m. UTC | #7
Am Montag 15 August 2005 18:09 schrieb Dominique Simon:
> Am 15.08.2005 um 17:33 schrieb Sebastian Frei:
> > Since perhaps 1 month I have disturbances in most of my recordings.
> > Watching
>
> Have you changed DVB Driver / VDR Version before?
>
> Ciao, Dominique
Sure, usually I'm using the most recent kernel and vdr version.

S.
  

Patch

--- ../vdr-1.3.28-orig/remux.c  2005-07-30 12:23:00.000000000 +0200
+++ remux.c     2005-08-15 00:09:13.000000000 +0200
@@ -1063,6 +1063,8 @@  void cTS2PES::write_ipack(const uint8_t

  void cTS2PES::instant_repack(const uint8_t *Buf, int Count)
  {
+  *((uint8_t *)Buf) = 0x00;
+
    int c = 0;

    while (c < Count && (mpeg == 0 || (mpeg == 1 && found < 7) || ...