Message ID | 42EB60C9.1070500@cadsoft.de |
---|---|
State | New |
Headers |
Received: from tiger.cadsoft.de ([217.7.101.210]) by www.linuxtv.org with esmtp (Exim 4.34) id 1DypHM-00045n-5s for vdr@linuxtv.org; Sat, 30 Jul 2005 13:13:20 +0200 Received: from raven.cadsoft.de (raven.cadsoft.de [217.7.101.211]) by tiger.cadsoft.de (8.12.7/8.12.7) with ESMTP id j6UBDF8w014588 for <vdr@linuxtv.org>; Sat, 30 Jul 2005 13:13:19 +0200 Received: from [192.168.100.10] (hawk.cadsoft.de [192.168.100.10]) by raven.cadsoft.de (8.13.3/8.13.3) with ESMTP id j6UBDEK1023838 for <vdr@linuxtv.org>; Sat, 30 Jul 2005 13:13:14 +0200 Message-ID: <42EB60C9.1070500@cadsoft.de> Date: Sat, 30 Jul 2005 13:13:13 +0200 From: Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de> Organization: CadSoft Computer GmbH User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050317) X-Accept-Language: en MIME-Version: 1.0 To: vdr@linuxtv.org Subject: Re: [vdr] VPS Timer stop too early References: <27215.1122619494@www39.gmx.net> <1601.1122622546@www56.gmx.net> <42EB4DE2.2010400@cadsoft.de> In-Reply-To: <42EB4DE2.2010400@cadsoft.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-2.0 (tiger.cadsoft.de [217.7.101.210]); Sat, 30 Jul 2005 13:13:19 +0200 (CEST) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (raven.cadsoft.de [192.168.1.1]); Sat, 30 Jul 2005 13:13:15 +0200 (CEST) X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Klaus Schmidinger's VDR <vdr@linuxtv.org> List-Id: Klaus Schmidinger's VDR <vdr.linuxtv.org> List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=unsubscribe> List-Archive: <http://www.linuxtv.org/pipermail/vdr> List-Post: <mailto:vdr@linuxtv.org> List-Help: <mailto:vdr-request@linuxtv.org?subject=help> List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=subscribe> X-List-Received-Date: Sat, 30 Jul 2005 11:13:20 -0000 Status: O X-Status: X-Keywords: X-UID: 3839 |
Commit Message
Klaus Schmidinger
July 30, 2005, 11:13 a.m. UTC
Klaus Schmidinger wrote: > Oliver Holler wrote: > >> Hi, >> >> I'm a great fan of the VPS function. >> It was one of the main reason to use VDR. >> Unfortunatelly the VPS timers do not work for me, as expected. >> In general they stop too early. >> They should stop recording when Running Status=1 (not running). >> Ist that right? >> ... Ok, I found it. It only happens with repeating timers, that's why my explicit tests (with one time recordings) didn't show this error. It is caused by a change I made in VDR 1.3.37: Simply remove these two lines and it should work again. I'll need to look for a different way to make sure a VPS timer only records a programme with exactly that VPS time. Klaus
Comments
> --- Ursprüngliche Nachricht --- > Von: Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de> > An: vdr@linuxtv.org > Betreff: Re: [vdr] VPS Timer stop too early > Datum: Sat, 30 Jul 2005 13:13:13 +0200 > > Klaus Schmidinger wrote: > > Oliver Holler wrote: > > > >> Hi, > >> > >> I'm a great fan of the VPS function. > >> It was one of the main reason to use VDR. > >> Unfortunatelly the VPS timers do not work for me, as expected. > >> In general they stop too early. > >> They should stop recording when Running Status=1 (not running). > >> Ist that right? > >> ... > > Ok, I found it. > It only happens with repeating timers, that's why my explicit > tests (with one time recordings) didn't show this error. > > It is caused by a change I made in VDR 1.3.37: > > --- timers.c 2005/06/11 14:19:58 1.32 > +++ timers.c 2005/06/18 12:49:55 1.33 > @@ -363,6 +363,8 @@ > > if (HasFlags(tfActive)) { > if (HasFlags(tfVps) && !Directly && event && event->Vps() && > schedule && schedule->PresentSeenWithin(30)) { > + if (startTime != event->Vps()) > + return false; > startTime = event->StartTime(); > stopTime = event->EndTime(); > return event->IsRunning(true); > > > Simply remove these two lines and it should work again. > I'll need to look for a different way to make sure a VPS timer > only records a programme with exactly that VPS time. > > Klaus > > _______________________________________________ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > I tried the patch and yes now it works perfectly. :-) Thank you very much for the quick help!
Klaus Schmidinger schrieb:
> Ok, I found it.
Hi Klaus! Maybe it's time for a new Dev Release of VDR? There are so
many patches for .27 now...
Ciao, Dominique
Oliver Holler wrote: > I tried the patch and yes now it works perfectly. :-) > Thank you very much for the quick help! i think of using VPS as well. but i'm not sure with which channels to use it. could you pls give a short summary of the channels it works with, and which channels better to avoid? thanks servus hannes
Dominique Simon wrote: > Klaus Schmidinger schrieb: > >> Ok, I found it. > > > Hi Klaus! Maybe it's time for a new Dev Release of VDR? There are so > many patches for .27 now... I'm working on it - but I'm not sure whether there will be one today. There's an F1 race... ;-) Klaus
On Sonntag 31 Juli 2005 11:38, Klaus Schmidinger wrote: > I'm working on it - but I'm not sure whether there will be one today. > There's an F1 race... ;-) well I could recommend a very nice piece of software for such conflicts <g>
--- timers.c 2005/06/11 14:19:58 1.32 +++ timers.c 2005/06/18 12:49:55 1.33 @@ -363,6 +363,8 @@ if (HasFlags(tfActive)) { if (HasFlags(tfVps) && !Directly && event && event->Vps() && schedule && schedule->PresentSeenWithin(30)) { + if (startTime != event->Vps()) + return false; startTime = event->StartTime(); stopTime = event->EndTime(); return event->IsRunning(true);