From patchwork Sun Jun 19 10:12:07 2005 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Klaus Schmidinger X-Patchwork-Id: 11919 Received: from tiger.cadsoft.de ([217.7.101.210]) by www.linuxtv.org with esmtp (Exim 4.34) id 1Djwmh-0001UD-NV for vdr@linuxtv.org; Sun, 19 Jun 2005 12:12:11 +0200 Received: from raven.cadsoft.de (raven.cadsoft.de [217.7.101.211]) by tiger.cadsoft.de (8.12.7/8.12.7) with ESMTP id j5JACBMC002878 for ; Sun, 19 Jun 2005 12:12:11 +0200 Received: from [192.168.100.10] (hawk.cadsoft.de [192.168.100.10]) by raven.cadsoft.de (8.13.3/8.13.3) with ESMTP id j5JAC96e032641 for ; Sun, 19 Jun 2005 12:12:10 +0200 Message-ID: <42B544F7.3010607@cadsoft.de> Date: Sun, 19 Jun 2005 12:12:07 +0200 From: Klaus Schmidinger Organization: CadSoft Computer GmbH User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050317) X-Accept-Language: en MIME-Version: 1.0 To: vdr@linuxtv.org Subject: Re: [vdr] [ANNOUNCE] vdr 1.3 SUSE RPMs References: <20050614114445.GA25534@suse.de> <42B28F4B.5080604@icem.com> <20050617094409.GB3507@suse.de> <42B2A9FC.40104@icem.com> In-Reply-To: <42B2A9FC.40104@icem.com> X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Klaus Schmidinger's VDR List-Id: Klaus Schmidinger's VDR List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2005 10:12:11 -0000 Status: O X-Status: X-Keywords: X-UID: 3108 Carsten Koch wrote: > Ludwig Nussel wrote: > >> Carsten Koch wrote: >> >>> Ludwig Nussel wrote: >>> >>>> I've built RPM packages for 1.3.26. Video directory and epg file >>>> location is the same as in the 1.2.6 packages, config files are in >>>> /etc/vdr13 instead of /etc/vdr. So you can safely install 1.3 in >>>> parallel to the 1.2.6 packages. vdr contains minimal patches. the su >>>> patch, the patch to use a broadcast variable instead of sleep in >>>> cDvbPlayer and pagedown.diff from Udo Richter. I also removed the >>>> check for NPTL and vdr does run with NPTL if available. >>> >>> >>> I absolutely cannot use VDR without the SourceCaps patch, since I >>> have 3 DVB-S cards connected to 2 different dishes. >> >> >> >> I've never heard about that one or forgot about it because I don't >> need it. Was it ever posted here for official inclusion? > > > Yes. > It startet on January 18th, 2004 with a posting by Christian Schuld > (the patch author). > I posted a version on April 6th, 2005, that was adopted to the latest > VDR, see attachment. > > >>> I also kind of like my own "delete_resume" patch which dramatically >>> reduces the number of redundant resume.vdr files. See my posting >>> from March 3rd, 2005. Of course, that patch is just "nice to have", >>> not "cannot live without it". > > > It started on January 30th, 2005. > I posted it again on March 21st. > See second attachment. > > >>> I guess there will be many people who require one or another patch >>> before they can use vdr. >>> >>> Any ideas? >> >> >> >> Try to convince Klaus to include the patches. I'd like to keep vdr >> 1.3 patches in the package to a minimum at the moment so Klaus can >> be blamed for bugs rather than the patches ;-) > > > OK. > > Klaus, as I said above, on a system without diseqc and with more than > one dish, I believe Christian's SourceCaps patch is a must. > It's also not very complicated and thus should not impose a high > risk of breaking something in vdr. Well, I still believe that the majority of systems will have only one LNB, anyway, and any reasonable multi-LNB system should use a multiswitch. Anyway, am I missing something here, or will this patch _require_ SourceCaps to be set? If I look at bool cDvbDevice::ProvidesSource(int Source) const { int type = Source & cSource::st_Mask; + if(type == cSource::stSat && frontendType == FE_QPSK) + { + for(int i = 0;i My patch is just a performance optimization. On a system with very > many recordings, it can become quite significant, though. > It is even smaller than the SourceCaps patch, though > and thus should not impose any risk of breaking something in vdr. This is probably not worth the effort, because in a future VDR version I will most likely store the selected audio track in that file, too, and then deleting it wouldn't make sense any more. Klaus diff -ru /hetis/home/cko/VDR/sources.c VDR/sources.c --- /hetis/home/cko/VDR/sources.c 2004-12-26 12:58:52.000000000 +0100 +++ VDR/sources.c 2005-04-05 22:12:55.421326944 +0200 @@ -68,7 +68,7 @@ int pos = 0; bool dot = false; bool neg = false; - while (*++s) { + while (*++s && !isblank(*s)) { switch (toupper(*s)) { case '0' ... '9': pos *= 10; pos += *s - '0';