diff mbox

VDR developer version 1.3.26

Message ID 42AC4E66.20003@cadsoft.de
State New
Headers

Commit Message

Klaus Schmidinger June 12, 2005, 3:01 p.m. UTC 
  Klaus Schmidinger wrote:
> VDR developer version 1.3.26 is now available at
> 
>     ftp://ftp.cadsoft.de/vdr/Developer/vdr-1.3.26.tar.bz2
> ...

Well, looks like the change in handling "page down" in menus
made it impossible to get the last page of a menu to display
full screen. Here's a small fix for that:



Klaus

Comments

Michael Reinelt June 12, 2005, 5:28 p.m. UTC | #1 
> Well, looks like the change in handling "page down" in menus
> made it impossible to get the last page of a menu to display
> full screen. Here's a small fix for that:

I'm afraid that doesn't fix another odd behaviour: If there's only one
page, I was used to press "PgDn" to quickliy jump to the last entry.
(Example: "Setup" - "Restart")

Now after I press "PgDn" I get a new page with only one line reading
"Neustart" (Restart), which is *not* marked. If I press "Up" the menu
gets quite garbled....



bye, Michael
Klaus Schmidinger June 12, 2005, 5:46 p.m. UTC | #2 
Michael Reinelt wrote:
>>Well, looks like the change in handling "page down" in menus
>>made it impossible to get the last page of a menu to display
>>full screen. Here's a small fix for that:
> 
> 
> I'm afraid that doesn't fix another odd behaviour: If there's only one
> page, I was used to press "PgDn" to quickliy jump to the last entry.
> (Example: "Setup" - "Restart")
> 
> Now after I press "PgDn" I get a new page with only one line reading
> "Neustart" (Restart), which is *not* marked. If I press "Up" the menu
> gets quite garbled....

Yea, looks like I was drunk when I made the changes.
I'll go over it again...

Klaus
diff mbox

Patch

--- osdbase.c   2005/06/12 10:44:22     1.17
+++ osdbase.c   2005/06/12 14:58:40
@@ -362,7 +362,7 @@ 
    if (current >= 0) {
       if (current < first)
          first = current;
-     else if (current - first >= displayMenuItems)
+     if (current - first >= displayMenuItems || current == last)
          first = current - displayMenuItems + 1;
       }
    if (current != oldCurrent || first != oldFirst) {