From patchwork Sun Jun 12 12:01:12 2005 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andreas Brugger X-Patchwork-Id: 11910 Received: from mail.gmx.de ([213.165.64.20] helo=mail.gmx.net) by www.linuxtv.org with smtp (Exim 4.34) id 1DhR9u-0000Vw-Sd for vdr@linuxtv.org; Sun, 12 Jun 2005 14:01:46 +0200 Received: (qmail invoked by alias); 12 Jun 2005 12:01:15 -0000 Received: from adsl-135.198.166.194.arpa.as1901.net (EHLO [192.168.0.3]) [194.166.198.135] by mail.gmx.net (mp006) with SMTP; 12 Jun 2005 14:01:15 +0200 X-Authenticated: #907334 Received: from 127.0.0.1 (AVG SMTP 7.0.323 [267.6.7]); Sun, 12 Jun 2005 14:01:12 +0200 Message-ID: <42AC2408.1010502@gmx.net> Date: Sun, 12 Jun 2005 14:01:12 +0200 From: Andreas Brugger User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en MIME-Version: 1.0 To: Klaus Schmidinger's VDR Subject: Re: [vdr] Plugin: "undelete-0.0.2" does not compile with 1.3.25 References: <9Y3lJJFMgjB@zocki.toppoint.de> <429CEB25.3030007@syphir.sytes.net> <429CF66F.5030704@syphir.sytes.net> In-Reply-To: <429CF66F.5030704@syphir.sytes.net> X-Y-GMX-Trusted: 0 X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Klaus Schmidinger's VDR List-Id: Klaus Schmidinger's VDR List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Jun 2005 12:01:47 -0000 Status: O X-Status: X-Keywords: X-UID: 2984 Hi! Thank you for the patch. I get two rejects in menuundelete.c here if I try the patch against a plain 0.0.2-version of the plugin. I've worked the rejects in and made a new patch which works here. Bye, Andreas Brugger C.Y.M schrieb: >C.Y.M wrote: > > >>Rainer Zocholl wrote: >> >> >> >>>Hello >>> >>>undelete-0.0.2 does not compile anymore, >>>does someone already have a patch? >>> >>> >>>make[1]: Entering directory >>>`/video/vdr-1.3.25.patched/PLUGINS/src/undelete-0.0.2' >>>g++ -O2 -Wall -Woverloaded-virtual -g -c -DPLUGIN_NAME_I18N='"undelete"' >>>-D_GNU_SOURCE -DUND_Debug1 -DUND_Debug2 -DUND_Debug3 -I../../../include >>>-I../../../../DVB/include menuundelete.c >>>menuundelete.c: In member function `void >>>cMenuRecordingSelect::SetHelpKeys()': >>>menuundelete.c:197: error: `Summary' undeclared (first use this function) >>>menuundelete.c:197: error: (Each undeclared identifier is reported only once >>> for each function it appears in.) >>>menuundelete.c: In member function èOSState cMenuRecordingSelect::Summary()': >>>menuundelete.c:293: error: `Summary' undeclared (first use this function) >>>make[1]: *** [menuundelete.o] Error 1 >>>make[1]: Leaving directory >>>`/video/vdr-1.3.25.patched/PLUGINS/src/undelete-0.0.2' >>> >>> >>> >>> >>http://www.vdrportal.de/board/attachment.php?attachmentid=6165&sid=0598044b21d018b11b41d55fcdfb2802 >> >> >> >> >Scratch that link.. the patch on vdrportal seems to have a few mistakes. Here >is one I just put together instead. > >Best Regards, > > >------------------------------------------------------------------------ > >--- menuundelete.c.orig 2005-05-31 16:18:52.000000000 -0700 >+++ menuundelete.c 2005-05-31 16:33:59.000000000 -0700 >@@ -194,7 +194,11 @@ > else > { > cRecording *recording = GetRecording(ri); >+#if VDRVERSNUM >= 10325 >+ SetHelp(NULL, tr("Undelete"), tr("Delete"), (recording && recording->Info()->Description() && *recording->Info()->Description()) ? tr("Info") : NULL); >+#else > SetHelp(NULL, tr("Undelete"), tr("Delete"), (recording && recording->Summary() && *recording->Summary()) ? tr("Summary") : NULL); >+#endif > } > } else > { >@@ -290,9 +294,17 @@ > if (ri && !ri->IsDirectory()) > { > cRecording *recording = GetRecording(ri); >+#if VDRVERSNUM >= 10325 >+ if (recording && recording->Info()->Description() && *recording->Info()->Description()) >+#else > if (recording && recording->Summary() && *recording->Summary()) >+#endif > #if VDRVERSNUM >= 10307 >+#if VDRVERSNUM >= 10325 >+ return AddSubMenu(new cMenuText(tr("Info"), recording->Info()->Description())); >+#else > return AddSubMenu(new cMenuText(tr("Summary"), recording->Summary())); >+#endif > #else > return AddSubMenu(new cMenuItemText(tr("Summary"), recording->Summary())); > #endif > > >------------------------------------------------------------------------ > >_______________________________________________ >vdr mailing list >vdr@linuxtv.org >http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > diff -Nru undelete-0.0.2_plain/menuundelete.c undelete-0.0.2/menuundelete.c --- undelete-0.0.2_plain/menuundelete.c 2004-10-10 12:23:20.000000000 +0200 +++ undelete-0.0.2/menuundelete.c 2005-06-12 13:34:08.000000000 +0200 @@ -193,8 +193,12 @@ SetHelp(tr("Open"), tr("Undelete"), tr("Delete"), NULL); else { - cRecording *recording = GetRecording(ri); - SetHelp(NULL, tr("Undelete"), tr("Delete"), (recording && recording->Summary() && *recording->Summary()) ? tr("Summary") : NULL); + cRecording *recording = GetRecording(ri); +#if VDRVERSNUM >= 10325 + SetHelp(NULL, tr("Undelete"), tr("Delete"), (recording && recording->Info()->Description() && *recording->Info()->Description()) ? tr("Info") : NULL); +#else + SetHelp(NULL, tr("Undelete"), tr("Delete"), (recording && recording->Summary() && *recording->Summary()) ? tr("Summary") : NULL); +#endif } } else { @@ -290,9 +294,17 @@ if (ri && !ri->IsDirectory()) { cRecording *recording = GetRecording(ri); +#if VDRVERSNUM >= 10325 + if (recording && recording->Info()->Description() && *recording->Info()->Description()) +#else if (recording && recording->Summary() && *recording->Summary()) +#endif #if VDRVERSNUM >= 10307 +#if VDRVERSNUM >= 10325 + return AddSubMenu(new cMenuText(tr("Info"), recording->Info()->Description())); +#else return AddSubMenu(new cMenuText(tr("Summary"), recording->Summary())); +#endif #else return AddSubMenu(new cMenuItemText(tr("Summary"), recording->Summary())); #endif