From patchwork Fri Jun 10 15:25:59 2005 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian X-Patchwork-Id: 11909 Received: from imap.gmx.net ([213.165.64.20] helo=mail.gmx.net) by www.linuxtv.org with smtp (Exim 4.34) id 1DglOy-0004Xl-0L for vdr@linuxtv.org; Fri, 10 Jun 2005 17:26:32 +0200 Received: (qmail invoked by alias); 10 Jun 2005 15:26:01 -0000 Received: from 0-184.vpn.RWTH-Aachen.DE (EHLO [134.130.240.184]) [134.130.240.184] by mail.gmx.net (mp023) with SMTP; 10 Jun 2005 17:26:01 +0200 X-Authenticated: #24128601 Message-ID: <42A9B107.2050505@gmx.net> Date: Fri, 10 Jun 2005 17:25:59 +0200 From: Sebastian User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050608) X-Accept-Language: de-DE, de, en-us, en MIME-Version: 1.0 To: Klaus Schmidinger's VDR Subject: Re: [vdr] Request: Change Dolby Digital handling References: <42A9AAE0.6040101@gmail.com> In-Reply-To: <42A9AAE0.6040101@gmail.com> X-Enigmail-Version: 0.91.0.0 X-Y-GMX-Trusted: 0 X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: sebastian_ml@gmx.net, Klaus Schmidinger's VDR List-Id: Klaus Schmidinger's VDR List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2005 15:26:32 -0000 Status: O X-Status: X-Keywords: X-UID: 2932 Anssi Hannula schrieb: > peter.dittmann@freenet.de wrote: > >>> CAC> : >>> CAC> CAC> > if you set 'use Dolby Digital', your recordings will >>> contain DD. >>> CAC> > If you don't want to hear DD, just select a non-DD track in the >>> audio >>> CAC> Hm, I will give it a try, but as far as I know it wont work vor >>> DVD-Audio >>> CAC> thenm as it is 'downsampled' within the DVB-Card. Right? >>> >>> I never tried it with DVD. If it doesn't work as expected, it should >>> not use 'use Dolby Digital' setup option for playback. >> >> >> >> Yes, the DVD plugin is broken as it uses 'useDolbyDigital' >> >> However I would also like to have seperate settings for use/record DD. >> Please consider a novice user (WAF ;-) ) and a system were DD schould be >> recorded (for DVD) but has no DD capable receiver attached. It's easy >> with >> audio button to switch to DD and end up with no audio. >> >> I personal belive the 'use DD' should be used to control the output >> capability. >> So on a box without DD output being used, the audio menu will not >> allow to >> switch to DD (or alternatively decode DD and downmix to stereo on >> analoge out). >> However the recording to disc should be able to contain DD. >> > > I would also like to be able to record DD streams. But if I enable the > useDolbyDigital, the VDR might try to use DD for playing also and I do > not have the DD equipment. Yes, I could change the audio stream with the > audio button, but I don't like that I would have to change audio of > every channel. Also, when the DVD plugin implements correct > "useDolbyDigital" usage (correct me if I'm wrong, but that means to > offer the audio tracks in the VDR Audio menu), I would have to switch > every DVD to non-DD track also. > > I'd like a separate option for playing and recording. > >> P.S. Sorry if webmail client break thread ;-) > > > It did not :) > You can try this patch. Cheers S. diff -Nur vdr-1.3.24_old/config.c vdr-1.3.24/config.c --- vdr-1.3.24_old/config.c 2005-02-20 13:52:59.000000000 +0100 +++ vdr-1.3.24/config.c 2005-05-26 21:38:53.000000000 +0200 @@ -283,6 +283,7 @@ VideoFormat = 0; UpdateChannels = 4; UseDolbyDigital = 1; + UseDolbyInRecordings = 1; ChannelInfoPos = 0; ChannelInfoTime = 5; OSDLeft = 54; @@ -440,6 +441,7 @@ else if (!strcasecmp(Name, "VideoFormat")) VideoFormat = atoi(Value); else if (!strcasecmp(Name, "UpdateChannels")) UpdateChannels = atoi(Value); else if (!strcasecmp(Name, "UseDolbyDigital")) UseDolbyDigital = atoi(Value); + else if (!strcasecmp(Name, "UseDolbyInRecordings")) UseDolbyInRecordings = atoi(Value); else if (!strcasecmp(Name, "ChannelInfoPos")) ChannelInfoPos = atoi(Value); else if (!strcasecmp(Name, "ChannelInfoTime")) ChannelInfoTime = atoi(Value); else if (!strcasecmp(Name, "OSDLeft")) OSDLeft = atoi(Value); @@ -504,6 +506,7 @@ Store("VideoFormat", VideoFormat); Store("UpdateChannels", UpdateChannels); Store("UseDolbyDigital", UseDolbyDigital); + Store("UseDolbyInRecordings", UseDolbyInRecordings); Store("ChannelInfoPos", ChannelInfoPos); Store("ChannelInfoTime", ChannelInfoTime); Store("OSDLeft", OSDLeft); diff -Nur vdr-1.3.24_old/config.h vdr-1.3.24/config.h --- vdr-1.3.24_old/config.h 2005-05-05 13:04:18.000000000 +0200 +++ vdr-1.3.24/config.h 2005-05-26 21:39:03.000000000 +0200 @@ -241,6 +241,7 @@ int VideoFormat; int UpdateChannels; int UseDolbyDigital; + int UseDolbyInRecordings; int ChannelInfoPos; int ChannelInfoTime; int OSDLeft, OSDTop, OSDWidth, OSDHeight; diff -Nur vdr-1.3.24_old/menu.c vdr-1.3.24/menu.c --- vdr-1.3.24_old/menu.c 2005-03-20 16:14:51.000000000 +0100 +++ vdr-1.3.24/menu.c 2005-05-26 21:39:09.000000000 +0200 @@ -2168,6 +2168,7 @@ cMenuSetupRecord::cMenuSetupRecord(void) { SetSection(tr("Recording")); + Add(new cMenuEditBoolItem( tr("Setup.Recording$Record Dolby"), &data.UseDolbyInRecordings)); Add(new cMenuEditIntItem( tr("Setup.Recording$Margin at start (min)"), &data.MarginStart)); Add(new cMenuEditIntItem( tr("Setup.Recording$Margin at stop (min)"), &data.MarginStop)); Add(new cMenuEditIntItem( tr("Setup.Recording$Primary limit"), &data.PrimaryLimit, 0, MAXPRIORITY)); diff -Nur vdr-1.3.24_old/recorder.c vdr-1.3.24/recorder.c --- vdr-1.3.24_old/recorder.c 2005-01-16 13:53:17.000000000 +0100 +++ vdr-1.3.24/recorder.c 2005-05-26 21:39:15.000000000 +0200 @@ -128,7 +128,7 @@ } cRecorder::cRecorder(const char *FileName, int Ca, int Priority, int VPid, const int *APids, const int *DPids, const int *SPids) -:cReceiver(Ca, Priority, VPid, APids, Setup.UseDolbyDigital ? DPids : NULL, SPids) +:cReceiver(Ca, Priority, VPid, APids, Setup.UseDolbyInRecordings ? DPids : NULL, SPids) ,cThread("recording") { active = false; @@ -139,7 +139,7 @@ ringBuffer = new cRingBufferLinear(RECORDERBUFSIZE, TS_SIZE * 2, true, "Recorder"); ringBuffer->SetTimeouts(0, 100); - remux = new cRemux(VPid, APids, Setup.UseDolbyDigital ? DPids : NULL, SPids, true); + remux = new cRemux(VPid, APids, Setup.UseDolbyInRecordings ? DPids : NULL, SPids, true); writer = new cFileWriter(FileName, remux); }