From patchwork Fri Jun 3 13:24:28 2005 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Klaus Schmidinger X-Patchwork-Id: 11904 Received: from tiger.cadsoft.de ([217.7.101.210]) by www.linuxtv.org with esmtp (Exim 4.34) id 1DeCA3-00014p-Qh for vdr@linuxtv.org; Fri, 03 Jun 2005 15:24:31 +0200 Received: from raven.cadsoft.de (raven.cadsoft.de [217.7.101.211]) by tiger.cadsoft.de (8.12.7/8.12.7) with ESMTP id j53DOUMC017232 for ; Fri, 3 Jun 2005 15:24:30 +0200 Received: from [192.168.100.10] (hawk.cadsoft.de [192.168.100.10]) by raven.cadsoft.de (8.13.3/8.13.3) with ESMTP id j53DOTSM015896 for ; Fri, 3 Jun 2005 15:24:29 +0200 Message-ID: <42A05A0C.7080708@cadsoft.de> Date: Fri, 03 Jun 2005 15:24:28 +0200 From: Klaus Schmidinger Organization: CadSoft Computer GmbH User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050317) X-Accept-Language: en MIME-Version: 1.0 To: vdr@linuxtv.org Subject: Re: [vdr] Problem with Master Timer's summary.conf (was: VDR developer version 1.3.25) References: In-Reply-To: X-MIME-Autoconverted: from 8bit to quoted-printable by tiger.cadsoft.de id j53DOUMC017232 X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Klaus Schmidinger's VDR List-Id: Klaus Schmidinger's VDR List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2005 13:24:32 -0000 Status: O X-Status: X-Keywords: X-UID: 2750 christian jacobsen wrote: > Hallo Klaus Please always start a new thread - don't reply to the release note. >>- The file 'summary.vdr' has been replaced with 'info.vdr' >>and now contains the >> information about a recording, in the same format as the >>events are stored in >> 'epg.data' (see man vdr(5) for details). Existing summary >>files can be converted >> to the new format by running the Perl script >>'summary2info.pl', as in >> >> summary2info.pl /video >> >> (the parameter given has to be the video directory). If >>there is no 'info.vdr' >> file for a recording, an attempt is made to read a 'summary.vdr'. > > > summary.vdr from Master-Timer is not shown correctly. > > Example what they look like (enriched with infos from tvmovie2vdr). > I would not expect that VDR parses Title or Subtitle ;), but it would be nice if it would just show everything in the file : > > ID: "41615360" > > Title: "Bean" > > Subtitle: "Der ultimative Katastrophenfilm" > > Description: "Spielfilm/Komödie, GB/USA, 1997, FSK: 6 > (Bean) [ DolbyDigital ] > > Kurzkritik: Mr. Bean ist voll in seinem Element! > > Action ** / Thrill * / Humor *** / Allgemein *** > > Museumswärter sorgt in L.A. für Chaos. > Nach einer Millionenspende kann endlich ein amerikanisches Kunstwerk vom Pariser Musée D'Orsay freigekauft und in die Grierson Gallery nach Los Angeles zurückgebracht werden. Um dieses Ereignis gebührend zu feiern, hat man einen Kunstexperten von der Royal National Gallery of England eingeladen. Dr. Bean soll eine feierliche Rede halten - ein grober Fehler, wie sich zeigt. Denn Bean, in Wirklichkeit der Museumswärter, sorgt überall nur für Chaos und Katastrophen! > > Regie: Mel Smith > Darsteller: Rowan Atkinson (Mr. Bean), Harris Yulin (George Grierson), Peter MacNicol (David Langley), Pamela Reed (Alison Langley), Burt Reynolds (Gen. Newton), Johnny Galecki (Stingo Wheelie), Peter Egan (Lord Walton), John Mills (Vorsitzender), Peter Capaldi (Gareth)" > > Greetings > Christian Jacobsen Well, I have only tested with VDR's own summary files ;-) Please try if this helps: The first two lines (separated by an empty line) will be used as Title and ShortText, and the rest (again, separated by an empty line) will be put into the Description. With Master Timer's format this will still be somewhat messy, since in your example it would interpret ID: "41615360" as the Title and Title: "Bean" as the ShortText, but at least all the rest should make it into the Description. Maybe Master Timer should have written its summary.conf the way VDR did ;-) Klaus --- recording.c 2005/05/29 11:16:57 1.107 +++ recording.c 2005/06/03 13:15:54 @@ -480,7 +480,7 @@ char *data[3] = { NULL }; cReadLine ReadLine; char *s; - while ((s = ReadLine.Read(f)) != NULL && line < 3) { + while ((s = ReadLine.Read(f)) != NULL) { if (*s) { if (data[line]) { int len = strlen(s); @@ -492,7 +492,7 @@ else data[line] = strdup(s); } - else + else if (line < 2) line++; } fclose(f);